Changeset 112419 in webkit


Ignore:
Timestamp:
Mar 28, 2012 11:32:28 AM (12 years ago)
Author:
robert@webkit.org
Message:

[REGRESSION] Web Inspector: column caption delimiters are misaligned in DataGrid
https://bugs.webkit.org/show_bug.cgi?id=82193

Reviewed by Yury Semikhatsky.

Since r111742 column width in fixed layout tables is set to the width of the cell plus its left padding plus its right padding
plus half its left border plus half its right border in the collapsing border model. The layout of the panel
headers in the inspector depended on pre-r111742 behaviour, so ended up misaligned with the content below. To cater for the
new method of calculating column width enforce a fixed width for the corner column by removing padding and borders (except collapsed
borders from adjacent cells) and specify the expected width (15px) minus the expected width of the collapsed borders (1px).

  • inspector/front-end/dataGrid.css:

(.data-grid th.corner):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r112418 r112419  
     12012-03-28  Robert Hogan  <robert@webkit.org>
     2
     3        [REGRESSION] Web Inspector: column caption delimiters are misaligned in DataGrid
     4        https://bugs.webkit.org/show_bug.cgi?id=82193
     5
     6        Reviewed by Yury Semikhatsky.
     7
     8        Since r111742 column width in fixed layout tables is set to the width of the cell plus its left padding plus its right padding
     9        plus half its left border plus half its right border in the collapsing border model. The layout of the panel
     10        headers in the inspector depended on pre-r111742 behaviour, so ended up misaligned with the content below. To cater for the
     11        new method of calculating column width enforce a fixed width for the corner column by removing padding and borders (except collapsed
     12        borders from adjacent cells) and specify the expected width (15px) minus the expected width of the collapsed borders (1px).
     13
     14        * inspector/front-end/dataGrid.css:
     15        (.data-grid th.corner):
     16
    1172012-03-28  Alexis Menard  <alexis.menard@openbossa.org>
    218
  • trunk/Source/WebCore/inspector/front-end/dataGrid.css

    r104710 r112419  
    5050
    5151.data-grid th.corner {
    52     width: 15px;
     52    width: 14px;
     53    padding-right: 0px;
     54    padding-left: 0px;
    5355    border-right: 0 none transparent;
    5456}
Note: See TracChangeset for help on using the changeset viewer.