Changeset 112443 in webkit


Ignore:
Timestamp:
Mar 28, 2012 2:33:16 PM (12 years ago)
Author:
Simon Fraser
Message:

download-built-product build step should detect 404 errors
​https://bugs.webkit.org/show_bug.cgi?id=82491

Reviewed by Ryosuke Niwa.

Pass --fail to curl so that it reports 404 errors.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(DownloadBuiltProduct): Pass --fail to curl so that it reports errors.

  • BuildSlaveSupport/built-product-archive:

(extractBuiltProduct): Remove trailing whitespace.

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg

    r112388 r112443  
    235235
    236236class DownloadBuiltProduct(shell.ShellCommand):
    237     command = ["curl", "--output", WithProperties("WebKitBuild/%(configuration)s.zip"), WithProperties(c["buildbotURL"] + "archives/%(fullPlatform)s-%(architecture)s-%(configuration)s/%(got_revision)s.zip")]
     237    command = ["curl", "--fail", "--output", WithProperties("WebKitBuild/%(configuration)s.zip"), WithProperties(c["buildbotURL"] + "archives/%(fullPlatform)s-%(architecture)s-%(configuration)s/%(got_revision)s.zip")]
    238238    name = "download-built-product"
    239239    description = ["downloading built product"]

  • trunk/Tools/BuildSlaveSupport/built-product-archive

    r112440 r112443  
    128128
    129129    elif platform == 'win':
    130         binDirectory = os.path.join(configurationBuildDirectory, "bin")       
     130        binDirectory = os.path.join(configurationBuildDirectory, "bin")
    131131        if os.path.isdir(binDirectory):
    132132            shutil.rmtree(binDirectory)

  • trunk/Tools/ChangeLog

    r112442 r112443  
     12012-03-28  Simon Fraser  <simon.fraser@apple.com>
     2
     3        download-built-product build step should detect 404 errors
     4        https://bugs.webkit.org/show_bug.cgi?id=82491
     5
     6        Reviewed by Ryosuke Niwa.
     7       
     8        Pass --fail to curl so that it reports 404 errors.
     9
     10        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
     11        (DownloadBuiltProduct): Pass --fail to curl so that it reports errors.
     12        * BuildSlaveSupport/built-product-archive:
     13        (extractBuiltProduct): Remove trailing whitespace.
     14
    1152012-03-28  Dirk Pranke  <dpranke@chromium.org>
    216
Note: See TracChangeset for help on using the changeset viewer.