Changeset 112457 in webkit

Timestamp:

Mar 28, 2012 3:32:20 PM (12 years ago)

Author:

andersca@apple.com

Message:

Massive lag opening a link in a new background tab
​https://bugs.webkit.org/show_bug.cgi?id=82542
<rdar://problem/11004502>

Reviewed by Sam Weinig.

Defer waiting for the web process to update the page size until we're actually going to display the layer.
This matches what we do in the non-tiled code path.

• UIProcess/API/mac/WKView.mm:

(-[WKView setFrameSize:]):
(-[WKView updateLayer]):

• UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::waitForPossibleGeometryUpdate):

• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:

(TiledCoreAnimationDrawingAreaProxy):

• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::sizeDidChange):
(WebKit):
(WebKit::TiledCoreAnimationDrawingAreaProxy::waitForPossibleGeometryUpdate):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/mac/WKView.mm (modified) (1 diff)
• UIProcess/DrawingAreaProxy.h (modified) (1 diff)
• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h (modified) (1 diff)
• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-03-28  Anders Carlsson  <andersca@apple.com>
+
+        Massive lag opening a link in a new background tab
+        https://bugs.webkit.org/show_bug.cgi?id=82542
+        <rdar://problem/11004502>
+
+        Reviewed by Sam Weinig.
+
+        Defer waiting for the web process to update the page size until we're actually going to display the layer.
+        This matches what we do in the non-tiled code path.
+
+        * UIProcess/API/mac/WKView.mm:
+        (-[WKView setFrameSize:]):
+        (-[WKView updateLayer]):
+        * UIProcess/DrawingAreaProxy.h:
+        (WebKit::DrawingAreaProxy::waitForPossibleGeometryUpdate):
+        * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
+        (TiledCoreAnimationDrawingAreaProxy):
+        * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
+        (WebKit::TiledCoreAnimationDrawingAreaProxy::sizeDidChange):
+        (WebKit):
+        (WebKit::TiledCoreAnimationDrawingAreaProxy::waitForPossibleGeometryUpdate):
+
 2012-03-28  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm

@@ -2925 +2925 @@
 {
     self.layer.backgroundColor = CGColorGetConstantColor(kCGColorWhite);
+    _data->_page->drawingArea()->waitForPossibleGeometryUpdate();
 }
 #endif

trunk/Source/WebKit2/UIProcess/DrawingAreaProxy.h

@@ -85 +85 @@
 
     virtual void pageCustomRepresentationChanged() { }
+    virtual void waitForPossibleGeometryUpdate() { }
 
 #if USE(UI_SIDE_COMPOSITING)

trunk/Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h

@@ -44 +44 @@
     virtual void layerHostingModeDidChange() OVERRIDE;
     virtual void sizeDidChange() OVERRIDE;
+    virtual void waitForPossibleGeometryUpdate() OVERRIDE;
 
     virtual void enterAcceleratedCompositingMode(uint64_t backingStoreStateID, const LayerTreeContext&) OVERRIDE;

trunk/Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm

@@ -73 +73 @@
 
     sendUpdateGeometry();
+}
+
+void TiledCoreAnimationDrawingAreaProxy::waitForPossibleGeometryUpdate()
+{
+    if (!m_isWaitingForDidUpdateGeometry)
+        return;
 
     if (m_webPageProxy->process()->isLaunching())