Changeset 112458 in webkit

Timestamp:

Mar 28, 2012 3:33:48 PM (12 years ago)

Author:

dpranke@chromium.org

Message:

new-run-webkit-tests doesn't log correctly after retrying failures
​https://bugs.webkit.org/show_bug.cgi?id=82541

Unreviewed, build fix.

r112189 introduced a regression where we would accidentally
delete the log handler after we retried any failing tests - that
meant that any log messages around uploading the results got
dropped.

• Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/controllers/manager.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-03-28  Dirk Pranke  <dpranke@chromium.org>
+
+        new-run-webkit-tests doesn't log correctly after retrying failures
+        https://bugs.webkit.org/show_bug.cgi?id=82541
+
+        Unreviewed, build fix.
+
+        r112189 introduced a regression where we would accidentally
+        delete the log handler after we retried any failing tests - that
+        meant that any log messages around uploading the results got
+        dropped.
+
+        * Scripts/webkitpy/layout_tests/controllers/manager.py:
+        (Manager._run_tests):
+
 2012-03-28  Kevin Ollivier  <kevino@theolliviers.com>
 

trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

@@ -761 +761 @@
             worker_arguments = worker.WorkerArguments(worker_number, self.results_directory(), self._options)
             worker_connection = manager_connection.start_worker(worker_arguments)
-            if self._options.child_processes == 1:
+            if num_workers == 1:
                 # FIXME: We need to be able to share a port with the work so
                 # that some of the tests can query state on the port; ideally