Changeset 112474 in webkit


Ignore:
Timestamp:
Mar 28, 2012 4:55:31 PM (12 years ago)
Author:
Nate Chapin
Message:

Remove dispatchDidLoadMainResource callback, since no
port implements it.
https://bugs.webkit.org/show_bug.cgi?id=82539

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests, just deleting dead code.

  • loader/EmptyClients.h:

(EmptyFrameLoaderClient):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::finishedLoading):
(WebCore::FrameLoader::mainReceivedCompleteError):

  • loader/FrameLoaderClient.h:

(FrameLoaderClient):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::receivedError):
(WebCore::MainResourceLoader::didCancel):

Source/WebKit/blackberry:

  • WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

Source/WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit):

  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore):

  • WebCoreSupport/FrameLoaderClientEfl.h:

(FrameLoaderClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit):

  • WebCoreSupport/FrameLoaderClientGtk.h:

(FrameLoaderClient):

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebKit.order:

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore):

  • WebCoreSupport/FrameLoaderClientQt.h:

(FrameLoaderClientQt):

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit):

  • WebCoreSupport/FrameLoaderClientWinCE.h:

(FrameLoaderClientWinCE):

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore):

  • WebKitSupport/FrameLoaderClientWx.h:

(FrameLoaderClientWx):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
Location:
trunk/Source
Files:
34 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r112473 r112474  
     12012-03-28  Nate Chapin  <japhet@chromium.org>
     2
     3        Remove dispatchDidLoadMainResource callback, since no
     4        port implements it.
     5        https://bugs.webkit.org/show_bug.cgi?id=82539
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        No new tests, just deleting dead code.
     10
     11        * loader/EmptyClients.h:
     12        (EmptyFrameLoaderClient):
     13        * loader/FrameLoader.cpp:
     14        (WebCore::FrameLoader::finishedLoading):
     15        (WebCore::FrameLoader::mainReceivedCompleteError):
     16        * loader/FrameLoaderClient.h:
     17        (FrameLoaderClient):
     18        * loader/MainResourceLoader.cpp:
     19        (WebCore::MainResourceLoader::receivedError):
     20        (WebCore::MainResourceLoader::didCancel):
     21
    1222012-03-28  Enrica Casucci  <enrica@apple.com>
    223
  • trunk/Source/WebCore/loader/EmptyClients.h

    r111361 r112474  
    306306    virtual void dispatchWillSubmitForm(FramePolicyFunction, PassRefPtr<FormState>) { }
    307307
    308     virtual void dispatchDidLoadMainResource(DocumentLoader*) { }
    309308    virtual void revertToProvisionalState(DocumentLoader*) { }
    310309    virtual void setMainDocumentError(DocumentLoader*, const ResourceError&) { }
  • trunk/Source/WebCore/loader/FrameLoader.cpp

    r112308 r112474  
    19841984        return;
    19851985    dl->setPrimaryLoadComplete(true);
    1986     m_client->dispatchDidLoadMainResource(dl.get());
    19871986    checkLoadComplete();
    19881987}
     
    30863085{
    30873086    loader->setPrimaryLoadComplete(true);
    3088     m_client->dispatchDidLoadMainResource(activeDocumentLoader());
    30893087    checkCompleted();
    30903088    if (m_frame->page())
  • trunk/Source/WebCore/loader/FrameLoaderClient.h

    r111537 r112474  
    180180        virtual void dispatchWillSubmitForm(FramePolicyFunction, PassRefPtr<FormState>) = 0;
    181181
    182         virtual void dispatchDidLoadMainResource(DocumentLoader*) = 0;
    183182        virtual void revertToProvisionalState(DocumentLoader*) = 0;
    184183        virtual void setMainDocumentError(DocumentLoader*, const ResourceError&) = 0;
  • trunk/Source/WebKit/blackberry/ChangeLog

    r112385 r112474  
     12012-03-28  Nate Chapin  <japhet@chromium.org>
     2
     3        Remove dispatchDidLoadMainResource callback, since no
     4        port implements it.
     5        https://bugs.webkit.org/show_bug.cgi?id=82539
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        * WebCoreSupport/FrameLoaderClientBlackBerry.h:
     10        (FrameLoaderClientBlackBerry):
     11
    1122012-03-28  Leo Yang  <leo.yang@torchmobile.com.cn>
    213
  • trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.h

    r111546 r112474  
    9494    virtual void dispatchUnableToImplementPolicy(const ResourceError&) { notImplemented(); }
    9595    virtual void dispatchWillSubmitForm(FramePolicyFunction, PassRefPtr<FormState>);
    96     virtual void dispatchDidLoadMainResource(DocumentLoader*) { notImplemented(); }
    9796    virtual void revertToProvisionalState(DocumentLoader*) { notImplemented(); }
    9897    virtual void setMainDocumentError(DocumentLoader*, const ResourceError&);
  • trunk/Source/WebKit/chromium/ChangeLog

    r112467 r112474  
     12012-03-28  Nate Chapin  <japhet@chromium.org>
     2
     3        Remove dispatchDidLoadMainResource callback, since no
     4        port implements it.
     5        https://bugs.webkit.org/show_bug.cgi?id=82539
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        * src/FrameLoaderClientImpl.cpp:
     10        (WebKit):
     11        * src/FrameLoaderClientImpl.h:
     12        (FrameLoaderClientImpl):
     13
    1142012-03-28  Dirk Pranke  <dpranke@chromium.org>
    215
  • trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp

    r111537 r112474  
    10511051}
    10521052
    1053 void FrameLoaderClientImpl::dispatchDidLoadMainResource(DocumentLoader*)
    1054 {
    1055     // FIXME
    1056 }
    1057 
    10581053void FrameLoaderClientImpl::revertToProvisionalState(DocumentLoader*)
    10591054{
  • trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.h

    r111537 r112474  
    119119    virtual void dispatchWillSendSubmitEvent(WebCore::HTMLFormElement*);
    120120    virtual void dispatchWillSubmitForm(WebCore::FramePolicyFunction, PassRefPtr<WebCore::FormState>);
    121     virtual void dispatchDidLoadMainResource(WebCore::DocumentLoader*);
    122121    virtual void revertToProvisionalState(WebCore::DocumentLoader*);
    123122    virtual void setMainDocumentError(WebCore::DocumentLoader*, const WebCore::ResourceError&);
  • trunk/Source/WebKit/efl/ChangeLog

    r112234 r112474  
     12012-03-28  Nate Chapin  <japhet@chromium.org>
     2
     3        Remove dispatchDidLoadMainResource callback, since no
     4        port implements it.
     5        https://bugs.webkit.org/show_bug.cgi?id=82539
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        * WebCoreSupport/FrameLoaderClientEfl.cpp:
     10        (WebCore):
     11        * WebCoreSupport/FrameLoaderClientEfl.h:
     12        (FrameLoaderClientEfl):
     13
    1142012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
    215
  • trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp

    r111361 r112474  
    629629}
    630630
    631 void FrameLoaderClientEfl::dispatchDidLoadMainResource(DocumentLoader*)
    632 {
    633     notImplemented();
    634 }
    635 
    636631void FrameLoaderClientEfl::revertToProvisionalState(DocumentLoader*)
    637632{
  • trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h

    r111361 r112474  
    123123    virtual void dispatchWillSubmitForm(FramePolicyFunction, WTF::PassRefPtr<FormState>);
    124124
    125     virtual void dispatchDidLoadMainResource(DocumentLoader*);
    126125    virtual void revertToProvisionalState(DocumentLoader*);
    127126    virtual void setMainDocumentError(DocumentLoader*, const ResourceError&);
  • trunk/Source/WebKit/gtk/ChangeLog

    r112401 r112474  
     12012-03-28  Nate Chapin  <japhet@chromium.org>
     2
     3        Remove dispatchDidLoadMainResource callback, since no
     4        port implements it.
     5        https://bugs.webkit.org/show_bug.cgi?id=82539
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        * WebCoreSupport/FrameLoaderClientGtk.cpp:
     10        (WebKit):
     11        * WebCoreSupport/FrameLoaderClientGtk.h:
     12        (FrameLoaderClient):
     13
    1142012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
    215
  • trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp

    r111696 r112474  
    883883}
    884884
    885 void FrameLoaderClient::dispatchDidLoadMainResource(WebCore::DocumentLoader*)
    886 {
    887     notImplemented();
    888 }
    889 
    890885void FrameLoaderClient::revertToProvisionalState(WebCore::DocumentLoader*)
    891886{
  • trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h

    r111361 r112474  
    106106        virtual void dispatchWillSubmitForm(WebCore::FramePolicyFunction, WTF::PassRefPtr<WebCore::FormState>);
    107107
    108         virtual void dispatchDidLoadMainResource(WebCore::DocumentLoader*);
    109108        virtual void revertToProvisionalState(WebCore::DocumentLoader*);
    110109        virtual void setMainDocumentError(WebCore::DocumentLoader*, const WebCore::ResourceError&);
  • trunk/Source/WebKit/mac/ChangeLog

    r112424 r112474  
     12012-03-28  Nate Chapin  <japhet@chromium.org>
     2
     3        Remove dispatchDidLoadMainResource callback, since no
     4        port implements it.
     5        https://bugs.webkit.org/show_bug.cgi?id=82539
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        * WebCoreSupport/WebFrameLoaderClient.h:
     10        * WebCoreSupport/WebFrameLoaderClient.mm:
     11        * WebKit.order:
     12
    1132012-03-28  Joseph Pecoraro  <pecoraro@apple.com>
    214
  • trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h

    r111361 r112474  
    128128    virtual void dispatchWillSubmitForm(WebCore::FramePolicyFunction, PassRefPtr<WebCore::FormState>) OVERRIDE;
    129129
    130     virtual void dispatchDidLoadMainResource(WebCore::DocumentLoader*) OVERRIDE;
    131130    virtual void revertToProvisionalState(WebCore::DocumentLoader*) OVERRIDE;
    132131    virtual void setMainDocumentError(WebCore::DocumentLoader*, const WebCore::ResourceError&) OVERRIDE;
  • trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm

    r112184 r112474  
    772772}
    773773
    774 void WebFrameLoaderClient::dispatchDidLoadMainResource(DocumentLoader* loader)
    775 {
    776 }
    777 
    778774void WebFrameLoaderClient::revertToProvisionalState(DocumentLoader* loader)
    779775{
  • trunk/Source/WebKit/mac/WebKit.order

    r111824 r112474  
    770770-[WebFrame(WebPrivate) _pendingFrameUnloadEventCount]
    771771__ZN20WebFrameLoaderClient29dispatchDidHandleOnloadEventsEv
    772 __ZN20WebFrameLoaderClient27dispatchDidLoadMainResourceEPN7WebCore14DocumentLoaderE
    773772__ZN20WebFrameLoaderClient21dispatchDidFinishLoadEv
    774773-[WebView(WebPrivate) _didFinishLoadForFrame:]
  • trunk/Source/WebKit/qt/ChangeLog

    r111504 r112474  
     12012-03-28  Nate Chapin  <japhet@chromium.org>
     2
     3        Remove dispatchDidLoadMainResource callback, since no
     4        port implements it.
     5        https://bugs.webkit.org/show_bug.cgi?id=82539
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        * WebCoreSupport/FrameLoaderClientQt.cpp:
     10        (WebCore):
     11        * WebCoreSupport/FrameLoaderClientQt.h:
     12        (FrameLoaderClientQt):
     13
    1142012-03-20  Eric Seidel  <eric@webkit.org>
    215
  • trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp

    r111361 r112474  
    568568
    569569
    570 void FrameLoaderClientQt::dispatchDidLoadMainResource(DocumentLoader*)
    571 {
    572 }
    573 
    574 
    575570void FrameLoaderClientQt::revertToProvisionalState(DocumentLoader*)
    576571{
  • trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h

    r111361 r112474  
    139139    virtual void dispatchWillSubmitForm(FramePolicyFunction, PassRefPtr<FormState>);
    140140
    141     virtual void dispatchDidLoadMainResource(DocumentLoader*);
    142141    virtual void revertToProvisionalState(DocumentLoader*);
    143142    virtual void setMainDocumentError(DocumentLoader*, const ResourceError&);
  • trunk/Source/WebKit/win/ChangeLog

    r112184 r112474  
     12012-03-28  Nate Chapin  <japhet@chromium.org>
     2
     3        Remove dispatchDidLoadMainResource callback, since no
     4        port implements it.
     5        https://bugs.webkit.org/show_bug.cgi?id=82539
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        * WebCoreSupport/WebFrameLoaderClient.cpp:
     10        * WebCoreSupport/WebFrameLoaderClient.h:
     11        (WebFrameLoaderClient):
     12
    1132012-03-26  Adam Barth  <abarth@webkit.org>
    214
  • trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp

    r111361 r112474  
    461461}
    462462
    463 void WebFrameLoaderClient::dispatchDidLoadMainResource(DocumentLoader*)
    464 {
    465 }
    466 
    467463void WebFrameLoaderClient::setMainDocumentError(DocumentLoader*, const ResourceError& error)
    468464{
  • trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h

    r111361 r112474  
    8181    virtual void dispatchShow();
    8282
    83     virtual void dispatchDidLoadMainResource(WebCore::DocumentLoader*);
    8483    virtual void setMainDocumentError(WebCore::DocumentLoader*, const WebCore::ResourceError&);
    8584
  • trunk/Source/WebKit/wince/ChangeLog

    r111361 r112474  
     12012-03-28  Nate Chapin  <japhet@chromium.org>
     2
     3        Remove dispatchDidLoadMainResource callback, since no
     4        port implements it.
     5        https://bugs.webkit.org/show_bug.cgi?id=82539
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        * WebCoreSupport/FrameLoaderClientWinCE.cpp:
     10        (WebKit):
     11        * WebCoreSupport/FrameLoaderClientWinCE.h:
     12        (FrameLoaderClientWinCE):
     13
    1142012-03-19  Adam Barth  <abarth@webkit.org>
    215
  • trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.cpp

    r111361 r112474  
    397397}
    398398
    399 void FrameLoaderClientWinCE::dispatchDidLoadMainResource(DocumentLoader*)
    400 {
    401     notImplemented();
    402 }
    403 
    404399void FrameLoaderClientWinCE::revertToProvisionalState(DocumentLoader*)
    405400{
  • trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.h

    r111361 r112474  
    100100    virtual void dispatchWillSubmitForm(WebCore::FramePolicyFunction, WTF::PassRefPtr<WebCore::FormState>);
    101101
    102     virtual void dispatchDidLoadMainResource(WebCore::DocumentLoader*);
    103102    virtual void revertToProvisionalState(WebCore::DocumentLoader*);
    104103    virtual void setMainDocumentError(WebCore::DocumentLoader*, const WebCore::ResourceError&);
  • trunk/Source/WebKit/wx/ChangeLog

    r112034 r112474  
     12012-03-28  Nate Chapin  <japhet@chromium.org>
     2
     3        Remove dispatchDidLoadMainResource callback, since no
     4        port implements it.
     5        https://bugs.webkit.org/show_bug.cgi?id=82539
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        * WebKitSupport/FrameLoaderClientWx.cpp:
     10        (WebCore):
     11        * WebKitSupport/FrameLoaderClientWx.h:
     12        (FrameLoaderClientWx):
     13
    1142012-03-25  Kevin Ollivier  <kevino@theolliviers.com>
    215
  • trunk/Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp

    r112034 r112474  
    386386
    387387
    388 void FrameLoaderClientWx::dispatchDidLoadMainResource(DocumentLoader*)
    389 {
    390     notImplemented();
    391 }
    392 
    393 
    394388void FrameLoaderClientWx::revertToProvisionalState(DocumentLoader*)
    395389{
  • trunk/Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.h

    r111361 r112474  
    121121        virtual void dispatchWillSubmitForm(FramePolicyFunction, PassRefPtr<FormState>);
    122122
    123         virtual void dispatchDidLoadMainResource(DocumentLoader*);
    124123        virtual void revertToProvisionalState(DocumentLoader*);
    125124
  • trunk/Source/WebKit2/ChangeLog

    r112457 r112474  
     12012-03-28  Nate Chapin  <japhet@chromium.org>
     2
     3        Remove dispatchDidLoadMainResource callback, since no
     4        port implements it.
     5        https://bugs.webkit.org/show_bug.cgi?id=82539
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
     10        * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
     11
    1122012-03-28  Anders Carlsson  <andersca@apple.com>
    213
  • trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp

    r112338 r112474  
    754754}
    755755
    756 void WebFrameLoaderClient::dispatchDidLoadMainResource(DocumentLoader*)
    757 {
    758     notImplemented();
    759 }
    760 
    761756void WebFrameLoaderClient::revertToProvisionalState(DocumentLoader*)
    762757{
  • trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h

    r111361 r112474  
    110110    virtual void dispatchWillSubmitForm(WebCore::FramePolicyFunction, PassRefPtr<WebCore::FormState>) OVERRIDE;
    111111   
    112     virtual void dispatchDidLoadMainResource(WebCore::DocumentLoader*) OVERRIDE;
    113112    virtual void revertToProvisionalState(WebCore::DocumentLoader*) OVERRIDE;
    114113    virtual void setMainDocumentError(WebCore::DocumentLoader*, const WebCore::ResourceError&) OVERRIDE;
Note: See TracChangeset for help on using the changeset viewer.