Changeset 112475 in webkit

Timestamp:

Mar 28, 2012 4:57:16 PM (12 years ago)

Author:

eae@chromium.org

Message:

Change FilterOperations::getOutsets to use integers
​https://bugs.webkit.org/show_bug.cgi?id=82535

Reviewed by Eric Seidel.

FilterOperations::getOutsets calculates the outsets using integers and
the values are guranteed to be set to full-pixel values. By changing the
function signature we communicate this fact better and avoid unnecessary
type conversions in some cases.

No new tests.

• platform/graphics/filters/FilterOperations.cpp:

(WebCore::FilterOperations::getOutsets):

• platform/graphics/filters/FilterOperations.h:

(FilterOperations):

• rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::addVisualEffectOverflow):

• rendering/RenderInline.cpp:

(WebCore::RenderInline::computeRectForRepaint):

• rendering/style/RenderStyle.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/filters/FilterOperations.cpp (modified) (1 diff)
• platform/graphics/filters/FilterOperations.h (modified) (1 diff)
• rendering/RenderBox.cpp (modified) (2 diffs)
• rendering/RenderInline.cpp (modified) (1 diff)
• rendering/style/RenderStyle.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-28  Emil A Eklund  <eae@chromium.org>
+
+        Change FilterOperations::getOutsets to use integers
+        https://bugs.webkit.org/show_bug.cgi?id=82535
+
+        Reviewed by Eric Seidel.
+
+        FilterOperations::getOutsets calculates the outsets using integers and
+        the values are guranteed to be set to full-pixel values. By changing the
+        function signature we communicate this fact better and avoid unnecessary
+        type conversions in some cases.
+
+        No new tests.
+
+        * platform/graphics/filters/FilterOperations.cpp:
+        (WebCore::FilterOperations::getOutsets):
+        * platform/graphics/filters/FilterOperations.h:
+        (FilterOperations):
+        * rendering/RenderBox.cpp:
+        (WebCore::RenderBox::computeRectForRepaint):
+        (WebCore::RenderBox::addVisualEffectOverflow):
+        * rendering/RenderInline.cpp:
+        (WebCore::RenderInline::computeRectForRepaint):
+        * rendering/style/RenderStyle.h:
+
 2012-03-28  Nate Chapin  <japhet@chromium.org>
 

trunk/Source/WebCore/platform/graphics/filters/FilterOperations.cpp

@@ -98 +98 @@
 }
 
-void FilterOperations::getOutsets(LayoutUnit& top, LayoutUnit& right, LayoutUnit& bottom, LayoutUnit& left) const
+void FilterOperations::getOutsets(int& top, int& right, int& bottom, int& left) const
 {
     top = 0;

trunk/Source/WebCore/platform/graphics/filters/FilterOperations.h

@@ -65 +65 @@
 
     bool hasOutsets() const;
-    void getOutsets(LayoutUnit& top, LayoutUnit& right, LayoutUnit& bottom, LayoutUnit& left) const;
+    void getOutsets(int& top, int& right, int& bottom, int& left) const;
 
     bool hasFilterThatAffectsOpacity() const;

trunk/Source/WebCore/rendering/RenderBox.cpp

@@ -1646 +1646 @@
 #if ENABLE(CSS_FILTERS)
     if (styleToUse->hasFilterOutsets()) {
-        LayoutUnit topOutset;
-        LayoutUnit rightOutset;
-        LayoutUnit bottomOutset;
-        LayoutUnit leftOutset;
+        int topOutset;
+        int rightOutset;
+        int bottomOutset;
+        int leftOutset;
         styleToUse->filter().getOutsets(topOutset, rightOutset, bottomOutset, leftOutset);
         rect.move(-leftOutset, -topOutset);
@@ -3684 +3684 @@
     // Compute any filter outset overflow.
     if (style()->hasFilterOutsets()) {
-        LayoutUnit filterOutsetLeft;
-        LayoutUnit filterOutsetRight;
-        LayoutUnit filterOutsetTop;
-        LayoutUnit filterOutsetBottom;
+        int filterOutsetLeft;
+        int filterOutsetRight;
+        int filterOutsetTop;
+        int filterOutsetBottom;
         style()->getFilterOutsets(filterOutsetTop, filterOutsetRight, filterOutsetBottom, filterOutsetLeft);
         

trunk/Source/WebCore/rendering/RenderInline.cpp

@@ -1115 +1115 @@
 #if ENABLE(CSS_FILTERS)
     if (style()->hasFilterOutsets()) {
-        LayoutUnit topOutset;
-        LayoutUnit rightOutset;
-        LayoutUnit bottomOutset;
-        LayoutUnit leftOutset;
+        int topOutset;
+        int rightOutset;
+        int bottomOutset;
+        int leftOutset;
         style()->filter().getOutsets(topOutset, rightOutset, bottomOutset, leftOutset);
         rect.move(-leftOutset, -topOutset);

trunk/Source/WebCore/rendering/style/RenderStyle.h

@@ -466 +466 @@
 
 #if ENABLE(CSS_FILTERS)
-    void getFilterOutsets(LayoutUnit& top, LayoutUnit& right, LayoutUnit& bottom, LayoutUnit& left) const
+    void getFilterOutsets(int& top, int& right, int& bottom, int& left) const
     {
         if (hasFilter())