Changeset 112492 in webkit


Ignore:
Timestamp:
Mar 28, 2012 7:11:40 PM (12 years ago)
Author:
eae@chromium.org
Message:

Fix rounding in RenderInline::paintOutlineForLine
https://bugs.webkit.org/show_bug.cgi?id=82540

Reviewed by Eric Seidel.

No new tests, no change in functionality.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutlineForLine):
Change paintOutlineForLine to pixel snap the left and right edges of the
lines instead of adding the offset to an already rounded number.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r112490 r112492  
     12012-03-28  Emil A Eklund  <eae@chromium.org>
     2
     3        Fix rounding in RenderInline::paintOutlineForLine
     4        https://bugs.webkit.org/show_bug.cgi?id=82540
     5
     6        Reviewed by Eric Seidel.
     7
     8        No new tests, no change in functionality.
     9
     10        * rendering/RenderInline.cpp:
     11        (WebCore::RenderInline::paintOutlineForLine):
     12        Change paintOutlineForLine to pixel snap the left and right edges of the
     13        lines instead of adding the offset to an already rounded number.
     14
    1152012-03-28  David Grogan  <dgrogan@chromium.org>
    216
  • trunk/Source/WebCore/rendering/RenderInline.cpp

    r112475 r112492  
    14661466
    14671467    IntRect pixelSnappedBox = pixelSnappedIntRect(box);
     1468    IntRect pixelSnappedLastLine = pixelSnappedIntRect(paintOffset.x() + lastline.x(), 0, lastline.width(), 0);
     1469    IntRect pixelSnappedNextLine = pixelSnappedIntRect(paintOffset.x() + nextline.x(), 0, nextline.width(), 0);
    14681470   
    14691471    // left edge
     
    14951497            pixelSnappedBox.x() - outlineWidth,
    14961498            pixelSnappedBox.y() - outlineWidth,
    1497             min(pixelSnappedBox.maxX() + outlineWidth, (lastline.isEmpty() ? 1000000 : paintOffset.x() + lastline.x())),
     1499            min(pixelSnappedBox.maxX() + outlineWidth, (lastline.isEmpty() ? 1000000 : pixelSnappedLastLine.x())),
    14981500            pixelSnappedBox.y(),
    14991501            BSTop, outlineColor, outlineStyle,
     
    15041506    if (lastline.maxX() < thisline.maxX())
    15051507        drawLineForBoxSide(graphicsContext,
    1506             max(lastline.isEmpty() ? -1000000 : paintOffset.x() + lastline.maxX(), pixelSnappedBox.x() - outlineWidth),
     1508            max(lastline.isEmpty() ? -1000000 : pixelSnappedLastLine.maxX(), pixelSnappedBox.x() - outlineWidth),
    15071509            pixelSnappedBox.y() - outlineWidth,
    15081510            pixelSnappedBox.maxX() + outlineWidth,
     
    15281530            pixelSnappedBox.x() - outlineWidth,
    15291531            pixelSnappedBox.maxY(),
    1530             min(pixelSnappedBox.maxX() + outlineWidth, !nextline.isEmpty() ? paintOffset.x() + nextline.x() + 1 : 1000000),
     1532            min(pixelSnappedBox.maxX() + outlineWidth, !nextline.isEmpty() ? pixelSnappedNextLine.x() + 1 : 1000000),
    15311533            pixelSnappedBox.maxY() + outlineWidth,
    15321534            BSBottom, outlineColor, outlineStyle,
     
    15371539    if (nextline.maxX() < thisline.maxX())
    15381540        drawLineForBoxSide(graphicsContext,
    1539             max(!nextline.isEmpty() ? paintOffset.x() + nextline.maxX() : -1000000, pixelSnappedBox.x() - outlineWidth),
     1541            max(!nextline.isEmpty() ? pixelSnappedNextLine.maxX() : -1000000, pixelSnappedBox.x() - outlineWidth),
    15401542            pixelSnappedBox.maxY(),
    15411543            pixelSnappedBox.maxX() + outlineWidth,
Note: See TracChangeset for help on using the changeset viewer.