Changeset 112494 in webkit

Timestamp:

Mar 28, 2012 7:32:50 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry]Missing cookies from HTTP response header in Network tab of Web Inspector.
​https://bugs.webkit.org/show_bug.cgi?id=82041

We shouldn't overwrite cookies of response if there are more than one
header of Set-Cookie.

Patch by Jason Liu <​jason.liu@torchmobile.com.cn> on 2012-03-28
Reviewed by Rob Buis.

Test: http/tests/cookies/resources/setArraycookies.php

• platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyHeaderReceived):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/blackberry/NetworkJob.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-28  Jason Liu  <jason.liu@torchmobile.com.cn>
+
+        [BlackBerry]Missing cookies from HTTP response header in Network tab of Web Inspector.
+        https://bugs.webkit.org/show_bug.cgi?id=82041
+
+        We shouldn't overwrite cookies of response if there are more than one
+        header of Set-Cookie.
+
+        Reviewed by Rob Buis.
+
+        Test: http/tests/cookies/resources/setArraycookies.php
+
+        * platform/network/blackberry/NetworkJob.cpp:
+        (WebCore::NetworkJob::handleNotifyHeaderReceived):
+
 2012-03-28  Noel Gordon  <noel.gordon@gmail.com>
 

trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp

@@ -307 +307 @@
             && static_cast<FrameLoaderClientBlackBerry*>(m_frame->loader()->client())->cookiesEnabled())
             handleSetCookieHeader(value);
+
+        if (m_response.httpHeaderFields().contains("Set-Cookie")) {
+            m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + "\r\n" + value);
+            return;
+        }
     }