Changeset 112502 in webkit


Ignore:
Timestamp:
Mar 28, 2012 10:47:18 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Consider removal of removes jsNull()/v8::Null() from JSInternalsCustom.cpp/V8InternalsCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=82442

Patch by Vineet Chaudhary <Vineet> on 2012-03-28
Reviewed by Kentaro Hara.

No new tests. LayoutTests/fast/harness/user-preferred-language.html should pass
even after these changes.

  • testing/js/JSInternalsCustom.cpp: Remove jsNull() if Vector is empty.

(WebCore::JSInternals::userPreferredLanguages):

  • testing/v8/V8InternalsCustom.cpp: Remove v8::Null() if Vector is empty.

(WebCore::V8Internals::userPreferredLanguagesAccessorGetter):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r112500 r112502  
     12012-03-28  Vineet Chaudhary  <rgf748@motorola.com>
     2
     3        Consider removal of removes jsNull()/v8::Null() from JSInternalsCustom.cpp/V8InternalsCustom.cpp
     4        https://bugs.webkit.org/show_bug.cgi?id=82442
     5
     6        Reviewed by Kentaro Hara.
     7
     8        No new tests. LayoutTests/fast/harness/user-preferred-language.html should pass
     9        even after these changes.
     10
     11        * testing/js/JSInternalsCustom.cpp: Remove jsNull() if Vector is empty.
     12        (WebCore::JSInternals::userPreferredLanguages):
     13        * testing/v8/V8InternalsCustom.cpp: Remove v8::Null() if Vector is empty.
     14        (WebCore::V8Internals::userPreferredLanguagesAccessorGetter):
     15
    1162012-03-28  Hayato Ito  <hayato@chromium.org>
    217
  • trunk/Source/WebCore/testing/js/JSInternalsCustom.cpp

    r105698 r112502  
    3737    Internals* imp = static_cast<Internals*>(impl());
    3838    const Vector<String> languages = imp->userPreferredLanguages();
    39     if (languages.isEmpty())
    40         return jsNull();
    4139   
    4240    MarkedArgumentBuffer array;
  • trunk/Source/WebCore/testing/v8/V8InternalsCustom.cpp

    r105315 r112502  
    3636    Internals* internals = V8Internals::toNative(info.Holder());
    3737    const Vector<String> languages = internals->userPreferredLanguages();
    38     if (languages.isEmpty())
    39         return v8::Null();
    4038
    4139    v8::Local<v8::Array> array = v8::Array::New(languages.size());
Note: See TracChangeset for help on using the changeset viewer.