Changeset 112526 in webkit


Ignore:
Timestamp:
Mar 29, 2012 5:53:08 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Remove redundant updateViewportArguments() call when page is restored from page cache.
https://bugs.webkit.org/show_bug.cgi?id=82500

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-03-29
Reviewed by Kenneth Rohde Christiansen.

.:

Add manual test for history navigation with viewport width check.

  • ManualTests/viewport-width-test-after-history-navigation.html: Added.

Source/WebCore:

Document::updateViewportArguments() is called twice, while restoring a page from page cache.
First, it is called when the document is set on the mainframe and later, it is called
when page cache finished the restoration. Since viewport arguments don't change between
the 2 calls, it's safe to remove the second.

Manual test added. Viewport value updates heavily depend on UI process code.

  • dom/Document.cpp:

(WebCore::Document::documentDidResumeFromPageCache):

Location:
trunk
Files:
1 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/ChangeLog

    r112456 r112526  
     12012-03-29  Zalan Bujtas  <zbujtas@gmail.com>
     2
     3        Remove redundant updateViewportArguments() call when page is restored from page cache.
     4        https://bugs.webkit.org/show_bug.cgi?id=82500
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Add manual test for history navigation with viewport width check.
     9
     10        * ManualTests/viewport-width-test-after-history-navigation.html: Added.
     11
    1122012-03-28  Kevin Ollivier  <kevino@theolliviers.com>
    213
  • trunk/Source/WebCore/ChangeLog

    r112525 r112526  
     12012-03-29  Zalan Bujtas  <zbujtas@gmail.com>
     2
     3        Remove redundant updateViewportArguments() call when page is restored from page cache.
     4        https://bugs.webkit.org/show_bug.cgi?id=82500
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Document::updateViewportArguments() is called twice, while restoring a page from page cache.
     9        First, it is called when the document is set on the mainframe and later, it is called
     10        when page cache finished the restoration. Since viewport arguments don't change between
     11        the 2 calls, it's safe to remove the second.
     12
     13        Manual test added. Viewport value updates heavily depend on UI process code.
     14
     15        * dom/Document.cpp:
     16        (WebCore::Document::documentDidResumeFromPageCache):
     17
    1182012-03-29  Charles Wei  <charles.wei@torchmobile.com.cn>
    219
  • trunk/Source/WebCore/dom/Document.cpp

    r112453 r112526  
    42234223    ASSERT(m_frame);
    42244224    m_frame->loader()->client()->dispatchDidBecomeFrameset(isFrameSet());
    4225 
    4226     updateViewportArguments();
    42274225}
    42284226
Note: See TracChangeset for help on using the changeset viewer.