Changeset 112531 in webkit

Timestamp:

Mar 29, 2012 7:43:24 AM (12 years ago)

Author:

caseq@chromium.org

Message:

Web Inspector: on a single click in Timeline overview, make a minimal selection centered around cursor
​https://bugs.webkit.org/show_bug.cgi?id=82616

Reviewed by Pavel Feldman.

• inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewWindow): Explicitly handle single click on overview by creating a minimal window around cursor.
(WebInspector.TimelineOverviewWindow.prototype._resizeWindowMinimum):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TimelineOverviewPane.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-29  Andrey Kosyakov  <caseq@chromium.org>
+
+        Web Inspector: on a single click in Timeline overview, make a minimal selection centered around cursor
+        https://bugs.webkit.org/show_bug.cgi?id=82616
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/TimelineOverviewPane.js:
+        (WebInspector.TimelineOverviewWindow): Explicitly handle single click on overview by creating a minimal window around cursor.
+        (WebInspector.TimelineOverviewWindow.prototype._resizeWindowMinimum):
+
 2012-03-29  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
 

trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js

@@ -369 +369 @@
     this._parentElement.addEventListener("mousewheel", this.scrollWindow.bind(this), true);
     this._parentElement.addEventListener("dblclick", this._resizeWindowMaximum.bind(this), true);
+    this._parentElement.addEventListener("click", this._resizeWindowMinimum.bind(this), true);
 
     this._overviewWindowElement = document.createElement("div");
@@ -510 +511 @@
     {
         this._setWindowPosition(0, this._parentElement.clientWidth);
+    },
+
+    _resizeWindowMinimum: function(event)
+    {
+        WebInspector.elementDragEnd(event);
+        var middle = event.pageX - this._parentElement.offsetLeft;
+        var start = Math.max(middle - WebInspector.TimelineOverviewPane.MinSelectableSize / 2, 0);
+        var end = Math.min(middle + WebInspector.TimelineOverviewPane.MinSelectableSize / 2, this._parentElement.clientWidth);
+        this._setWindowPosition(start, end);
     },