Changeset 112580 in webkit

Timestamp:

Mar 29, 2012 2:48:38 PM (12 years ago)

Author:

Simon Fraser

Message:

Scripts fail to detect when a tool crashes
​https://bugs.webkit.org/show_bug.cgi?id=82659

Reviewed by Mark Rowe.

Have exitStatus() detect when the process fail to exit cleanly
(possibly because of a crash), and return a non-zero exit code
in that case.

• Scripts/VCSUtils.pm:

(exitStatus):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/VCSUtils.pm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-03-29  Simon Fraser  <simon.fraser@apple.com>
+
+        Scripts fail to detect when a tool crashes
+        https://bugs.webkit.org/show_bug.cgi?id=82659
+
+        Reviewed by Mark Rowe.
+        
+        Have exitStatus() detect when the process fail to exit cleanly
+        (possibly because of a crash), and return a non-zero exit code
+        in that case.
+
+        * Scripts/VCSUtils.pm:
+        (exitStatus):
+
 2012-03-29  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
 

trunk/Tools/Scripts/VCSUtils.pm

@@ -121 +121 @@
         return $returnvalue >> 8;
     }
+    if (!WIFEXITED($returnvalue)) {
+        return 254;
+    }
     return WEXITSTATUS($returnvalue);
 }