Changeset 112911 in webkit


Ignore:
Timestamp:
Apr 2, 2012 11:15:33 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r112851.
​http://trac.webkit.org/changeset/112851
​https://bugs.webkit.org/show_bug.cgi?id=82915

Broke 3 Mac accessibility tests (Requested by enrica on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-02

Source/WebCore:

  • accessibility/AXObjectCache.cpp:
  • accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::handleScrolledToAnchor):
(WebCore):

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::handleScrolledToAnchor):
(WebCore):

LayoutTests:

  • accessibility/anchor-link-selection-and-focus-expected.txt: Removed.
  • accessibility/anchor-link-selection-and-focus.html: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/accessibility/anchor-link-selection-and-focus-expected.txt: Removed.
Location:
trunk
Files:
3 deleted
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r112904 r112911  
     12012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r112851.
     4        http://trac.webkit.org/changeset/112851
     5        https://bugs.webkit.org/show_bug.cgi?id=82915
     6
     7        Broke 3 Mac accessibility tests (Requested by enrica on
     8        #webkit).
     9
     10        * accessibility/anchor-link-selection-and-focus-expected.txt: Removed.
     11        * accessibility/anchor-link-selection-and-focus.html: Removed.
     12        * platform/chromium/test_expectations.txt:
     13        * platform/gtk/accessibility/anchor-link-selection-and-focus-expected.txt: Removed.
     14
    1152012-04-02  Stephen Chenney  <schenney@chromium.org>
    216

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r112904 r112911  
    12801280BUGCR10322 SKIP : platform/mac/accessibility = PASS FAIL
    12811281BUGCR10322 SKIP : platform/win/accessibility = PASS FAIL
    1282 BUGCR10322 SKIP : accessibility/anchor-link-selection-and-focus.html = TEXT
    12831282BUGCR10322 SKIP : accessibility/aria-activedescendant-crash.html = TEXT
    12841283BUGCR10322 SKIP : accessibility/aria-combobox.html = TEXT

  • trunk/Source/WebCore/ChangeLog

    r112910 r112911  
     12012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r112851.
     4        http://trac.webkit.org/changeset/112851
     5        https://bugs.webkit.org/show_bug.cgi?id=82915
     6
     7        Broke 3 Mac accessibility tests (Requested by enrica on
     8        #webkit).
     9
     10        * accessibility/AXObjectCache.cpp:
     11        * accessibility/gtk/AXObjectCacheAtk.cpp:
     12        (WebCore::AXObjectCache::handleScrolledToAnchor):
     13        (WebCore):
     14        * accessibility/mac/AXObjectCacheMac.mm:
     15        (WebCore::AXObjectCache::handleScrolledToAnchor):
     16        (WebCore):
     17
    1182012-04-02  Michael Saboff  <msaboff@apple.com>
    219

  • trunk/Source/WebCore/accessibility/AXObjectCache.cpp

    r112851 r112911  
    5555#include "FocusController.h"
    5656#include "Frame.h"
    57 #include "FrameSelection.h"
    5857#include "HTMLAreaElement.h"
    5958#include "HTMLImageElement.h"
    … …  
    7372#include "RenderView.h"
    7473#include "ScrollView.h"
    75 #include "TextAffinity.h"
    76 #include "htmlediting.h"
     74
    7775#include <wtf/PassRefPtr.h>
    7876
    … …  
    158156    return obj;
    159157}
    160 
    161 #if HAVE(ACCESSIBILITY) && (PLATFORM(MAC) || PLATFORM(GTK))
    162 void AXObjectCache::handleScrolledToAnchor(const Node* node)
    163 {
    164     ASSERT(node);
    165 
    166     Document* document = node->document();
    167     if (!document)
    168         return;
    169 
    170     RefPtr<Node> refNode = const_cast<Node*>(node);
    171     document->setFocusedNode(refNode);
    172 
    173     Frame* frame = document->frame();
    174     if (!frame)
    175         return;
    176 
    177     FrameSelection* selection = frame->selection();
    178     if (!selection)
    179         return;
    180 
    181     Position targetPosition = firstPositionInOrBeforeNode(refNode.get());
    182     selection->moveTo(targetPosition, DOWNSTREAM);
    183 }
    184 #endif
    185158
    186159AccessibilityObject* AXObjectCache::get(Widget* widget)

  • trunk/Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp

    r112851 r112911  
    232232}
    233233
     234void AXObjectCache::handleScrolledToAnchor(const Node*)
     235{
     236}
     237
    234238} // namespace WebCore

  • trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm

    r112851 r112911  
    145145}
    146146
     147void AXObjectCache::handleScrolledToAnchor(const Node*)
     148{
     149}
     150
    147151}
    148152
Note: See TracChangeset for help on using the changeset viewer.