Changeset 113076 in webkit


Ignore:
Timestamp:
Apr 3, 2012 1:14:18 PM (12 years ago)
Author:
robert@webkit.org
Message:

CSS 2.1 failure: at-import-009.htm fails
https://bugs.webkit.org/show_bug.cgi?id=82921

Source/WebCore:

Reviewed by Antti Koivisto.

This fixes at-import-009.htm only, the other tests already passed.

Tests: css2.1/20110323/at-import-001.htm

css2.1/20110323/at-import-002.htm
css2.1/20110323/at-import-003.htm
css2.1/20110323/at-import-004.htm
css2.1/20110323/at-import-005.htm
css2.1/20110323/at-import-006.htm
css2.1/20110323/at-import-007.htm
css2.1/20110323/at-import-009.htm
css2.1/20110323/at-import-010.htm
css2.1/20110323/at-import-011.htm

  • css/CSSGrammar.y: ignore empty '@media;' and '@charset;' declarations

LayoutTests:

Add the at-import-* tests from the CSS 2.1 suite. Skip at-import-008.htm
as it relies on a print media type to work.

Reviewed by Antti Koivisto.

  • css2.1/20110323/at-import-001-expected.html: Added.
  • css2.1/20110323/at-import-001.htm: Added.
  • css2.1/20110323/at-import-002-expected.html: Added.
  • css2.1/20110323/at-import-002.htm: Added.
  • css2.1/20110323/at-import-003-expected.html: Added.
  • css2.1/20110323/at-import-003.htm: Added.
  • css2.1/20110323/at-import-004-expected.html: Added.
  • css2.1/20110323/at-import-004.htm: Added.
  • css2.1/20110323/at-import-005-expected.html: Added.
  • css2.1/20110323/at-import-005.htm: Added.
  • css2.1/20110323/at-import-006-expected.html: Added.
  • css2.1/20110323/at-import-006.htm: Added.
  • css2.1/20110323/at-import-007-expected.html: Added.
  • css2.1/20110323/at-import-007.htm: Added.
  • css2.1/20110323/at-import-009-expected.html: Added.
  • css2.1/20110323/at-import-009.htm: Added.
  • css2.1/20110323/at-import-010-expected.html: Added.
  • css2.1/20110323/at-import-010.htm: Added.
  • css2.1/20110323/at-import-011-expected.html: Added.
  • css2.1/20110323/at-import-011.htm: Added.
  • css2.1/20110323/support/at-import-001.css: Added.
  • css2.1/20110323/support/at-import-002.css: Added.
  • css2.1/20110323/support/at-import-004.css: Added.
  • css2.1/20110323/support/at-import-005.css: Added.
  • css2.1/20110323/support/at-import-006.css: Added.
  • css2.1/20110323/support/at-import-007.css: Added.
  • css2.1/20110323/support/import-green.css: Added.
  • css2.1/20110323/support/import-red.css: Added.
Location:
trunk
Files:
28 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r113073 r113076  
     12012-04-02  Robert Hogan  <robert@webkit.org>
     2
     3        CSS 2.1 failure: at-import-009.htm fails
     4        https://bugs.webkit.org/show_bug.cgi?id=82921
     5
     6        Add the at-import-* tests from the CSS 2.1 suite. Skip at-import-008.htm
     7        as it relies on a print media type to work.
     8
     9        Reviewed by Antti Koivisto.
     10
     11        * css2.1/20110323/at-import-001-expected.html: Added.
     12        * css2.1/20110323/at-import-001.htm: Added.
     13        * css2.1/20110323/at-import-002-expected.html: Added.
     14        * css2.1/20110323/at-import-002.htm: Added.
     15        * css2.1/20110323/at-import-003-expected.html: Added.
     16        * css2.1/20110323/at-import-003.htm: Added.
     17        * css2.1/20110323/at-import-004-expected.html: Added.
     18        * css2.1/20110323/at-import-004.htm: Added.
     19        * css2.1/20110323/at-import-005-expected.html: Added.
     20        * css2.1/20110323/at-import-005.htm: Added.
     21        * css2.1/20110323/at-import-006-expected.html: Added.
     22        * css2.1/20110323/at-import-006.htm: Added.
     23        * css2.1/20110323/at-import-007-expected.html: Added.
     24        * css2.1/20110323/at-import-007.htm: Added.
     25        * css2.1/20110323/at-import-009-expected.html: Added.
     26        * css2.1/20110323/at-import-009.htm: Added.
     27        * css2.1/20110323/at-import-010-expected.html: Added.
     28        * css2.1/20110323/at-import-010.htm: Added.
     29        * css2.1/20110323/at-import-011-expected.html: Added.
     30        * css2.1/20110323/at-import-011.htm: Added.
     31        * css2.1/20110323/support/at-import-001.css: Added.
     32        * css2.1/20110323/support/at-import-002.css: Added.
     33        * css2.1/20110323/support/at-import-004.css: Added.
     34        * css2.1/20110323/support/at-import-005.css: Added.
     35        * css2.1/20110323/support/at-import-006.css: Added.
     36        * css2.1/20110323/support/at-import-007.css: Added.
     37        * css2.1/20110323/support/import-green.css: Added.
     38        * css2.1/20110323/support/import-red.css: Added.
     39
    1402012-04-03  Mike Lattanzio  <mlattanzio@rim.com>
    241
  • trunk/Source/WebCore/ChangeLog

    r113070 r113076  
     12012-04-02  Robert Hogan  <robert@webkit.org>
     2
     3        CSS 2.1 failure: at-import-009.htm fails
     4        https://bugs.webkit.org/show_bug.cgi?id=82921
     5
     6        Reviewed by Antti Koivisto.
     7
     8        This fixes at-import-009.htm only, the other tests already passed.
     9
     10        Tests: css2.1/20110323/at-import-001.htm
     11               css2.1/20110323/at-import-002.htm
     12               css2.1/20110323/at-import-003.htm
     13               css2.1/20110323/at-import-004.htm
     14               css2.1/20110323/at-import-005.htm
     15               css2.1/20110323/at-import-006.htm
     16               css2.1/20110323/at-import-007.htm
     17               css2.1/20110323/at-import-009.htm
     18               css2.1/20110323/at-import-010.htm
     19               css2.1/20110323/at-import-011.htm
     20
     21        * css/CSSGrammar.y: ignore empty '@media;' and '@charset;' declarations
     22
    1232012-04-03  Shawn Singh  <shawnsingh@chromium.org>
    224
  • trunk/Source/WebCore/css/CSSGrammar.y

    r113031 r113076  
    395395        $$ = 0;
    396396    }
     397    | CHARSET_SYM maybe_space ';' {
     398        $$ = 0;
     399    }
    397400;
    398401
     
    602605    | MEDIA_SYM maybe_space '{' maybe_space block_rule_list save_block {
    603606        $$ = static_cast<CSSParser*>(parser)->createMediaRule(0, $5);
     607    }
     608    | MEDIA_SYM maybe_space ';' {
     609        $$ = 0;
    604610    }
    605611    ;
Note: See TracChangeset for help on using the changeset viewer.