Changeset 113275 in webkit


Ignore:
Timestamp:
Apr 4, 2012 7:07:27 PM (12 years ago)
Author:
hayato@chromium.org
Message:

Update a layout test, adding a case for traversing a ShadowRoot which does not have any children.
​https://bugs.webkit.org/show_bug.cgi?id=82593

Reviewed by Dimitri Glazkov.

Prior to r113125, if we traverse a ShadowRoot which does not have any children,
it caused an assertion failure on debug build. r113125 fixed this issue implicitly.
Adds a test case for that to catch a future regression.

  • fast/dom/shadow/focus-navigation-expected.html:
  • fast/dom/shadow/focus-navigation.html:
Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r113270 r113275  
     12012-04-04  Hayato Ito  <hayato@chromium.org>
     2
     3        Update a layout test, adding a case for traversing a ShadowRoot which does not have any children.
     4        https://bugs.webkit.org/show_bug.cgi?id=82593
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        Prior to r113125, if we traverse a ShadowRoot which does not have any children,
     9        it caused an assertion failure on debug build. r113125 fixed this issue implicitly.
     10        Adds a test case for that to catch a future regression.
     11
     12        * fast/dom/shadow/focus-navigation-expected.html:
     13        * fast/dom/shadow/focus-navigation.html:
     14
    1152012-04-04  Oliver Hunt  <oliver@apple.com>
    216

  • trunk/LayoutTests/fast/dom/shadow/focus-navigation-expected.txt

    r112511 r113275  
    4747Should move from input-C-0 to input-D-0 in forward
    4848PASS
    49 Should move from input-D-0 to input-A-1 in forward
     49Should move from input-D-0 to host-D in forward
    5050PASS
    51 Should move from input-A-1 to input-D-0 in backward
     51Should move from host-D to input-E-0 in forward
     52PASS
     53Should move from input-E-0 to input-A-1 in forward
     54PASS
     55Should move from input-A-1 to input-E-0 in backward
     56PASS
     57Should move from input-E-0 to host-D in backward
     58PASS
     59Should move from host-D to input-D-0 in backward
    5260PASS
    5361Should move from input-D-0 to input-C-0 in backward
    … …  
    97105Should move from input-B-1 to input-A-1 in backward
    98106PASS
    99 Should move from input-A-1 to input-D-0 in backward
     107Should move from input-A-1 to input-E-0 in backward
    100108PASS
    101109Test finished.
    … …  
    105113
    106114
     115

  • trunk/LayoutTests/fast/dom/shadow/focus-navigation.html

    r112511 r113275  
    5151                            createShadowRoot(
    5252                                createDOM('input', {'tabindex': -1}))),
    53                   createDOM('input', {'id': 'input-D-0', 'tabindex': 0})));
    54 
     53                  createDOM('input', {'id': 'input-D-0', 'tabindex': 0}),
     54                  createDOM('div', {},
     55                            createDOM('div', {'id': 'host-D', 'tabindex': 0},
     56                                      createShadowRoot())),
     57                  createDOM('input', {'id': 'input-E-0', 'tabindex': 0})));
    5558    parent.offsetLeft;
    5659}
    … …  
    118121        // A non-focusable shadow host (id=host-C), which does not have focusable elements, should be skipped entirely.
    119122        'input-D-0',
     123        'host-D',
     124        'input-E-0',
    120125
    121126        // Wraps to the first element in the outermost focus scope.
    … …  
    126131    elementsNavigatedInBackward = [
    127132        'input-A-1',
     133        'input-E-0',
     134        'host-D',
    128135        'input-D-0',
    129136        'input-C-0',
    … …  
    164171
    165172        // Wraps to the last element in the outermost focus scope.
    166         'input-D-0',
     173        'input-E-0',
    167174    ];
    168175
Note: See TracChangeset for help on using the changeset viewer.