Changeset 113305 in webkit

Timestamp:

Apr 5, 2012 2:25:20 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK][DRT] Fail fast/filesystem/flags-passing.html on JSC
​https://bugs.webkit.org/show_bug.cgi?id=83137

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-04-05
Reviewed by Kentaro Hara.

fast/filesystem/flags-passing.html is failed on webkitgtk+ applied FileSystem API patch
for bug58443. 'testsList' is a global array object, but it's accessed in runNextTest
function object like this, "this[testsList[testCounter++]]();". I'm not familiar
with JavaScript and V8, but in my understanding, it looks a bit strange.
'this' in the statement means runNextTest function object which doesn't have
testList array object. (It's a global scope variable.) This test might be able to
pass on V8 JS engine, but not on JSC at least my try.
'testsList' is changed from a function name array to a function array.

• fast/filesystem/script-tests/flags-passing.js:

(runNextTest):

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/filesystem/script-tests/flags-passing.js (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-04-05  ChangSeok Oh  <shivamidow@gmail.com>
+
+        [GTK][DRT] Fail fast/filesystem/flags-passing.html on JSC
+        https://bugs.webkit.org/show_bug.cgi?id=83137
+
+        Reviewed by Kentaro Hara.
+
+        fast/filesystem/flags-passing.html is failed on webkitgtk+ applied FileSystem API patch
+        for bug58443. 'testsList' is a global array object, but it's accessed in runNextTest
+        function object like this, "this[testsList[testCounter++]]();". I'm not familiar
+        with JavaScript and V8, but in my understanding, it looks a bit strange.
+        'this' in the statement means runNextTest function object which doesn't have
+        testList array object. (It's a global scope variable.) This test might be able to
+        pass on V8 JS engine, but not on JSC at least my try.
+        'testsList' is changed from a function name array to a function array.
+
+        * fast/filesystem/script-tests/flags-passing.js:
+        (runNextTest):
+
 2012-04-05  Philippe Normand  <pnormand@igalia.com>
 

trunk/LayoutTests/fast/filesystem/script-tests/flags-passing.js

@@ -9 +9 @@
 
 var testsList = [
-    'runObjectTest',
-    'cleanupAndRunNext',
-    'runJSONTest',
-    'runJSONTestWithExclusive',
-    'runNullTest',
-    'runNonObjectTest'
+    runObjectTest,
+    cleanupAndRunNext,
+    runJSONTest,
+    runJSONTestWithExclusive,
+    runNullTest,
+    runNonObjectTest
 ];
 var testCounter = 0;
@@ -25 +25 @@
         finishJSTest();
     } else
-        this[testsList[testCounter++]]();
+        (testsList[testCounter++])();
 }