Changeset 113318 in webkit
- Timestamp:
- Apr 5, 2012 6:25:04 AM (12 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r113317 r113318 1 2012-04-05 Peter Rybin <peter.rybin@gmail.com> 2 3 Web Inspector: CodeGeneratorInspector.py: switch FileSystem, Profiler and Worker domains to typed API 4 https://bugs.webkit.org/show_bug.cgi?id=83069 5 6 Reviewed by Yury Semikhatsky. 7 8 Domains are switched to 'strict' mode. However, hardly any changes were needed in C++ code because 9 only basic types are currently used in Inspector.json. 10 11 * inspector/CodeGeneratorInspector.py: 12 * inspector/InspectorProfilerAgent.cpp: 13 (WebCore::InspectorProfilerAgent::getProfileHeaders): 14 (WebCore): 15 (WebCore::InspectorProfilerAgent::getObjectByHeapObjectId): 16 * inspector/InspectorProfilerAgent.h: 17 (InspectorProfilerAgent): 18 1 19 2012-04-05 Levi Weintraub <leviw@chromium.org> 2 20 -
trunk/Source/WebCore/inspector/CodeGeneratorInspector.py
r113213 r113318 63 63 "CSS", "Debugger", "DOM", "Network", "Page", "Runtime", 64 64 "Inspector", "Memory", "Database", 65 "IndexedDB", "DOMStorage", "ApplicationCache"] 65 "IndexedDB", "DOMStorage", "ApplicationCache", 66 "FileSystem", "Profiler", "Worker"] 66 67 67 68 … … 2290 2291 }; 2291 2292 2293 template<> 2294 struct ArrayItemHelper<InspectorObject> { 2295 struct Traits { 2296 static void pushRefPtr(InspectorArray* array, PassRefPtr<InspectorObject> value) 2297 { 2298 array->pushObject(value); 2299 } 2300 }; 2301 }; 2302 2292 2303 template<typename T> 2293 2304 struct ArrayItemHelper<TypeBuilder::Array<T> > { -
trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp
r112996 r113318 241 241 } 242 242 243 void InspectorProfilerAgent::getProfileHeaders(ErrorString*, RefPtr<InspectorArray>& headers) 244 { 243 void InspectorProfilerAgent::getProfileHeaders(ErrorString*, RefPtr<TypeBuilder::Array<InspectorObject> >& headers) 244 { 245 headers = TypeBuilder::Array<InspectorObject>::create(); 246 245 247 ProfilesMap::iterator profilesEnd = m_profiles.end(); 246 248 for (ProfilesMap::iterator it = m_profiles.begin(); it != profilesEnd; ++it) 247 headers-> pushObject(createProfileHeader(*it->second));249 headers->addItem(createProfileHeader(*it->second)); 248 250 HeapSnapshotsMap::iterator snapshotsEnd = m_snapshots.end(); 249 251 for (HeapSnapshotsMap::iterator it = m_snapshots.begin(); it != snapshotsEnd; ++it) 250 headers-> pushObject(createSnapshotHeader(*it->second));252 headers->addItem(createSnapshotHeader(*it->second)); 251 253 } 252 254 … … 427 429 } 428 430 429 void InspectorProfilerAgent::getObjectByHeapObjectId(ErrorString* error, int id, const String* objectGroup, RefPtr< InspectorObject>& result)431 void InspectorProfilerAgent::getObjectByHeapObjectId(ErrorString* error, int id, const String* objectGroup, RefPtr<TypeBuilder::Runtime::RemoteObject>& result) 430 432 { 431 433 ScriptObject heapObject = ScriptProfiler::objectByHeapObjectId(id); -
trunk/Source/WebCore/inspector/InspectorProfilerAgent.h
r109214 r113318 86 86 bool enabled() { return m_enabled; } 87 87 String getCurrentUserInitiatedProfileName(bool incrementProfileNumber = false); 88 virtual void getProfileHeaders(ErrorString*, RefPtr< InspectorArray>& headers);88 virtual void getProfileHeaders(ErrorString*, RefPtr<TypeBuilder::Array<InspectorObject> >& headers); 89 89 virtual void getProfile(ErrorString*, const String& type, int uid, RefPtr<InspectorObject>& profileObject); 90 90 virtual void removeProfile(ErrorString*, const String& type, int uid); … … 97 97 void toggleRecordButton(bool isProfiling); 98 98 99 virtual void getObjectByHeapObjectId(ErrorString*, int id, const String* objectGroup, RefPtr< InspectorObject>& result);99 virtual void getObjectByHeapObjectId(ErrorString*, int id, const String* objectGroup, RefPtr<TypeBuilder::Runtime::RemoteObject>& result); 100 100 101 101 protected:
Note: See TracChangeset
for help on using the changeset viewer.