Changeset 113443 in webkit

Timestamp:

Apr 6, 2012 9:04:51 AM (12 years ago)

Author:

caseq@chromium.org

Message:

Web Inspector: on a single click in Timeline overview, make a minimal selection centered around cursor
​https://bugs.webkit.org/show_bug.cgi?id=82616

Reviewed by Pavel Feldman.

• center minimal selection on mouse cursor if the mouse hasn't moved (i.e. we had a click, not drag)

• inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TimelineOverviewPane.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-04-06  Andrey Kosyakov  <caseq@chromium.org>
+
+        Web Inspector: on a single click in Timeline overview, make a minimal selection centered around cursor
+        https://bugs.webkit.org/show_bug.cgi?id=82616
+
+        Reviewed by Pavel Feldman.
+
+        - center minimal selection on mouse cursor if the mouse hasn't moved (i.e. we had a click, not drag)
+
+        * inspector/front-end/TimelineOverviewPane.js:
+        (WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):
+
 2012-04-06  Vineet Chaudhary  <rgf748@motorola.com>
 

trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js

@@ -488 +488 @@
         var window = this._overviewWindowSelector._close(event.pageX - this._parentElement.offsetLeft);
         delete this._overviewWindowSelector;
-        if (window.end - window.start < WebInspector.TimelineOverviewPane.MinSelectableSize) {
+        if (window.end === window.start) { // Click, not drag.\
+            var middle = window.end;
+            window.start = Math.max(0, middle - WebInspector.TimelineOverviewPane.MinSelectableSize / 2);
+            window.end = Math.min(this._parentElement.clientWidth, middle + WebInspector.TimelineOverviewPane.MinSelectableSize / 2);
+        } else if (window.end - window.start < WebInspector.TimelineOverviewPane.MinSelectableSize) {
             if (this._parentElement.clientWidth - window.end > WebInspector.TimelineOverviewPane.MinSelectableSize)
                 window.end = window.start + WebInspector.TimelineOverviewPane.MinSelectableSize;