Changeset 113484 in webkit

Timestamp:

Apr 6, 2012 12:54:28 PM (12 years ago)

Author:

leviw@chromium.org

Message:

Correct LayoutUnit usgae in RenderThemeQt and RenderThemeQStyle
​https://bugs.webkit.org/show_bug.cgi?id=83376

Reviewed by Eric Seidel.

Source/WebCore:

Correcting LayoutUnit usage in QT RenderTheme code.

No new tests. No change in behavior.

• platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::convertToPaintingRect): Rounding the ancestor offset before
applying it to the pixel snapped partRect.
(WebCore::RenderThemeQt::paintSearchFieldCancelButton): Also rounding the ancestor
offset, and also pixel snapping the content rect before painting.

Source/WebKit/qt:

Calculating the progress animation using the pixel-snapped RenderProgress size instead
of the internal sub-pixel version.

• WebCoreSupport/RenderThemeQStyle.cpp:

(WebCore::RenderThemeQStyle::animationDurationForProgressBar):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/qt/RenderThemeQt.cpp (modified) (2 diffs)
• WebKit/qt/ChangeLog (modified) (1 diff)
• WebKit/qt/WebCoreSupport/RenderThemeQStyle.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-04-06  Levi Weintraub  <leviw@chromium.org>
+
+        Correct LayoutUnit usgae in RenderThemeQt and RenderThemeQStyle
+        https://bugs.webkit.org/show_bug.cgi?id=83376
+
+        Reviewed by Eric Seidel.
+
+        Correcting LayoutUnit usage in QT RenderTheme code.
+
+        No new tests. No change in behavior.
+
+        * platform/qt/RenderThemeQt.cpp:
+        (WebCore::RenderThemeQt::convertToPaintingRect): Rounding the ancestor offset before
+        applying it to the pixel snapped partRect.
+        (WebCore::RenderThemeQt::paintSearchFieldCancelButton): Also rounding the ancestor
+        offset, and also pixel snapping the content rect before painting.
+
 2012-04-06  Kenneth Russell  <kbr@google.com>
 

trunk/Source/WebCore/platform/qt/RenderThemeQt.cpp

@@ -436 +436 @@
 {
     // Compute an offset between the part renderer and the input renderer.
-    IntSize offsetFromInputRenderer = -(partRenderer->offsetFromAncestorContainer(inputRenderer));
+    IntSize offsetFromInputRenderer = -roundedIntSize(partRenderer->offsetFromAncestorContainer(inputRenderer));
     // Move the rect into partRenderer's coords.
     partRect.move(offsetFromInputRenderer);
@@ -455 +455 @@
         return false;
     RenderBox* inputRenderBox = toRenderBox(input->renderer());
-    IntRect inputContentBox = inputRenderBox->contentBoxRect();
+    IntRect inputContentBox = pixelSnappedIntRect(inputRenderBox->contentBoxRect());
 
     // Make sure the scaled button stays square and will fit in its parent's box.

trunk/Source/WebKit/qt/ChangeLog

@@ +1 @@
+2012-04-06  Levi Weintraub  <leviw@chromium.org>
+
+        Correct LayoutUnit usgae in RenderThemeQt and RenderThemeQStyle
+        https://bugs.webkit.org/show_bug.cgi?id=83376
+
+        Reviewed by Eric Seidel.
+
+        Calculating the progress animation using the pixel-snapped RenderProgress size instead
+        of the internal sub-pixel version.
+
+        * WebCoreSupport/RenderThemeQStyle.cpp:
+        (WebCore::RenderThemeQStyle::animationDurationForProgressBar):
+
 2012-04-05  Patrick Gansterer  <paroga@webkit.org>
 

trunk/Source/WebKit/qt/WebCoreSupport/RenderThemeQStyle.cpp

@@ -500 +500 @@
 
     QStyleOptionProgressBarV2 option;
-    option.rect.setSize(renderProgress->size());
+    option.rect.setSize(renderProgress->pixelSnappedSize());
     // FIXME: Until http://bugreports.qt.nokia.com/browse/QTBUG-9171 is fixed,
     // we simulate one square animating across the progress bar.