Changeset 113607 in webkit

Timestamp:

Apr 9, 2012 12:46:56 PM (12 years ago)

Author:

leviw@chromium.org

Message:

Correct some LayoutUnit misuse in FilterEffectRenderer, and RenderBlock
​https://bugs.webkit.org/show_bug.cgi?id=83366

Reviewed by Eric Seidel.

Some more preparation of Render classes for FractionalLayoutUnits. See below for details
of each change.

No new tests. No change in behavior.

• rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRendererHelper::applyFilterEffect): Pixel snapping image rect before
drawing it.

• rendering/RenderBlock.cpp:

(WebCore::::string): Pixel snapping outputted values for debug.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/FilterEffectRenderer.cpp (modified) (1 diff)
• rendering/RenderBlock.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-04-09  Levi Weintraub  <leviw@chromium.org>
+
+        Correct some LayoutUnit misuse in FilterEffectRenderer, and RenderBlock
+        https://bugs.webkit.org/show_bug.cgi?id=83366
+
+        Reviewed by Eric Seidel.
+
+        Some more preparation of Render classes for FractionalLayoutUnits. See below for details
+        of each change.
+
+        No new tests. No change in behavior.
+
+        * rendering/FilterEffectRenderer.cpp:
+        (WebCore::FilterEffectRendererHelper::applyFilterEffect): Pixel snapping image rect before
+        drawing it.
+        * rendering/RenderBlock.cpp:
+        (WebCore::::string): Pixel snapping outputted values for debug.
+
 2012-04-09  Shawn Singh  <shawnsingh@chromium.org>
 

trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp

@@ -404 +404 @@
     destRect.move(m_paintOffset.x(), m_paintOffset.y());
     
-    m_savedGraphicsContext->drawImageBuffer(filter->output(), m_renderLayer->renderer()->style()->colorSpace(), destRect, CompositeSourceOver);
+    m_savedGraphicsContext->drawImageBuffer(filter->output(), m_renderLayer->renderer()->style()->colorSpace(), pixelSnappedIntRect(destRect), CompositeSourceOver);
     
     return m_savedGraphicsContext;

trunk/Source/WebCore/rendering/RenderBlock.cpp

@@ -7370 +7370 @@
 String ValueToString<RenderBlock::FloatingObject*>::string(const RenderBlock::FloatingObject* floatingObject)
 {
-    return String::format("%p (%dx%d %dx%d)", floatingObject, floatingObject->x(), floatingObject->y(), floatingObject->maxX(), floatingObject->maxY());
+    return String::format("%p (%dx%d %dx%d)", floatingObject, floatingObject->pixelSnappedX(), floatingObject->pixelSnappedY(), floatingObject->pixelSnappedMaxX(), floatingObject->pixelSnappedMaxY());
 }