Changeset 113714 in webkit


Ignore:
Timestamp:
Apr 10, 2012 8:14:55 AM (12 years ago)
Author:
jesus@webkit.org
Message:

[Qt][WK2] Implement PageClient::isViewWindowActive()
https://bugs.webkit.org/show_bug.cgi?id=81143

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

This patch implements PageClient::isViewWindowActive()
now that QQuickCanvas::isActive() is available (from QWindow).

  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::isViewWindowActive):

Tools:

Fix the WrapperWindow from our PlatformWebView
so it correctly creates the platform related
stuff for QWindow, which is not created unless
QWindow::setVisible() or QWindow::show() are called.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r113697 r113714  
     12012-04-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
     2
     3        [Qt][WK2] Implement PageClient::isViewWindowActive()
     4        https://bugs.webkit.org/show_bug.cgi?id=81143
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        This patch implements PageClient::isViewWindowActive()
     9        now that QQuickCanvas::isActive() is available (from QWindow).
     10
     11        * UIProcess/qt/QtPageClient.cpp:
     12        (QtPageClient::isViewWindowActive):
     13
    1142012-04-10  Philippe Normand <pnormand@igalia.com> and Carlos Garcia Campos  <cgarcia@igalia.com>
    215
  • trunk/Source/WebKit2/UIProcess/qt/QtPageClient.cpp

    r113183 r113714  
    257257bool QtPageClient::isViewWindowActive()
    258258{
    259     // FIXME: The scene graph does not have the concept of being active or not when this was written.
    260     return true;
     259    if (!m_webView || !m_webView->canvas())
     260        return false;
     261    return m_webView->canvas()->isActive();
    261262}
    262263
  • trunk/Tools/ChangeLog

    r113703 r113714  
     12012-03-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
     2
     3        [Qt][WK2] Implement PageClient::isViewWindowActive()
     4        https://bugs.webkit.org/show_bug.cgi?id=81143
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Fix the WrapperWindow from our PlatformWebView
     9        so it correctly creates the platform related
     10        stuff for QWindow, which is not created unless
     11        QWindow::setVisible() or QWindow::show() are called.
     12
     13        * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
     14        (WTR::PlatformWebView::PlatformWebView):
     15
    1162012-04-10  Balazs Kelemen  <kbalazs@webkit.org>
    217
  • trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp

    r113330 r113714  
    7777    QQuickWebViewExperimental experimental(m_view);
    7878    experimental.setRenderToOffscreenBuffer(true);
     79
     80    // QWindow delays creating of the underlying platform specific bits until ::setVisible()
     81    // or ::show() are called. This makes ::isActive() always return false. In order to force
     82    // the creation ::create() exists, so we use it here.
     83    m_window->create();
    7984}
    8085
Note: See TracChangeset for help on using the changeset viewer.