Changeset 113724 in webkit

Timestamp:

Apr 10, 2012 9:22:23 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL][DRT] Catch the "title,changed" signal
​https://bugs.webkit.org/show_bug.cgi?id=82174

Patch by Christophe Dumez <Christophe Dumez> on 2012-04-10
Reviewed by Gustavo Noronha Silva.

Tools:

EFL's DumpRenderTree now catches the "title,changed" signal, and
prints out the needed information.

• DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onTitleChanged):

LayoutTests:

Unskip tests which requires EFL's DumpRenderTree to catch the
"title,changed" signal and print out information, now that it
is implemented.

• platform/efl/Skipped:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/efl/Skipped (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL][DRT] Catch the "title,changed" signal
+        https://bugs.webkit.org/show_bug.cgi?id=82174
+
+        Reviewed by Gustavo Noronha Silva.
+
+        Unskip tests which requires EFL's DumpRenderTree to catch the 
+        "title,changed" signal and print out information, now that it
+        is implemented.
+
+        * platform/efl/Skipped:
+
 2012-04-10  Yi Shen  <yi.4.shen@nokia.com>
 

trunk/LayoutTests/platform/efl/Skipped

@@ -780 +780 @@
 fast/forms/mailto/post-text-plain-with-accept-charset.html
 fast/forms/mailto/post-text-plain.html
-
-# EFL's DRT (DumpRenderTreeChrome) needs to catch the "title,changed" signal
-fast/dom/title-text-property.html
-fast/dom/title-text-property-2.html
 
 # Need to call Settings::setValidationMessageTimerMagnification(-1) in DRT.

trunk/Tools/ChangeLog

@@ +1 @@
+2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL][DRT] Catch the "title,changed" signal
+        https://bugs.webkit.org/show_bug.cgi?id=82174
+
+        Reviewed by Gustavo Noronha Silva.
+
+        EFL's DumpRenderTree now catches the "title,changed" signal, and
+        prints out the needed information.
+
+        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+        (DumpRenderTreeChrome::onTitleChanged):
+
 2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
 

trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp

@@ -271 +271 @@
 }
 
-void DumpRenderTreeChrome::onTitleChanged(void*, Evas_Object*, void*)
-{
-    notImplemented();
+void DumpRenderTreeChrome::onTitleChanged(void*, Evas_Object*, void* eventInfo)
+{
+    if (!gLayoutTestController->dumpTitleChanges())
+        return;
+
+    const char* titleText = static_cast<const char*>(eventInfo);
+    printf("TITLE CHANGED: %s\n", titleText);
 }