Changeset 113795 in webkit
- Timestamp:
- Apr 10, 2012 5:17:42 PM (12 years ago)
- Location:
- trunk
- Files:
-
- 14 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r113790 r113795 1 2012-04-10 Adam Barth <abarth@webkit.org> 2 3 Limit -apple- and -khtml- to ENABLE(LEGACY_CSS_VENDOR_PREFIXES) 4 https://bugs.webkit.org/show_bug.cgi?id=83256 5 6 Reviewed by Eric Seidel. 7 8 Skip these two tests, which are testing that -apple- and -khtml- vendor 9 prefixes work correctly. 10 11 * platform/chromium/test_expectations.txt: 12 * platform/efl/Skipped: 13 * platform/gtk/Skipped: 14 * platform/qt/Skipped: 15 1 16 2012-04-10 James Simonsen <simonjam@chromium.org> 2 17 -
trunk/LayoutTests/platform/chromium/test_expectations.txt
r113790 r113795 161 161 WONTFIX MAC WIN : platform/chromium-linux = FAIL 162 162 WONTFIX SKIP LINUX MAC : platform/win = FAIL CRASH PASS 163 164 // These tests are for -apple- and -khtml- prefixes, which we don't support 165 WONTFIX SKIP : inspector/styles/vendor-prefixes.html = TIMEOUT 166 WONTFIX SKIP : fast/css/apple-prefix.html = FAIL 163 167 164 168 // Perf tests are really slow in debug builds and there are few benefits in -
trunk/LayoutTests/platform/efl/Skipped
r113779 r113795 2475 2475 fast/events/page-visibility-transition-test.html 2476 2476 2477 # These test -apple- and -khtml- prefixed CSS properties, which we don't support. 2478 inspector/styles/vendor-prefixes.html 2479 fast/css/apple-prefix.html 2480 2477 2481 # Touch adjustment not enabled 2478 2482 # https://bugs.webkit.org/show_bug.cgi?id=78801 -
trunk/LayoutTests/platform/gtk/Skipped
r113736 r113795 1549 1549 http/tests/security/cross-frame-access-object-getPrototypeOf.html 1550 1550 1551 # These test -apple- and -khtml- prefixed CSS properties, which we don't support. 1552 inspector/styles/vendor-prefixes.html 1553 fast/css/apple-prefix.html 1554 1551 1555 # Let MemoryCache reuse cached XHRs (REGRESSION caused by r107672) 1552 1556 # https://bugs.webkit.org/show_bug.cgi?id=76564 -
trunk/LayoutTests/platform/qt/Skipped
r113756 r113795 2386 2386 fast/loader/reload-zero-byte-plugin.html 2387 2387 2388 # These test -apple- and -khtml- prefixed CSS properties, which we don't support. 2389 inspector/styles/vendor-prefixes.html 2390 fast/css/apple-prefix.html 2391 2388 2392 # Failing after http://trac.webkit.org/changeset/92375 2389 2393 # https://bugs.webkit.org/show_bug.cgi?id=65721 -
trunk/Source/WebCore/ChangeLog
r113792 r113795 1 2012-04-10 Adam Barth <abarth@webkit.org> 2 3 Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT) 4 https://bugs.webkit.org/show_bug.cgi?id=83256 5 6 Reviewed by Eric Seidel. 7 8 As recommended by David Hyatt in 9 <https://lists.webkit.org/pipermail/webkit-dev/2010-July/013536.html>, 10 we should phase out support for -khtml- and -apple- vendor prefixes in 11 CSS (in favor of -webkit-). 12 13 As noted in <https://bugs.webkit.org/show_bug.cgi?id=42093#c29>, Dave's 14 proposal is a bit too agressive. These prefixes appear to be needed 15 for a number of dashboard widgets. For that reason, this patch limits 16 the prefixes to ENABLE(LEGACY_CSS_VENDOR_PREFIXES). 17 18 This patch enables ENABLE(LEGACY_CSS_VENDOR_PREFIXES) on apple-mac and 19 apple-win, which will let us learn whether removing these prefixes 20 causes a compatibility problem on the broader web. 21 22 * Configurations/FeatureDefines.xcconfig: 23 * bindings/js/JSCSSStyleDeclarationCustom.cpp: 24 (WebCore::getCSSPropertyNamePrefix): 25 (WebCore::cssPropertyIDForJSCSSPropertyName): 26 * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: 27 (WebCore::cssPropertyInfo): 28 * css/CSSParser.cpp: 29 (WebCore::cssPropertyID): 30 1 31 2012-04-10 Levi Weintraub <leviw@chromium.org> 2 32 -
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
r113467 r113795 85 85 ENABLE_INPUT_SPEECH = ; 86 86 ENABLE_JAVASCRIPT_DEBUGGER = ENABLE_JAVASCRIPT_DEBUGGER; 87 ENABLE_LEGACY_CSS_VENDOR_PREFIXES = ENABLE_LEGACY_CSS_VENDOR_PREFIXES; 87 88 ENABLE_LEGACY_NOTIFICATIONS = ENABLE_LEGACY_NOTIFICATIONS; 88 89 ENABLE_LINK_PREFETCH = ; … … 127 128 ENABLE_XSLT = ENABLE_XSLT; 128 129 129 FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CSS_FILTERS) $(ENABLE_CSS_GRID_LAYOUT) $(ENABLE_CSS_SHADERS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_FILE_SYSTEM) $(ENABLE_FILTERS) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_HIGH_DPI_CANVAS) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_SPEECH) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_LEGACY_ NOTIFICATIONS) $(ENABLE_LINK_PREFETCH) $(ENABLE_MATHML) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_METER_TAG) $(ENABLE_MICRODATA) $(ENABLE_MUTATION_OBSERVERS) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_QUOTA) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_REQUEST_ANIMATION_FRAME) $(ENABLE_SCRIPTED_SPEECH) $(ENABLE_SHADOW_DOM) $(ENABLE_SHARED_WORKERS) $(ENABLE_SQL_DATABASE) $(ENABLE_STYLE_SCOPED) $(ENABLE_SVG) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_TEXT_NOTIFICATIONS_ONLY) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_WEBGL) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XSLT);130 FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CSS_FILTERS) $(ENABLE_CSS_GRID_LAYOUT) $(ENABLE_CSS_SHADERS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_FILE_SYSTEM) $(ENABLE_FILTERS) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_HIGH_DPI_CANVAS) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_SPEECH) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_NOTIFICATIONS) $(ENABLE_LINK_PREFETCH) $(ENABLE_MATHML) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_METER_TAG) $(ENABLE_MICRODATA) $(ENABLE_MUTATION_OBSERVERS) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_QUOTA) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_REQUEST_ANIMATION_FRAME) $(ENABLE_SCRIPTED_SPEECH) $(ENABLE_SHADOW_DOM) $(ENABLE_SHARED_WORKERS) $(ENABLE_SQL_DATABASE) $(ENABLE_STYLE_SCOPED) $(ENABLE_SVG) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_TEXT_NOTIFICATIONS_ONLY) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_WEBGL) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XSLT); -
trunk/Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp
r113387 r113795 71 71 PropertyNamePrefixPixel, 72 72 PropertyNamePrefixPos, 73 #if ENABLE(LEGACY_CSS_VENDOR_PREFIXES) 73 74 PropertyNamePrefixApple, 75 #endif 74 76 PropertyNamePrefixEpub, 77 #if ENABLE(LEGACY_CSS_VENDOR_PREFIXES) 75 78 PropertyNamePrefixKHTML, 79 #endif 76 80 PropertyNamePrefixWebKit 77 81 }; … … 114 118 UChar firstChar = toASCIILower(propertyName[0]); 115 119 switch (firstChar) { 120 #if ENABLE(LEGACY_CSS_VENDOR_PREFIXES) 116 121 case 'a': 117 122 if (matchesCSSPropertyNamePrefix(propertyName, "apple")) 118 123 return PropertyNamePrefixApple; 119 124 break; 125 #endif 120 126 case 'c': 121 127 if (matchesCSSPropertyNamePrefix(propertyName, "css")) 122 128 return PropertyNamePrefixCSS; 123 129 break; 130 #if ENABLE(LEGACY_CSS_VENDOR_PREFIXES) 124 131 case 'k': 125 132 if (matchesCSSPropertyNamePrefix(propertyName, "khtml")) 126 133 return PropertyNamePrefixKHTML; 127 134 break; 135 #endif 128 136 case 'e': 129 137 if (matchesCSSPropertyNamePrefix(propertyName, "epub")) … … 210 218 hadPixelOrPosPrefix = true; 211 219 break; 220 #if ENABLE(LEGACY_CSS_VENDOR_PREFIXES) 212 221 case PropertyNamePrefixApple: 213 222 case PropertyNamePrefixKHTML: … … 215 224 i += 5; 216 225 break; 226 #endif 217 227 case PropertyNamePrefixEpub: 218 228 writeEpubPrefix(bufferPtr); -
trunk/Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp
r113042 r113795 127 127 hadPixelOrPosPrefix = true; 128 128 } else if (hasCSSPropertyNamePrefix(propertyName, "webkit") 129 #if ENABLE(LEGACY_CSS_VENDOR_PREFIXES) 129 130 || hasCSSPropertyNamePrefix(propertyName, "khtml") 130 || hasCSSPropertyNamePrefix(propertyName, "apple")) 131 || hasCSSPropertyNamePrefix(propertyName, "apple") 132 #endif 133 ) 131 134 builder.append('-'); 132 135 else if (isASCIIUpper(propertyName[0])) -
trunk/Source/WebCore/css/CSSParser.cpp
r113647 r113795 9352 9352 const char* name = buffer; 9353 9353 if (buffer[0] == '-') { 9354 #if ENABLE(LEGACY_CSS_VENDOR_PREFIXES) 9354 9355 // If the prefix is -apple- or -khtml-, change it to -webkit-. 9355 9356 // This makes the string one character longer. … … 9359 9360 ++length; 9360 9361 } 9362 #endif 9361 9363 #if PLATFORM(IOS) 9362 9364 cssPropertyNameIOSAliasing(buffer, name, length); -
trunk/Source/WebKit/chromium/ChangeLog
r113782 r113795 1 2012-04-10 Adam Barth <abarth@webkit.org> 2 3 Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT) 4 https://bugs.webkit.org/show_bug.cgi?id=83256 5 6 Reviewed by Eric Seidel. 7 8 * features.gypi: 9 1 10 2012-04-10 Tim Dresser <tdresser@chromium.org> 2 11 -
trunk/Source/WebKit/chromium/features.gypi
r113755 r113795 63 63 'ENABLE_JAVASCRIPT_DEBUGGER=1', 64 64 'ENABLE_JAVASCRIPT_I18N_API=1', 65 'ENABLE_LEGACY_CSS_VENDOR_PREFIXES=0', 65 66 'ENABLE_LEGACY_NOTIFICATIONS=1', 66 67 'ENABLE_LINK_PREFETCH=1', -
trunk/WebKitLibraries/ChangeLog
r113649 r113795 1 2012-04-10 Adam Barth <abarth@webkit.org> 2 3 Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT) 4 https://bugs.webkit.org/show_bug.cgi?id=83256 5 6 Reviewed by Eric Seidel. 7 8 * win/tools/vsprops/FeatureDefines.vsprops: 9 1 10 2012-04-09 Beth Dakin <bdakin@apple.com> 2 11 -
trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops
r113467 r113795 10 10 <Tool 11 11 Name="VCCLCompilerTool" 12 PreprocessorDefinitions="$(ENABLE_REQUEST_ANIMATION_FRAME);$(ENABLE_3D_CANVAS);$(ENABLE_3D_RENDERING);$(ENABLE_ACCELERATED_2D_CANVAS);$(ENABLE_BLOB);$(ENABLE_CHANNEL_MESSAGING);$(ENABLE_CSS_FILTERS);$(ENABLE_CSS_GRID_LAYOUT);$(ENABLE_CSS_SHADERS);$(ENABLE_CSS_REGIONS);$(ENABLE_CSS_EXCLUSIONS);$(ENABLE_SQL_DATABASE);$(ENABLE_DATAGRID);$(ENABLE_DATALIST);$(ENABLE_DATA_TRANSFER_ITEMS);$(ENABLE_DETAILS);$(ENABLE_DEVICE_ORIENTATION);$(ENABLE_DIRECTORY_UPLOAD);$(ENABLE_FILTERS);$(ENABLE_FILE_SYSTEM);$(ENABLE_FULLSCREEN_API);$(ENABLE_GAMEPAD);$(ENABLE_GEOLOCATION);$(ENABLE_HIGH_DPI_CANVAS);$(ENABLE_ICONDATABASE);$(ENABLE_INDEXED_DATABASE);$(ENABLE_INPUT_TYPE_COLOR);$(ENABLE_INPUT_SPEECH);$(ENABLE_INPUT_TYPE_DATE);$(ENABLE_INPUT_TYPE_DATETIME);$(ENABLE_INPUT_TYPE_DATETIMELOCAL);$(ENABLE_INPUT_TYPE_MONTH);$(ENABLE_INPUT_TYPE_TIME);$(ENABLE_INPUT_TYPE_WEEK);$(ENABLE_JAVASCRIPT_DEBUGGER);$(ENABLE_LEGACY_ NOTIFICATIONS);$(ENABLE_LINK_PREFETCH);$(ENABLE_MATHML);$(ENABLE_METER_TAG);$(ENABLE_MICRODATA);$(ENABLE_MUTATION_OBSERVERS);$(ENABLE_NOTIFICATIONS);$(ENABLE_PAGE_VISIBILITY_API);$(ENABLE_PROGRESS_TAG);$(ENABLE_QUOTA);$(ENABLE_REGISTER_PROTOCOL_HANDLER);$(ENABLE_SCRIPTED_SPEECH);$(ENABLE_SHADOW_DOM);$(ENABLE_SHARED_WORKERS);$(ENABLE_STYLE_SCOPED);$(ENABLE_SVG);$(ENABLE_SVG_DOM_OBJC_BINDINGS);$(ENABLE_SVG_FONTS);$(ENABLE_VIDEO);$(ENABLE_MEDIA_SOURCE);$(ENABLE_MEDIA_STATISTICS);$(ENABLE_WEB_SOCKETS);$(ENABLE_WEB_TIMING);$(ENABLE_WORKERS);$(ENABLE_XSLT)"12 PreprocessorDefinitions="$(ENABLE_REQUEST_ANIMATION_FRAME);$(ENABLE_3D_CANVAS);$(ENABLE_3D_RENDERING);$(ENABLE_ACCELERATED_2D_CANVAS);$(ENABLE_BLOB);$(ENABLE_CHANNEL_MESSAGING);$(ENABLE_CSS_FILTERS);$(ENABLE_CSS_GRID_LAYOUT);$(ENABLE_CSS_SHADERS);$(ENABLE_CSS_REGIONS);$(ENABLE_CSS_EXCLUSIONS);$(ENABLE_SQL_DATABASE);$(ENABLE_DATAGRID);$(ENABLE_DATALIST);$(ENABLE_DATA_TRANSFER_ITEMS);$(ENABLE_DETAILS);$(ENABLE_DEVICE_ORIENTATION);$(ENABLE_DIRECTORY_UPLOAD);$(ENABLE_FILTERS);$(ENABLE_FILE_SYSTEM);$(ENABLE_FULLSCREEN_API);$(ENABLE_GAMEPAD);$(ENABLE_GEOLOCATION);$(ENABLE_HIGH_DPI_CANVAS);$(ENABLE_ICONDATABASE);$(ENABLE_INDEXED_DATABASE);$(ENABLE_INPUT_TYPE_COLOR);$(ENABLE_INPUT_SPEECH);$(ENABLE_INPUT_TYPE_DATE);$(ENABLE_INPUT_TYPE_DATETIME);$(ENABLE_INPUT_TYPE_DATETIMELOCAL);$(ENABLE_INPUT_TYPE_MONTH);$(ENABLE_INPUT_TYPE_TIME);$(ENABLE_INPUT_TYPE_WEEK);$(ENABLE_JAVASCRIPT_DEBUGGER);$(ENABLE_LEGACY_CSS_VENDOR_PREFIXES);$(ENABLE_LEGACY_NOTIFICATIONS);$(ENABLE_LINK_PREFETCH);$(ENABLE_MATHML);$(ENABLE_METER_TAG);$(ENABLE_MICRODATA);$(ENABLE_MUTATION_OBSERVERS);$(ENABLE_NOTIFICATIONS);$(ENABLE_PAGE_VISIBILITY_API);$(ENABLE_PROGRESS_TAG);$(ENABLE_QUOTA);$(ENABLE_REGISTER_PROTOCOL_HANDLER);$(ENABLE_SCRIPTED_SPEECH);$(ENABLE_SHADOW_DOM);$(ENABLE_SHARED_WORKERS);$(ENABLE_STYLE_SCOPED);$(ENABLE_SVG);$(ENABLE_SVG_DOM_OBJC_BINDINGS);$(ENABLE_SVG_FONTS);$(ENABLE_VIDEO);$(ENABLE_MEDIA_SOURCE);$(ENABLE_MEDIA_STATISTICS);$(ENABLE_WEB_SOCKETS);$(ENABLE_WEB_TIMING);$(ENABLE_WORKERS);$(ENABLE_XSLT)" 13 13 /> 14 14 <UserMacro … … 187 187 PerformEnvironmentSet="true" 188 188 /> 189 <UserMacro 190 Name="ENABLE_LEGACY_NOTIFICATIONS" 191 Value="" 192 PerformEnvironmentSet="true" 193 /> 189 <UserMacro 190 Name="ENABLE_LEGACY_CSS_VENDOR_PREFIXES" 191 Value="ENABLE_LEGACY_CSS_VENDOR_PREFIXES" 192 PerformEnvironmentSet="true" 193 /> 194 <UserMacro 195 Name="ENABLE_LEGACY_NOTIFICATIONS" 196 Value="" 197 PerformEnvironmentSet="true" 198 /> 194 199 <UserMacro 195 200 Name="ENABLE_LINK_PREFETCH"
Note: See TracChangeset
for help on using the changeset viewer.