Changeset 113836 in webkit
- Timestamp:
- Apr 11, 2012 1:49:18 AM (12 years ago)
- Location:
- trunk
- Files:
-
- 12 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/win/ChangeLog
r112720 r113836 1 2012-04-11 Vivek Galatage <vivekgalatage@gmail.com> 2 3 Web Inspector: Disabling Inspector causes build failure on Windows 4 https://bugs.webkit.org/show_bug.cgi?id=83557 5 6 Reviewed by Pavel Feldman. 7 8 The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard. 9 This change brings all such API calls under the guard. 10 11 * WebCoreSupport/WebInspectorClient.cpp: 12 * WebInspector.cpp: 13 * WebNodeHighlight.cpp: 14 (WebNodeHighlight::WebNodeHighlight): 15 (WebNodeHighlight::update): 16 * WebNodeHighlight.h: 17 (WebNodeHighlight): 18 * WebView.cpp: 19 (WebView::WebView): 20 (WebView::close): 21 (WebView::initWithFrame): 22 (WebView::inspector): 23 * WebView.h: 24 (WebView): 25 1 26 2012-03-30 Mark Pilgrim <pilgrim@chromium.org> 2 27 -
trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp
r103314 r113836 30 30 #include "WebInspectorClient.h" 31 31 32 #if ENABLE(INSPECTOR) 33 32 34 #include "WebInspectorDelegate.h" 33 35 #include "WebKit.h" … … 547 549 return ::RegisterClassEx(&wcex); 548 550 } 551 552 #endif // ENABLE(INSPECTOR) -
trunk/Source/WebKit/win/WebInspector.cpp
r100904 r113836 30 30 #include "WebInspector.h" 31 31 32 #if ENABLE(INSPECTOR) 33 32 34 #include "WebInspectorClient.h" 33 35 #include "WebKitDLL.h" … … 277 279 return S_OK; 278 280 } 281 282 #endif // ENABLE(INSPECTOR) -
trunk/Source/WebKit/win/WebNodeHighlight.cpp
r105667 r113836 48 48 49 49 WebNodeHighlight::WebNodeHighlight(WebView* webView) 50 : m_inspectedWebView(webView) 51 , m_overlay(0) 50 : 51 #if ENABLE(INSPECTOR) 52 m_inspectedWebView(webView), 53 #endif // ENABLE(INSPECTOR) 54 m_overlay(0) 52 55 , m_observedWindow(0) 53 56 , m_showsWhileWebViewIsVisible(false) 54 57 { 58 #if ENABLE(INSPECTOR) 55 59 m_inspectedWebView->viewWindow(reinterpret_cast<OLE_HANDLE*>(&m_inspectedWebViewWindow)); 60 #endif // ENABLE(INSPECTOR) 56 61 } 57 62 … … 159 164 160 165 GraphicsContext context(hdc); 161 166 #if ENABLE(INSPECTOR) 162 167 m_inspectedWebView->page()->inspectorController()->drawHighlight(context); 168 #endif // ENABLE(INSPECTOR) 163 169 164 170 BLENDFUNCTION bf; -
trunk/Source/WebKit/win/WebNodeHighlight.h
r82294 r113836 60 60 void onRootWindowPosChanged(WINDOWPOS*); 61 61 62 #if ENABLE(INSPECTOR) 62 63 WebView* m_inspectedWebView; 64 #endif // ENABLE(INSPECTOR) 63 65 HWND m_inspectedWebViewWindow; 64 66 HWND m_overlay; -
trunk/Source/WebKit/win/WebView.cpp
r112720 r113836 338 338 , m_mainFrame(0) 339 339 , m_page(0) 340 #if ENABLE(INSPECTOR) 340 341 , m_inspectorClient(0) 342 #endif // ENABLE(INSPECTOR) 341 343 , m_hasCustomDropTarget(false) 342 344 , m_useBackForwardList(true) … … 711 713 setFormDelegate(0); 712 714 715 #if ENABLE(INSPECTOR) 713 716 m_inspectorClient = 0; 714 717 if (m_webInspector) 715 718 m_webInspector->webViewClosed(); 719 #endif // ENABLE(INSPECTOR) 716 720 717 721 delete m_page; … … 2659 2663 Settings::setShouldUseHighResolutionTimers(useHighResolutionTimer); 2660 2664 2665 #if ENABLE(INSPECTOR) 2661 2666 m_inspectorClient = new WebInspectorClient(this); 2667 #endif // ENABLE(INSPECTOR) 2662 2668 2663 2669 Page::PageClients pageClients; … … 2666 2672 pageClients.editorClient = new WebEditorClient(this); 2667 2673 pageClients.dragClient = new WebDragClient(this); 2674 #if ENABLE(INSPECTOR) 2668 2675 pageClients.inspectorClient = m_inspectorClient; 2676 #endif // ENABLE(INSPECTOR) 2677 2669 2678 m_page = new Page(pageClients); 2670 2679 provideGeolocationTo(m_page, new WebGeolocationClient(this)); … … 5772 5781 HRESULT STDMETHODCALLTYPE WebView::inspector(IWebInspector** inspector) 5773 5782 { 5783 #if ENABLE(INSPECTOR) 5774 5784 if (!m_webInspector) 5775 5785 m_webInspector.adoptRef(WebInspector::createInstance(this, m_inspectorClient)); 5776 5786 5777 5787 return m_webInspector.copyRefTo(inspector); 5778 } 5788 #else // !ENABLE(INSPECTOR) 5789 return S_OK; 5790 #endif // ENABLE(INSPECTOR) 5791 } 5792 5779 5793 5780 5794 HRESULT STDMETHODCALLTYPE WebView::windowAncestryDidChange() -
trunk/Source/WebKit/win/WebView.h
r107603 r113836 705 705 virtual HRESULT STDMETHODCALLTYPE loadBackForwardListFromOtherView( 706 706 /* [in] */ IWebView *otherView); 707 707 708 708 virtual HRESULT STDMETHODCALLTYPE inspector( 709 709 /* [retval][out] */ IWebInspector**); … … 1048 1048 WebFrame* m_mainFrame; 1049 1049 WebCore::Page* m_page; 1050 #if ENABLE(INSPECTOR) 1050 1051 WebInspectorClient* m_inspectorClient; 1052 #endif // ENABLE(INSPECTOR) 1051 1053 1052 1054 RefPtr<RefCountedHBITMAP> m_backingStoreBitmap; … … 1065 1067 COMPtr<IWebHistoryDelegate> m_historyDelegate; 1066 1068 COMPtr<WebPreferences> m_preferences; 1069 #if ENABLE(INSPECTOR) 1067 1070 COMPtr<WebInspector> m_webInspector; 1071 #endif // ENABLE(INSPECTOR) 1068 1072 COMPtr<IWebGeolocationProvider> m_geolocationProvider; 1069 1073 -
trunk/Tools/ChangeLog
r113829 r113836 1 2012-04-11 Vivek Galatage <vivekgalatage@gmail.com> 2 3 Web Inspector: Disabling Inspector causes build failure on Windows 4 https://bugs.webkit.org/show_bug.cgi?id=83557 5 6 Reviewed by Pavel Feldman. 7 8 The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard. 9 This change brings all such API calls under the guard. 10 11 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 12 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 13 (WTR): 14 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 15 (LayoutTestController): 16 * WebKitTestRunner/TestInvocation.cpp: 17 (WTR::TestInvocation::invoke): 18 1 19 2012-04-10 Kent Tamura <tkent@chromium.org> 2 20 -
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl
r113235 r113836 115 115 [PassContext] void evaluateScriptInIsolatedWorld(in unsigned long worldID, in DOMString script); 116 116 117 #if ENABLE_INSPECTOR 117 118 // For Web Inspector tests 118 119 void showWebInspector(); 119 120 void closeWebInspector(); 120 121 void evaluateInWebInspector(in long callID, in DOMString script); 122 #endif 121 123 122 124 void setPOSIXLocale(in DOMString locale); -
trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp
r113235 r113836 459 459 } 460 460 461 #if ENABLE(INSPECTOR) 461 462 void LayoutTestController::showWebInspector() 462 463 { 463 464 WKBundleInspectorShow(WKBundlePageGetInspector(InjectedBundle::shared().page()->page())); 464 465 } 465 466 #endif // ENABLE(INSPECTOR) 467 468 #if ENABLE(INSPECTOR) 466 469 void LayoutTestController::closeWebInspector() 467 470 { 468 471 WKBundleInspectorClose(WKBundlePageGetInspector(InjectedBundle::shared().page()->page())); 469 472 } 470 473 #endif // ENABLE(INSPECTOR) 474 475 #if ENABLE(INSPECTOR) 471 476 void LayoutTestController::evaluateInWebInspector(long callID, JSStringRef script) 472 477 { … … 474 479 WKBundleInspectorEvaluateScriptForTest(WKBundlePageGetInspector(InjectedBundle::shared().page()->page()), callID, scriptWK.get()); 475 480 } 476 481 #endif // ENABLE(INSPECTOR) 482 483 #if ENABLE(INSPECTOR) 477 484 void LayoutTestController::setJavaScriptProfilingEnabled(bool enabled) 478 485 { 479 486 WKBundleInspectorSetJavaScriptProfilingEnabled(WKBundlePageGetInspector(InjectedBundle::shared().page()->page()), enabled); 480 487 } 488 #endif // ENABLE(INSPECTOR) 481 489 482 490 typedef WTF::HashMap<unsigned, WKRetainPtr<WKBundleScriptWorldRef> > WorldMap; -
trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h
r113235 r113836 166 166 static unsigned worldIDForWorld(WKBundleScriptWorldRef); 167 167 168 #if ENABLE(INSPECTOR) 168 169 void showWebInspector(); 169 170 void closeWebInspector(); 170 171 void evaluateInWebInspector(long callId, JSStringRef script); 171 172 void setJavaScriptProfilingEnabled(bool); 173 #endif // ENABLE(INSPECTOR) 172 174 173 175 void setPOSIXLocale(JSStringRef); -
trunk/Tools/WebKitTestRunner/TestInvocation.cpp
r111097 r113836 164 164 } 165 165 166 #if ENABLE(INSPECTOR) 166 167 if (shouldOpenWebInspector(m_pathOrURL.c_str())) 167 168 WKInspectorShow(WKPageGetInspector(TestController::shared().mainWebView()->page())); 169 #endif // ENABLE(INSPECTOR) 168 170 169 171 WKPageLoadURL(TestController::shared().mainWebView()->page(), m_url.get()); … … 175 177 dump("FAIL\n"); 176 178 179 #if ENABLE(INSPECTOR) 177 180 WKInspectorClose(WKPageGetInspector(TestController::shared().mainWebView()->page())); 181 #endif // ENABLE(INSPECTOR) 178 182 } 179 183
Note: See TracChangeset
for help on using the changeset viewer.