Changeset 113945 in webkit

Timestamp:

Apr 11, 2012 11:35:40 PM (12 years ago)

Author:

abarth@webkit.org

Message:

Implement Location.ancestorOrigins
​https://bugs.webkit.org/show_bug.cgi?id=83493

Reviewed by David Levin.

Source/WebCore:

Test: fast/dom/Window/Location/ancestor-origins.html

This patch implements Location.ancestorOrigins(), which returns a list
of the origins of the enclosing frames. This API has been discussed
both on webkit-dev (see discussion following
​https://lists.webkit.org/pipermail/webkit-dev/2012-March/020090.html)
and on the whatwg list (see discussion following
​http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-March/035188.html).

• page/Location.cpp:

(WebCore::Location::ancestorOrigins):
(WebCore):

• page/Location.h:

(Location):

• page/Location.idl:

LayoutTests:

• fast/dom/Window/Location/ancestor-origins-expected.txt: Added.
• fast/dom/Window/Location/ancestor-origins.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/Window/Location/ancestor-origins-expected.txt (added)
• LayoutTests/fast/dom/Window/Location/ancestor-origins.html (added)
• LayoutTests/fast/dom/Window/window-appendages-cleared-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/Location.cpp (modified) (1 diff)
• Source/WebCore/page/Location.h (modified) (2 diffs)
• Source/WebCore/page/Location.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-04-11  Adam Barth  <abarth@webkit.org>
+
+        Implement Location.ancestorOrigins
+        https://bugs.webkit.org/show_bug.cgi?id=83493
+
+        Reviewed by David Levin.
+
+        * fast/dom/Window/Location/ancestor-origins-expected.txt: Added.
+        * fast/dom/Window/Location/ancestor-origins.html: Added.
+
 2012-04-11  Antonio Gomes  <agomes@rim.com>
 

trunk/LayoutTests/fast/dom/Window/window-appendages-cleared-expected.txt

@@ -6 +6 @@
 PASS history.replaceState == "LEFTOVER" is false
 PASS history.state == "LEFTOVER" is false
+PASS location.ancestorOrigins == "LEFTOVER" is false
 PASS location.assign == "LEFTOVER" is false
 PASS location.hash == "LEFTOVER" is false

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-04-11  Adam Barth  <abarth@webkit.org>
+
+        Implement Location.ancestorOrigins
+        https://bugs.webkit.org/show_bug.cgi?id=83493
+
+        Reviewed by David Levin.
+
+        Test: fast/dom/Window/Location/ancestor-origins.html
+
+        This patch implements Location.ancestorOrigins(), which returns a list
+        of the origins of the enclosing frames.  This API has been discussed
+        both on webkit-dev (see discussion following
+        https://lists.webkit.org/pipermail/webkit-dev/2012-March/020090.html)
+        and on the whatwg list (see discussion following
+        http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-March/035188.html).
+
+        * page/Location.cpp:
+        (WebCore::Location::ancestorOrigins):
+        (WebCore):
+        * page/Location.h:
+        (Location):
+        * page/Location.idl:
+
 2012-04-11  Raymond Liu  <raymond.liu@intel.com>
 

trunk/Source/WebCore/page/Location.cpp

@@ -125 +125 @@
 }
 
+PassRefPtr<DOMStringList> Location::ancestorOrigins() const
+{
+    RefPtr<DOMStringList> origins = DOMStringList::create();
+    if (!m_frame)
+        return origins.release();
+    for (Frame* frame = m_frame->tree()->parent(true); frame; frame = frame->tree()->parent(true))
+        origins->append(frame->document()->securityOrigin()->toString());
+    return origins.release();
+}
+
 String Location::hash() const
 {

trunk/Source/WebCore/page/Location.h

@@ -30 +30 @@
 #define Location_h
 
+#include "DOMStringList.h"
 #include "DOMWindowProperty.h"
 #include <wtf/PassRefPtr.h>
@@ -72 +73 @@
     String toString() const { return href(); }
 
+    PassRefPtr<DOMStringList> ancestorOrigins() const;
+
 private:
     explicit Location(Frame*);

trunk/Source/WebCore/page/Location.idl

@@ -65 +65 @@
 #endif
 
+        readonly attribute DOMStringList ancestorOrigins;
+
 #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
         [NotEnumerable, Custom, V8Unforgeable, V8ReadOnly, ImplementedAs=toStringFunction] DOMString toString();