Changeset 114085 in webkit

Timestamp:

Apr 12, 2012 11:07:40 PM (12 years ago)

Author:

tkent@chromium.org

Message:

LocalizedDateICU should ignore timezones
​https://bugs.webkit.org/show_bug.cgi?id=83859

Reviewed by Hajime Morita.

udat_parse() and udat_format() shift the input date by the offset of the
default timezone. We don't need this behavior for type=date. So we
specify "GMT" to udat_open().

No new tests. This behavior depends on the timezone setting of the local machine.

• platform/text/LocalizedDateICU.cpp:

(WebCore::createShortDateFormatter):
Added. Common factory functio for UDateFormat. Use "GMT" instead of the
default timezone.
(WebCore::parseLocalizedDate): Use createShortDateFormatter().
(WebCore::formatLocalizedDate): ditto.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/text/LocalizedDateICU.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-04-12  Kent Tamura  <tkent@chromium.org>
+
+        LocalizedDateICU should ignore timezones
+        https://bugs.webkit.org/show_bug.cgi?id=83859
+
+        Reviewed by Hajime Morita.
+
+        udat_parse() and udat_format() shift the input date by the offset of the
+        default timezone. We don't need this behavior for type=date. So we
+        specify "GMT" to udat_open().
+
+        No new tests. This behavior depends on the timezone setting of the local machine.
+
+        * platform/text/LocalizedDateICU.cpp:
+        (WebCore::createShortDateFormatter):
+        Added. Common factory functio for UDateFormat. Use "GMT" instead of the
+        default timezone.
+        (WebCore::parseLocalizedDate): Use createShortDateFormatter().
+        (WebCore::formatLocalizedDate): ditto.
+
 2012-04-12  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/platform/text/LocalizedDateICU.cpp

@@ -44 +44 @@
 namespace WebCore {
 
+static inline UDateFormat* createShortDateFormatter()
+{
+    const UChar gmtTimezone[3] = {'G', 'M', 'T'};
+    UErrorCode status = U_ZERO_ERROR;
+    return udat_open(UDAT_NONE, UDAT_SHORT, defaultLanguage().utf8().data(), gmtTimezone, WTF_ARRAY_LENGTH(gmtTimezone), 0, -1, &status);
+}
+
 double parseLocalizedDate(const String& input, DateComponents::Type type)
 {
@@ -51 +58 @@
             break;
         int32_t inputLength = static_cast<int32_t>(input.length());
-        UErrorCode status = U_ZERO_ERROR;
-        UDateFormat* dateFormat = udat_open(UDAT_NONE, UDAT_SHORT, defaultLanguage().utf8().data(), 0, -1, 0, -1, &status);
+        UDateFormat* dateFormat = createShortDateFormatter();
         if (!dateFormat)
             break;
-        status = U_ZERO_ERROR;
+        UErrorCode status = U_ZERO_ERROR;
         int32_t parsePosition = 0;
         UDate date = udat_parse(dateFormat, input.characters(), inputLength, &parsePosition, &status);
@@ -79 +85 @@
     switch (dateComponents.type()) {
     case DateComponents::Date: {
-        UErrorCode status = U_ZERO_ERROR;
-        UDateFormat* dateFormat = udat_open(UDAT_NONE, UDAT_SHORT, defaultLanguage().utf8().data(), 0, -1, 0, -1, &status);
+        UDateFormat* dateFormat = createShortDateFormatter();
         if (!dateFormat)
             break;
         double input = dateComponents.millisecondsSinceEpoch();
+        UErrorCode status = U_ZERO_ERROR;
         int32_t length = udat_format(dateFormat, input, 0, 0, 0, &status);
         if (status != U_BUFFER_OVERFLOW_ERROR) {