Changeset 114210 in webkit
- Timestamp:
- Apr 14, 2012 8:31:43 PM (12 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r114208 r114210 1 2012-04-14 Kent Tamura <tkent@chromium.org> 2 3 Day of week labels are wrong if WebCore::firstDayOfWeek() is not 0 4 https://bugs.webkit.org/show_bug.cgi?id=83990 5 6 Reviewed by Kentaro Hara. 7 8 We passed the "weekStartDay" property value as a 9 string. CalendarPickerElement::writeDocument() created: 10 weekStartDay: "1", 11 and the JavaScript code used it in the following code: 12 dayLabels[(weekStartDay + i) % 7] 13 If weekStartDay was "1", the expression (weekStartDay + i) 14 produced "10", "11", "12", ... We expected "1", "2", "3", ... 15 16 We need to pass the "weekStartDay" property as a number. 17 18 No new tests because we have no ways to test this for now. We'll 19 introduce tests for the calendar picker later. 20 21 * html/shadow/CalendarPickerElement.cpp: 22 (WebCore::addProperty): Add addProperty() function for a number. 23 (WebCore::CalendarPickerElement::writeDocument): 24 Pass a number, not a serialized number. 25 1 26 2012-04-14 Joe Thomas <joethomas@motorola.com> 2 27 -
trunk/Source/WebCore/html/shadow/CalendarPickerElement.cpp
r113821 r114210 161 161 } 162 162 163 static void addProperty(const char* name, unsigned value, DocumentWriter& writer) 164 { 165 writer.addData(name, strlen(name)); 166 addLiteral(": ", writer); 167 addString(String::number(value), writer); 168 addLiteral(",\n", writer); 169 } 170 163 171 static void addProperty(const char* name, const Vector<String>& values, DocumentWriter& writer) 164 172 { … … 198 206 addProperty("todayLabel", calendarTodayText(), writer); 199 207 addProperty("clearLabel", calendarClearText(), writer); 200 addProperty("weekStartDay", String::number(firstDayOfWeek()), writer);208 addProperty("weekStartDay", firstDayOfWeek(), writer); 201 209 addProperty("monthLabels", monthLabels(), writer); 202 210 addProperty("dayLabels", weekDayShortLabels(), writer);
Note: See TracChangeset
for help on using the changeset viewer.