Changeset 114316 in webkit

Timestamp:

Apr 16, 2012 4:32:16 PM (12 years ago)

Author:

xji@chromium.org

Message:

platform/graphics/skia/GlyphPageTreeNodeSkia.cpp mis-use 'continue' for 'break'
​https://bugs.webkit.org/show_bug.cgi?id=83521

Reviewed by David Levin.

No functionality change, so no new tests.

• platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:

(WebCore::GlyphPage::fill):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/skia/GlyphPageTreeNodeSkia.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-04-16  Xiaomei Ji  <xji@chromium.org>
+
+        platform/graphics/skia/GlyphPageTreeNodeSkia.cpp mis-use 'continue' for 'break'
+        https://bugs.webkit.org/show_bug.cgi?id=83521
+
+        Reviewed by David Levin.
+
+        No functionality change, so no new tests.
+
+        * platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
+        (WebCore::GlyphPage::fill):
+
 2012-04-16  Levi Weintraub  <leviw@chromium.org>
 

trunk/Source/WebCore/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp

@@ -97 +97 @@
 
     if (fontData->hasVerticalGlyphs()) {
-        bool lookVariants = false;
         for (unsigned i = 0; i < bufferLength; ++i) {
             if (!Font::isCJKIdeograph(buffer[i])) {
-                lookVariants = true;
-                continue;
+                substituteWithVerticalGlyphs(fontData, glyphs, length);
+                break;
             }
         }
-        if (lookVariants)
-            substituteWithVerticalGlyphs(fontData, glyphs, length);
     }