Changeset 114609 in webkit

Timestamp:

Apr 18, 2012 10:40:08 PM (12 years ago)

Author:

eae@chromium.org

Message:

Remove unnecessary rounding/conversions in RenderBoxModelObject
​https://bugs.webkit.org/show_bug.cgi?id=84288

Reviewed by Eric Seidel.

No new tests, no change in functionality.

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBoxShadow):
Remove unnecessary pixelSnapping logic and casts in paintBoxShadow as
shadow rects are now int based.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderBoxModelObject.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-04-18  Emil A Eklund  <eae@chromium.org>
+
+        Remove unnecessary rounding/conversions in RenderBoxModelObject
+        https://bugs.webkit.org/show_bug.cgi?id=84288
+
+        Reviewed by Eric Seidel.
+
+        No new tests, no change in functionality.
+
+        * rendering/RenderBoxModelObject.cpp:
+        (WebCore::RenderBoxModelObject::paintBoxShadow):
+        Remove unnecessary pixelSnapping logic and casts in paintBoxShadow as
+        shadow rects are now int based.
+
 2012-04-18  Jason Liu  <jason.liu@torchmobile.com.cn>
 

trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp

@@ -2893 +2893 @@
                     context->clipOutRoundedRect(rectToClipOut);
 
-                RoundedRect influenceRect(pixelSnappedIntRect(shadowRect), border.radii());
+                RoundedRect influenceRect(shadowRect, border.radii());
                 influenceRect.expandRadii(2 * shadowBlur + shadowSpread);
                 if (allCornersClippedOut(influenceRect, info.rect))
@@ -2944 +2944 @@
             if (!includeLogicalRightEdge) {
                 if (isHorizontal)
-                    holeRect.setWidth(holeRect.width() - min<LayoutUnit>(shadowOffset.width(), 0) + shadowBlur);
+                    holeRect.setWidth(holeRect.width() - min(shadowOffset.width(), 0) + shadowBlur);
                 else
-                    holeRect.setHeight(holeRect.height() - min<LayoutUnit>(shadowOffset.height(), 0) + shadowBlur);
+                    holeRect.setHeight(holeRect.height() - min(shadowOffset.height(), 0) + shadowBlur);
             }