Changeset 114764 in webkit

Timestamp:

Apr 20, 2012 11:12:47 AM (12 years ago)

Author:

eae@chromium.org

Message:

[win] Update windows platform code to use pixel snapped values
​https://bugs.webkit.org/show_bug.cgi?id=84283

Reviewed by Eric Seidel.

Source/WebCore:

No new tests, no change in functionality.

• accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::pixelSnappedElementRect):
Use pixel snapped values when computing screenRect.

• platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):
Cast client padding to ints as they are guaranteed to align with device pixels.

Source/WebKit/win:

• AccessibleBase.cpp:

(AccessibleBase::accLocation):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/accessibility/AccessibilityObject.h (modified) (1 diff)
• WebCore/platform/win/PopupMenuWin.cpp (modified) (2 diffs)
• WebKit/win/AccessibleBase.cpp (modified) (1 diff)
• WebKit/win/ChangeLog (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-04-20  Emil A Eklund  <eae@chromium.org>
+
+        [win] Update windows platform code to use pixel snapped values
+        https://bugs.webkit.org/show_bug.cgi?id=84283
+
+        Reviewed by Eric Seidel.
+
+        No new tests, no change in functionality.
+
+        * accessibility/AccessibilityObject.h:
+        (WebCore::AccessibilityObject::pixelSnappedElementRect):
+        Use pixel snapped values when computing screenRect.
+        
+        * platform/win/PopupMenuWin.cpp:
+        (WebCore::PopupMenuWin::calculatePositionAndSize):
+        (WebCore::PopupMenuWin::paint):
+        Cast client padding to ints as they are guaranteed to align with device pixels.
+
 2012-04-20  Dana Jansens  <danakj@chromium.org>
 

trunk/Source/WebCore/accessibility/AccessibilityObject.h

@@ -507 +507 @@
     IntRect pixelSnappedBoundingBoxRect() const { return pixelSnappedIntRect(boundingBoxRect()); }
     virtual LayoutRect elementRect() const = 0;
+    IntRect pixelSnappedElementRect() const { return pixelSnappedIntRect(elementRect()); }
     LayoutSize size() const { return elementRect().size(); }
     IntSize pixelSnappedSize() const { return elementRect().pixelSnappedSize(); }

trunk/Source/WebCore/platform/win/PopupMenuWin.cpp

@@ -342 +342 @@
 
     // Add padding to align the popup text with the <select> text
-    popupWidth += max(0, client()->clientPaddingRight() - client()->clientInsetRight()) + max(0, client()->clientPaddingLeft() - client()->clientInsetLeft());
+    popupWidth += max<int>(0, client()->clientPaddingRight() - client()->clientInsetRight()) + max<int>(0, client()->clientPaddingLeft() - client()->clientInsetLeft());
 
     // Leave room for the border
@@ -654 +654 @@
         // Draw the item text
         if (itemStyle.isVisible()) {
-            int textX = max(0, client()->clientPaddingLeft() - client()->clientInsetLeft());
+            int textX = max<int>(0, client()->clientPaddingLeft() - client()->clientInsetLeft());
             if (RenderTheme::defaultTheme()->popupOptionSupportsTextIndent() && itemStyle.textDirection() == LTR)
                 textX += minimumValueForLength(itemStyle.textIndent(), itemRect.width());

trunk/Source/WebKit/win/AccessibleBase.cpp

@@ -499 +499 @@
         return E_FAIL;
 
-    IntRect screenRect(childObj->documentFrameView()->contentsToScreen(childObj->elementRect()));
+    IntRect screenRect(childObj->documentFrameView()->contentsToScreen(childObj->pixelSnappedElementRect()));
     *left = screenRect.x();
     *top = screenRect.y();

trunk/Source/WebKit/win/ChangeLog

@@ +1 @@
+2012-04-20  Emil A Eklund  <eae@chromium.org>
+
+        [win] Update windows platform code to use pixel snapped values
+        https://bugs.webkit.org/show_bug.cgi?id=84283
+
+        Reviewed by Eric Seidel.
+
+        * AccessibleBase.cpp:
+        (AccessibleBase::accLocation):
+
 2012-04-18  Vivek Galatage  <vivekgalatage@gmail.com>