Changeset 114775 in webkit


Ignore:
Timestamp:
Apr 20, 2012 1:22:03 PM (12 years ago)
Author:
eae@chromium.org
Message:

Fix use of LayoutUnits in DOMNodeHighlighter
https://bugs.webkit.org/show_bug.cgi?id=84472

Reviewed by Eric Seidel.

Fix use of subpixel units and rounding in new code introduced in r114659.

No new tests, no change in functionality.

  • inspector/DOMNodeHighlighter.cpp:
Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r114770 r114775  
     12012-04-20  Emil A Eklund  <eae@chromium.org>
     2
     3        Fix use of LayoutUnits in DOMNodeHighlighter
     4        https://bugs.webkit.org/show_bug.cgi?id=84472
     5
     6        Reviewed by Eric Seidel.
     7
     8        Fix use of subpixel units and rounding in new code introduced in r114659.
     9
     10        No new tests, no change in functionality.
     11
     12        * inspector/DOMNodeHighlighter.cpp:
     13
    1142012-04-17  Antonio Gomes  <agomes@rim.com>
    215
  • trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp

    r114659 r114775  
    356356static void contentsQuadToRootView(FloatQuad& quad, FrameView* view)
    357357{
    358     quad.setP1(view->contentsToRootView(roundedLayoutPoint(quad.p1())));
    359     quad.setP2(view->contentsToRootView(roundedLayoutPoint(quad.p2())));
    360     quad.setP3(view->contentsToRootView(roundedLayoutPoint(quad.p3())));
    361     quad.setP4(view->contentsToRootView(roundedLayoutPoint(quad.p4())));
     358    quad.setP1(view->contentsToRootView(roundedIntPoint(quad.p1())));
     359    quad.setP2(view->contentsToRootView(roundedIntPoint(quad.p2())));
     360    quad.setP3(view->contentsToRootView(roundedIntPoint(quad.p3())));
     361    quad.setP4(view->contentsToRootView(roundedIntPoint(quad.p4())));
    362362}
    363363
     
    458458
    459459    if (context && highlightData->showInfo)
    460         drawElementTitle(*context, node, renderer, boundingBox, titleAnchorBox, visibleRect, containingFrame->settings());
     460        drawElementTitle(*context, node, renderer, pixelSnappedIntRect(boundingBox), pixelSnappedIntRect(titleAnchorBox), visibleRect, containingFrame->settings());
    461461}
    462462
Note: See TracChangeset for help on using the changeset viewer.