Changeset 11542 in webkit

Timestamp:

Dec 12, 2005 11:22:15 AM (18 years ago)

Author:

eseidel

Message:

Bug #: 4372143
Submitted by: eseidel
Reviewed by: ggaren

Test: fast/forms/textarea-setinnerhtml.html

Fixes setInnerHTML for <textarea>
<rdar://problem/4372143>

• khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::setValue):

Location:

trunk/WebCore

Files:

• ChangeLog-2005-12-19 (modified) (1 diff)
• khtml/html/html_formimpl.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog-2005-12-19

@@ +1 @@
+2005-12-12  Eric Seidel  <eseidel@apple.com>
+
+        Reviewed by ggaren.
+
+        Test: fast/forms/textarea-setinnerhtml.html
+
+        Fixes setInnerHTML for <textarea>
+        <rdar://problem/4372143>
+
+        * khtml/html/html_formimpl.cpp:
+        (DOM::HTMLTextAreaElementImpl::setValue):
+
 2005-12-12  Adele Peterson  <adele@apple.com>
 

trunk/WebCore/khtml/html/html_formimpl.cpp

@@ -3485 +3485 @@
     m_value = value.qstring();
     m_valueMatchesRenderer = false;
+    m_valueIsValid = true;
     if (m_render)
         m_render->updateFromElement();
-    m_valueIsValid = false; // force the next access to fetch from the renderer
+    // FIXME: Force reload from renderer, as renderer may have normalized line endings.
+    m_valueIsValid = false;
     setChanged(true);
 }