Changeset 115666 in webkit


Ignore:
Timestamp:
Apr 30, 2012 2:11:45 PM (12 years ago)
Author:
weinig@apple.com
Message:

Remove BlobBuilder
​https://bugs.webkit.org/show_bug.cgi?id=84036

Reviewed by Anders Carlsson.

Source/WebCore:

  • GNUmakefile.am:
  • fileapi/WebKitBlobBuilder.idl:
  • page/DOMWindow.idl:
  • workers/WorkerContext.idl:

Make exposing the WebKitBlobBuilder JS object conditional on a new
ENABLE_LEGACY_WEBKIT_BLOB_BUILDER flag. Don't enable this for the Mac,
but do for everyone else.

Source/WebKit/chromium:

  • features.gypi:

Keep WebKitBlobBuilder enabled for Chromium, since it has shipped it.

Tools:

  • Scripts/build-webkit:
  • qmake/mkspecs/features/features.prf:

Make exposing the WebKitBlobBuilder JS object conditional on a new
ENABLE_LEGACY_WEBKIT_BLOB_BUILDER flag. Don't enable this for the Mac,
but do for everyone else.

LayoutTests:

  • fast/js/constructor-length.html:
  • platform/mac/fast/js/constructor-length-expected.txt:

Remove WebKitBlobBuilder from this test, as it is not exposed on all platforms,
and add Blob, which is.

  • platform/mac/Skipped:

Skip fast/files/blob-builder-crash.html, since we no longer support WebKitBlobBuilder.

Location:
trunk
Files:
17 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r115658 r115666  
     12012-04-30  Sam Weinig  <sam@webkit.org>
     2
     3        Remove BlobBuilder
     4        https://bugs.webkit.org/show_bug.cgi?id=84036
     5
     6        Reviewed by Anders Carlsson.
     7
     8        * fast/js/constructor-length.html:
     9        * platform/mac/fast/js/constructor-length-expected.txt:
     10        Remove WebKitBlobBuilder from this test, as it is not exposed on all platforms,
     11        and add Blob, which is.
     12
     13        * platform/mac/Skipped:
     14        Skip fast/files/blob-builder-crash.html, since we no longer support WebKitBlobBuilder.
     15
    1162012-04-30  Mark Hahnenberg  <mhahnenberg@apple.com>
    217

  • trunk/LayoutTests/fast/js/constructor-length.html

    r109574 r115666  
    1111shouldBe('AudioContext.length', '0');
    1212shouldBe('BeforeLoadEvent.length', '2');
     13shouldBe('Blob.length', '2');
    1314shouldBe('CloseEvent.length', '2');
    1415shouldBe('CustomEvent.length', '2');
    … …  
    4849shouldBe('WebGLContextEvent.length', '2');
    4950shouldBe('WebKitAnimationEvent.length', '2');
    50 shouldBe('WebKitBlobBuilder.length', '0');
    5151shouldBe('WebKitCSSMatrix.length', '1');
    5252shouldBe('WebKitMutationObserver.length', '1');

  • trunk/LayoutTests/platform/mac/Skipped

    r115605 r115666  
    794794# Requires rebaseline after bug 83978
    795795tables/mozilla_expected_failures/collapsing_borders/bug41262-5.html
     796
     797# The Mac port does not support the legacy WebKitBlobBuilder class.
     798fast/files/blob-builder-crash.html

  • trunk/LayoutTests/platform/mac/fast/js/constructor-length-expected.txt

    r109574 r115666  
    77FAIL AudioContext.length should be 0. Threw exception ReferenceError: Can't find variable: AudioContext
    88PASS BeforeLoadEvent.length is 2
     9PASS Blob.length is 2
    910PASS CloseEvent.length is 2
    1011PASS CustomEvent.length is 2
    … …  
    4445PASS WebGLContextEvent.length is 2
    4546PASS WebKitAnimationEvent.length is 2
    46 PASS WebKitBlobBuilder.length is 0
    4747PASS WebKitCSSMatrix.length is 1
    4848PASS WebKitMutationObserver.length is 1

  • trunk/Source/WebCore/ChangeLog

    r115665 r115666  
     12012-04-29  Sam Weinig  <sam@webkit.org>
     2
     3        Remove BlobBuilder
     4        https://bugs.webkit.org/show_bug.cgi?id=84036
     5
     6        Reviewed by Anders Carlsson.
     7
     8        * GNUmakefile.am:
     9        * fileapi/WebKitBlobBuilder.idl:
     10        * page/DOMWindow.idl:
     11        * workers/WorkerContext.idl:
     12        Make exposing the WebKitBlobBuilder JS object conditional on a new
     13        ENABLE_LEGACY_WEBKIT_BLOB_BUILDER flag. Don't enable this for the Mac,
     14        but do for everyone else.
     15
    1162012-04-30  Anders Carlsson  <andersca@apple.com>
    217

  • trunk/Source/WebCore/GNUmakefile.am

    r114736 r115666  
    557557webcore_cppflags += -DENABLE_BLOB=1
    558558endif  # END ENABLE_BLOB
     559
     560# ---
     561# Legacy WebKitBlobBuilder support
     562# ---
     563if ENABLE_LEGACY_WEBKIT_BLOB_BUILDER
     564FEATURE_DEFINES += ENABLE_LEGACY_WEBKIT_BLOB_BUILDER=1
     565webcore_cppflags += -DENABLE_LEGACY_WEBKIT_BLOB_BUILDER=1
     566endif  # END ENABLE_LEGACY_WEBKIT_BLOB_BUILDER
    559567
    560568# ---

  • trunk/Source/WebCore/fileapi/WebKitBlobBuilder.idl

    r107041 r115666  
    3131module html {
    3232    interface [
     33        Conditional=LEGACY_WEBKIT_BLOB_BUILDER,
    3334        Constructor,
    3435        JSGenerateToNativeObject,

  • trunk/Source/WebCore/page/DOMWindow.idl

    r115446 r115666  
    770770        attribute [Conditional=BLOB] FileReaderConstructor FileReader;
    771771
    772         attribute [Conditional=BLOB] WebKitBlobBuilderConstructor WebKitBlobBuilder;
     772        attribute [Conditional=BLOB&LEGACY_WEBKIT_BLOB_BUILDER] WebKitBlobBuilderConstructor WebKitBlobBuilder;
    773773
    774774        attribute [Conditional=BLOB] DOMURLConstructor webkitURL;

  • trunk/Source/WebCore/workers/WorkerContext.idl

    r115582 r115666  
    8484
    8585#if defined(ENABLE_BLOB) && ENABLE_BLOB
    86         attribute WebKitBlobBuilderConstructor WebKitBlobBuilder;
     86        attribute [Conditional=LEGACY_WEBKIT_BLOB_BUILDER] WebKitBlobBuilderConstructor WebKitBlobBuilder;
    8787        attribute BlobConstructor Blob;
    8888        attribute FileReaderConstructor FileReader;

  • trunk/Source/WebKit/chromium/ChangeLog

    r115661 r115666  
     12012-04-29  Sam Weinig  <sam@webkit.org>
     2
     3        Remove BlobBuilder
     4        https://bugs.webkit.org/show_bug.cgi?id=84036
     5
     6        Reviewed by Anders Carlsson.
     7
     8        * features.gypi:
     9        Keep WebKitBlobBuilder enabled for Chromium, since it has shipped it.
     10
    1112012-04-30  Min Qin  <qinmin@google.com>
    212

  • trunk/Source/WebKit/chromium/features.gypi

    r115661 r115666  
    6868      'ENABLE_LEGACY_CSS_VENDOR_PREFIXES=0',
    6969      'ENABLE_LEGACY_NOTIFICATIONS=1',
     70      'ENABLE_LEGACY_WEBKIT_BLOB_BUILDER=1',
    7071      'ENABLE_LINK_PREFETCH=1',
    7172      'ENABLE_LINK_PRERENDER=1',

  • trunk/Source/cmake/OptionsBlackBerry.cmake

    r115348 r115666  
    144144WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INPUT_TYPE_COLOR ON)
    145145WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_LEGACY_NOTIFICATIONS ON)
     146WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_LEGACY_WEBKIT_BLOB_BUILDER ON)
    146147WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NOTIFICATIONS ON)
    147148WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ORIENTATION_EVENTS ON)

  • trunk/Source/cmake/WebKitFeatures.cmake

    r115341 r115666  
    5353    WEBKIT_OPTION_DEFINE(ENABLE_JIT "Enable JustInTime javascript support" ON)
    5454    WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_NOTIFICATIONS "Toggle Legacy Desktop Notifications Support" OFF)
     55    WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_WEBKIT_BLOB_BUILDER "Toggle Legacy WebKit Blob Builder Support" OFF)
    5556    WEBKIT_OPTION_DEFINE(ENABLE_LINK_PREFETCH "Toggle pre fetching support" OFF)
    5657    WEBKIT_OPTION_DEFINE(ENABLE_MATHML "Toggle MathML support" ON)

  • trunk/Tools/ChangeLog

    r115659 r115666  
     12012-04-29  Sam Weinig  <sam@webkit.org>
     2
     3        Remove BlobBuilder
     4        https://bugs.webkit.org/show_bug.cgi?id=84036
     5
     6        Reviewed by Anders Carlsson.
     7
     8        * Scripts/build-webkit:
     9        * qmake/mkspecs/features/features.prf:
     10        Make exposing the WebKitBlobBuilder JS object conditional on a new
     11        ENABLE_LEGACY_WEBKIT_BLOB_BUILDER flag. Don't enable this for the Mac,
     12        but do for everyone else.
     13
    1142012-04-30  Amruth Raj Padmanabhuni  <amruthraj@motorola.com>
    215

  • trunk/Tools/Scripts/build-webkit

    r115443 r115666  
    106106    $javaScriptDebuggerSupport,
    107107    $legacyNotificationsSupport,
     108    $legacyWebKitBlobBuilderSupport,
    108109    $linkPrefetchSupport,
    109110    $linkPrerenderSupport,
    … …  
    267268      define => "ENABLE_LEGACY_NOTIFICATIONS", default => isBlackBerry(), value => \$legacyNotificationsSupport },
    268269
     270    { option => "legacy-webkit-blob-builder", desc => "Toggle Legacy WebKitBlobBuilder Support",
     271      define => "ENABLE_LEGACY_WEBKIT_BLOB_BUILDER", default => (isGtk() || isChromium() || isBlackBerry()), value => \$legacyWebKitBlobBuilderSupport },
     272
    269273    { option => "link-prefetch", desc => "Toggle pre fetching support",
    270274      define => "ENABLE_LINK_PREFETCH", default => 0, value => \$linkPrefetchSupport },

  • trunk/Tools/qmake/mkspecs/features/features.prf

    r115482 r115666  
    9797!contains(DEFINES, ENABLE_PROGRESS_TAG=.): DEFINES += ENABLE_PROGRESS_TAG=1
    9898!contains(DEFINES, ENABLE_BLOB=.): DEFINES += ENABLE_BLOB=1
     99!contains(DEFINES, ENABLE_LEGACY_WEBKIT_BLOB_BUILDER=.): DEFINES += ENABLE_LEGACY_WEBKIT_BLOB_BUILDER=1
    99100!contains(DEFINES, ENABLE_LEGACY_NOTIFICATIONS=.): DEFINES += ENABLE_LEGACY_NOTIFICATIONS=1
    100101!contains(DEFINES, ENABLE_NOTIFICATIONS=.): DEFINES += ENABLE_NOTIFICATIONS=1
    … …  
    283284contains(DEFINES, ENABLE_GEOLOCATION=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_GEOLOCATION=1
    284285contains(DEFINES, ENABLE_BLOB=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_BLOB=1
     286contains(DEFINES, ENABLE_LEGACY_WEBKIT_BLOB_BUILDER=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_LEGACY_WEBKIT_BLOB_BUILDER=1
    285287contains(DEFINES, ENABLE_MEDIA_SOURCE=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_MEDIA_SOURCE=1
    286288contains(DEFINES, ENABLE_MEDIA_STATISTICS=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_MEDIA_STATISTICS=1

  • trunk/configure.ac

    r115624 r115666  
    940940AC_MSG_RESULT([$enable_blob])
    941941
     942# check whether to enable Legacy WebKitBlobBuilder support
     943AC_MSG_CHECKING([whether to enable Legacy WebKitBlobBuilder support])
     944AC_ARG_ENABLE(legacy_webkit_blob_builder,
     945              AC_HELP_STRING([--enable-legacy-webkit-blob-builder],
     946                             [enable support for Legacy WebKitBlobBuilder [default=yes]]),
     947              [],[enable_legacy_webkit_blob_builder="yes"])
     948AC_MSG_RESULT([$legacy_webkit_blob_builder])
     949
    942950# check whether to enable Fast Mobile Scrolling support
    943951AC_MSG_CHECKING([whether to enable Fast Mobile Scrolling])
    … …  
    13211329AM_CONDITIONAL([ENABLE_WEBGL],[test "$enable_webgl" = "yes"])
    13221330AM_CONDITIONAL([ENABLE_BLOB],[test "$enable_blob" = "yes"])
     1331AM_CONDITIONAL([ENABLE_LEGACY_WEBKIT_BLOB_BUILDER],[test "$enable_legacy_webkit_blob_builder" = "yes"])
    13231332AM_CONDITIONAL([ENABLE_METER_TAG],[test "$enable_meter_tag" = "yes"])
    13241333AM_CONDITIONAL([ENABLE_MICRODATA],[test "$enable_microdata" = "yes"])
    … …  
    14291438 WebGL                                                    : $enable_webgl
    14301439 Blob support                                             : $enable_blob
     1440 Legacy WebKitBlobBuilder support                         : $enable_legacy_webkit_blob_builder
    14311441 DOM mutation observer support                            : $enable_mutation_observers
    14321442 DeviceOrientation support                                : $enable_device_orientation
Note: See TracChangeset for help on using the changeset viewer.