Changeset 115701 in webkit


Ignore:
Timestamp:
Apr 30, 2012 7:15:51 PM (12 years ago)
Author:
leviw@chromium.org
Message:

RenderObject incorrectly lists maximalOutlineSize as a LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=85248

Reviewed by Eric Seidel.

Reverting RenderObject::maximalOutlineSize to int. This is a slop value for repaint
rects that doesn't affect layout. It also derives its value from RenderView's function
of the same name, which is already an integer.

No new tests. No change in behavior.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::maximalOutlineSize):

  • rendering/RenderObject.h:

(RenderObject):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r115699 r115701  
     12012-04-30  Levi Weintraub  <leviw@chromium.org>
     2
     3        RenderObject incorrectly lists maximalOutlineSize as a LayoutUnit
     4        https://bugs.webkit.org/show_bug.cgi?id=85248
     5
     6        Reviewed by Eric Seidel.
     7
     8        Reverting RenderObject::maximalOutlineSize to int. This is a slop value for repaint
     9        rects that doesn't affect layout. It also derives its value from RenderView's function
     10        of the same name, which is already an integer.
     11
     12        No new tests. No change in behavior.
     13
     14        * rendering/RenderObject.cpp:
     15        (WebCore::RenderObject::maximalOutlineSize):
     16        * rendering/RenderObject.h:
     17        (RenderObject):
     18
    1192012-04-30  Xingnan Wang  <xingnan.wang@intel.com>
    220
  • trunk/Source/WebCore/rendering/RenderObject.cpp

    r115691 r115701  
    26922692}
    26932693
    2694 LayoutUnit RenderObject::maximalOutlineSize(PaintPhase p) const
     2694int RenderObject::maximalOutlineSize(PaintPhase p) const
    26952695{
    26962696    if (p != PaintPhaseOutline && p != PaintPhaseSelfOutline && p != PaintPhaseChildOutlines)
  • trunk/Source/WebCore/rendering/RenderObject.h

    r115343 r115701  
    777777
    778778    // Applied as a "slop" to dirty rect checks during the outline painting phase's dirty-rect checks.
    779     LayoutUnit maximalOutlineSize(PaintPhase) const;
     779    int maximalOutlineSize(PaintPhase) const;
    780780
    781781    enum SelectionState {
Note: See TracChangeset for help on using the changeset viewer.