Changeset 115953 in webkit

Timestamp:

May 3, 2012 3:02:54 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

CSS clip: auto clips to box borders instead of removing clipping
​https://bugs.webkit.org/show_bug.cgi?id=36772

Patch by Uday Kiran <​udaykiran@motorola.com> on 2012-05-03
Reviewed by Andreas Kling.

Source/WebCore:

According to CSS 2.1 spec, ​http://www.w3.org/TR/CSS2/visufx.html#propdef-clip,
clip property with value 'auto' the element does not clip.
Also getPropertyValue for clip when auto is specified should return "auto"
and not "rect(0px 0px 0px 0px)".

Tests: css2.1/20110323/clip-001-expected.html

css2.1/20110323/clip-001.html

• css/StyleBuilder.cpp:

(WebCore::ApplyPropertyClip::applyValue):

LayoutTests:

CSS 2.1 test case added for clip:auto

• css2.1/20110323/clip-001-expected.html: Added.
• css2.1/20110323/clip-001.html: Added.
• fast/css/getPropertyValue-clip.html: getPropertyValue for clip when auto is specified should return auto and not rect(0px 0px 0px 0px).

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/css2.1/20110323/clip-001-expected.html (added)
• LayoutTests/css2.1/20110323/clip-001.html (added)
• LayoutTests/fast/css/getPropertyValue-clip.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/StyleBuilder.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-03  Uday Kiran  <udaykiran@motorola.com>
+
+        CSS clip: auto clips to box borders instead of removing clipping
+        https://bugs.webkit.org/show_bug.cgi?id=36772
+
+        Reviewed by Andreas Kling.
+
+        CSS 2.1 test case added for clip:auto
+
+        * css2.1/20110323/clip-001-expected.html: Added.
+        * css2.1/20110323/clip-001.html: Added.
+        * fast/css/getPropertyValue-clip.html: getPropertyValue for clip when auto is specified should return auto and not rect(0px 0px 0px 0px).
+
 2012-05-03  Nikolas Zimmermann  <nzimmermann@rim.com>
 

trunk/LayoutTests/fast/css/getPropertyValue-clip.html

@@ -20 +20 @@
       }
       div = document.getElementById("clip2");
-      if (getComputedStyle(div,'').getPropertyValue("clip") != "rect(0px 0px 0px 0px)") {
+      if (getComputedStyle(div,'').getPropertyValue("clip") != "auto") {
           log("FAILED");
           return;

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-03  Uday Kiran  <udaykiran@motorola.com>
+
+        CSS clip: auto clips to box borders instead of removing clipping
+        https://bugs.webkit.org/show_bug.cgi?id=36772
+
+        Reviewed by Andreas Kling.
+
+        According to CSS 2.1 spec, http://www.w3.org/TR/CSS2/visufx.html#propdef-clip,
+        clip property with value 'auto' the element does not clip.
+        Also getPropertyValue for clip when auto is specified should return "auto"
+        and not "rect(0px 0px 0px 0px)".
+
+        Tests: css2.1/20110323/clip-001-expected.html
+               css2.1/20110323/clip-001.html
+
+        * css/StyleBuilder.cpp:
+        (WebCore::ApplyPropertyClip::applyValue):
+
 2012-05-02  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/css/StyleBuilder.cpp

@@ -256 +256 @@
         } else if (primitiveValue->getIdent() == CSSValueAuto) {
             styleResolver->style()->setClip(Length(), Length(), Length(), Length());
-            styleResolver->style()->setHasClip(true);
+            styleResolver->style()->setHasClip(false);
         }
     }