Changeset 116132 in webkit

Timestamp:

May 4, 2012 11:38:03 AM (12 years ago)

Author:

abarth@webkit.org

Message:

CSP: Eval isn't blocked in about:blank subframes
​https://bugs.webkit.org/show_bug.cgi?id=85553

Reviewed by Eric Seidel.

This patch fixes a race condition in this test. We need to wait for
the load event to ensure that the iframe has finished loading.

• http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-04  Adam Barth  <abarth@webkit.org>
+
+        CSP: Eval isn't blocked in about:blank subframes
+        https://bugs.webkit.org/show_bug.cgi?id=85553
+
+        Reviewed by Eric Seidel.
+
+        This patch fixes a race condition in this test.  We need to wait for
+        the load event to ensure that the iframe has finished loading.
+
+        * http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe.html:
+
 2012-05-04  Alexander Pavlov  <apavlov@chromium.org>
 

trunk/LayoutTests/http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe.html

@@ -7 +7 @@
 Eval should be blocked in the iframe, but inline script should be allowed.
 <script>
-frames[0].document.write("<script>alert(/PASS/); eval('alert(/FAIL/);');<\/script>");
+window.onload = function() {
+    frames[0].document.write("<script>alert(/PASS/); eval('alert(/FAIL/);');<\/script>");
+}
 </script>