Changeset 116171 in webkit

Timestamp:

May 4, 2012 2:21:52 PM (12 years ago)

Author:

rafaelw@chromium.org

Message:

V8RecursionScope not declared in V8Proxy::newInstance which causes ASSERT() failure from NPAPI
​https://bugs.webkit.org/show_bug.cgi?id=85659

Reviewed by Ojan Vafai.

Added a stack-allocted V8RecursionScope to the newInstance call.

No new tests. No change in observable behavior.

• bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::newInstance):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8Proxy.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-04  Rafael Weinstein  <rafaelw@chromium.org>
+
+        V8RecursionScope not declared in V8Proxy::newInstance which causes ASSERT() failure from NPAPI
+        https://bugs.webkit.org/show_bug.cgi?id=85659
+
+        Reviewed by Ojan Vafai.
+
+        Added a stack-allocted V8RecursionScope to the newInstance call.
+
+        No new tests. No change in observable behavior.
+
+        * bindings/v8/V8Proxy.cpp:
+        (WebCore::V8Proxy::newInstance):
+
 2012-05-04  Joshua Bell  <jsbell@chromium.org>
 

trunk/Source/WebCore/bindings/v8/V8Proxy.cpp

@@ -436 +436 @@
     v8::Local<v8::Value> result;
     {
+        V8RecursionScope recursionScope(frame() ? frame()->document() : 0);
         result = constructor->NewInstance(argc, args);
     }