Changeset 116173 in webkit

Timestamp:

May 4, 2012 2:30:52 PM (12 years ago)

Author:

jer.noble@apple.com

Message:

Taking a visibility:hidden element full screen causes full screen window to disappear.
​https://bugs.webkit.org/show_bug.cgi?id=85432

Reviewed by Maciej Stachowiak.

.:

• ManualTests/fullscreen/full-screen-zero-width.html: Added.

Source/WebKit/mac:

When given an initial or final frame with a zero width or height, return a rect representing
the entire screen, rather than a rect with a zero or infinite size. Doing otherwise will
confuse the window server when it's instructed to scale the full screen window to that size.

• WebView/WebFullScreenController.mm:

(windowFrameFromApparentFrames):

Source/WebKit2:

When given an initial or final frame with a zero width or height, return a rect representing
the entire screen, rather than a rect with a zero or infinite size. Doing otherwise will
confuse the window server when it's instructed to scale the full screen window to that size.

• UIProcess/mac/WKFullScreenWindowController.mm:

(windowFrameFromApparentFrames):

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• ManualTests/fullscreen (added)
• ManualTests/fullscreen/full-screen-zero-width.html (added)
• Source/WebKit/mac/ChangeLog (modified) (1 diff)
• Source/WebKit/mac/WebView/WebFullScreenController.mm (modified) (1 diff)
• Source/WebKit2/ChangeLog (modified) (1 diff)
• Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2012-05-04  Jer Noble  <jer.noble@apple.com>
+
+        Taking a visibility:hidden element full screen causes full screen window to disappear.
+        https://bugs.webkit.org/show_bug.cgi?id=85432
+
+        Reviewed by Maciej Stachowiak.
+
+        * ManualTests/fullscreen/full-screen-zero-width.html: Added.
+
 2012-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2012-05-02  Jer Noble  <jer.noble@apple.com>
+
+        Taking a visibility:hidden element full screen causes full screen window to disappear.
+        https://bugs.webkit.org/show_bug.cgi?id=85432
+
+        Reviewed by Maciej Stachowiak.
+
+        When given an initial or final frame with a zero width or height, return a rect representing
+        the entire screen, rather than a rect with a zero or infinite size. Doing otherwise will
+        confuse the window server when it's instructed to scale the full screen window to that size.
+
+        * WebView/WebFullScreenController.mm:
+        (windowFrameFromApparentFrames):
+
 2012-05-04  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebKit/mac/WebView/WebFullScreenController.mm

@@ -472 +472 @@
 {
     NSRect initialWindowFrame;
+    if (!NSWidth(initialFrame) || !NSWidth(finalFrame) || !NSHeight(initialFrame) || !NSHeight(finalFrame))
+        return screenFrame;
+
     CGFloat xScale = NSWidth(screenFrame) / NSWidth(finalFrame);
     CGFloat yScale = NSHeight(screenFrame) / NSHeight(finalFrame);

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-05-02  Jer Noble  <jer.noble@apple.com>
+
+        Taking a visibility:hidden element full screen causes full screen window to disappear.
+        https://bugs.webkit.org/show_bug.cgi?id=85432
+
+        Reviewed by Maciej Stachowiak.
+
+        When given an initial or final frame with a zero width or height, return a rect representing
+        the entire screen, rather than a rect with a zero or infinite size. Doing otherwise will
+        confuse the window server when it's instructed to scale the full screen window to that size.
+
+        * UIProcess/mac/WKFullScreenWindowController.mm:
+        (windowFrameFromApparentFrames):
+
 2012-04-30  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm

@@ -469 +469 @@
 {
     NSRect initialWindowFrame;
+    if (!NSWidth(initialFrame) || !NSWidth(finalFrame) || !NSHeight(initialFrame) || !NSHeight(finalFrame))
+        return screenFrame;
+
     CGFloat xScale = NSWidth(screenFrame) / NSWidth(finalFrame);
     CGFloat yScale = NSHeight(screenFrame) / NSHeight(finalFrame);