Changeset 116241 in webkit


Ignore:
Timestamp:
May 6, 2012 3:05:38 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[BlackBerry] Enable credential persistance and auto fill
https://bugs.webkit.org/show_bug.cgi?id=85572

Patch by Jonathan Dong <Jonathan Dong> on 2012-05-06
Reviewed by Rob Buis.

.:

Enable credential persistance and auto fill feature by adding
ENABLE_BLACKBERRY_CREDENTIAL_PERSIST=1.

  • Source/cmake/OptionsBlackBerry.cmake:

Source/WebKit/blackberry:

Set autofilled status of credential input fields when credential
information is auto filled by CredentialManager.
By doing this the input element will get painted with yellow background
which can notify user this input field is auto filled by the browser.

No behavior changes, so no new test.

  • WebCoreSupport/CredentialTransformData.cpp:

(WebCore::CredentialTransformData::setCredential):

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/ChangeLog

    r116228 r116241  
     12012-05-06  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
     2
     3        [BlackBerry] Enable credential persistance and auto fill
     4        https://bugs.webkit.org/show_bug.cgi?id=85572
     5
     6        Reviewed by Rob Buis.
     7
     8        Enable credential persistance and auto fill feature by adding
     9        ENABLE_BLACKBERRY_CREDENTIAL_PERSIST=1.
     10
     11        * Source/cmake/OptionsBlackBerry.cmake:
     12
    1132012-05-05  Gustavo Noronha Silva  <gns@gnome.org>
    214
  • trunk/Source/WebKit/blackberry/ChangeLog

    r116199 r116241  
     12012-05-06  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
     2
     3        [BlackBerry] Enable credential persistance and auto fill
     4        https://bugs.webkit.org/show_bug.cgi?id=85572
     5
     6        Reviewed by Rob Buis.
     7
     8        Set autofilled status of credential input fields when credential
     9        information is auto filled by CredentialManager.
     10        By doing this the input element will get painted with yellow background
     11        which can notify user this input field is auto filled by the browser.
     12
     13        No behavior changes, so no new test.
     14
     15        * WebCoreSupport/CredentialTransformData.cpp:
     16        (WebCore::CredentialTransformData::setCredential):
     17
    1182012-05-04  Andrew Lo  <anlo@rim.com>
    219
  • trunk/Source/WebKit/blackberry/WebCoreSupport/CredentialTransformData.cpp

    r109698 r116241  
    171171    m_credential = credential;
    172172    m_userNameElement->setValue(credential.user());
     173    m_userNameElement->setAutofilled();
    173174    m_passwordElement->setValue(credential.password());
     175    m_passwordElement->setAutofilled();
    174176}
    175177
  • trunk/Source/cmake/OptionsBlackBerry.cmake

    r115666 r116241  
    174174WEBKIT_OPTION_END()
    175175
     176ADD_DEFINITIONS(-DENABLE_BLACKBERRY_CREDENTIAL_PERSIST=1)
     177
    176178# Some of our files, such as platform/graphics/chromium/ComplexTextControllerLinux.cpp, require a
    177179# newer ICU version than the version associated with the headers in {WebCore, JavaScriptCore}/icu.
Note: See TracChangeset for help on using the changeset viewer.