Changeset 116250 in webkit

Timestamp:

May 6, 2012 4:28:20 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation
​https://bugs.webkit.org/show_bug.cgi?id=83687

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-05-06
Reviewed by Antonio Gomes.

Source/WebKit/efl:

• ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_scripts_can_access_clipboard_get):
(ewk_view_setting_scripts_can_access_clipboard_set):

• ewk/ewk_view.h:

Tools:

• DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setJavaScriptCanAccessClipboard):

LayoutTests:

• platform/efl/Skipped:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/efl/Skipped (modified) (1 diff)
• Source/WebKit/efl/ChangeLog (modified) (1 diff)
• Source/WebKit/efl/ewk/ewk_view.cpp (modified) (3 diffs)
• Source/WebKit/efl/ewk/ewk_view.h (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
+
+        [EFL] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation
+        https://bugs.webkit.org/show_bug.cgi?id=83687
+
+        Reviewed by Antonio Gomes.
+
+        * platform/efl/Skipped:
+
 2012-05-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 

trunk/LayoutTests/platform/efl/Skipped

@@ -314 +314 @@
 plugins/netscape-plugin-setwindow-size-2.html
 
-# EFL's LayoutTestController does not implement setJavaScriptCanAccessClipboard
-editing/execCommand/clipboard-access.html
 
 # EFL's LayoutTestController does not implement setAllowUniversalAccessFromFileURLs

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2012-05-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
+
+        [EFL] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation
+        https://bugs.webkit.org/show_bug.cgi?id=83687
+
+        Reviewed by Antonio Gomes.
+
+        * ewk/ewk_view.cpp:
+        (_Ewk_View_Private_Data):
+        (_ewk_view_priv_new):
+        (ewk_view_setting_scripts_can_access_clipboard_get):
+        (ewk_view_setting_scripts_can_access_clipboard_set):
+        * ewk/ewk_view.h:
+
 2012-05-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 

trunk/Source/WebKit/efl/ewk/ewk_view.cpp

@@ -218 +218 @@
         bool shouldDisplayTextDescriptions: 1;
 #endif
+        bool scriptsCanAccessClipboard : 1;
         bool resizableTextareas : 1;
         bool privateBrowsing : 1;
@@ -739 +740 @@
     priv->settings.shouldDisplayTextDescriptions = priv->pageSettings->shouldDisplayTextDescriptions();
 #endif
+    priv->settings.scriptsCanAccessClipboard = priv->pageSettings->javaScriptCanAccessClipboard();
     priv->settings.resizableTextareas = priv->pageSettings->textAreasAreResizable();
     priv->settings.privateBrowsing = priv->pageSettings->privateBrowsingEnabled();
@@ -2102 +2104 @@
         priv->pageSettings->setAllowScriptsToCloseWindows(allow);
         priv->settings.scriptsCanCloseWindows = allow;
+    }
+    return true;
+}
+
+Eina_Bool ewk_view_setting_scripts_can_access_clipboard_get(const Evas_Object* ewkView)
+{
+    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, false);
+    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, false);
+    return priv->settings.scriptsCanAccessClipboard;
+}
+
+Eina_Bool ewk_view_setting_scripts_can_access_clipboard_set(Evas_Object* ewkView, Eina_Bool allow)
+{
+    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, false);
+    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, false);
+    allow = !!allow;
+    if (priv->settings.scriptsCanAccessClipboard != allow) {
+        priv->pageSettings->setJavaScriptCanAccessClipboard(allow);
+        priv->settings.scriptsCanAccessClipboard = allow;
     }
     return true;

trunk/Source/WebKit/efl/ewk/ewk_view.h

@@ -1556 +1556 @@
 
 /**
+ * Returns whether scripts can access clipboard.
+ *
+ * @param o View whose settings to check.
+ *
+ * @return @c EINA_TRUE if scripts can access clipboard, @c EINA_FALSE otherwise.
+ */
+EAPI Eina_Bool    ewk_view_setting_scripts_can_access_clipboard_get(const Evas_Object *o);
+
+/**
+ * Sets whether scripts are allowed to access clipboard.
+ *
+ * @param o View whose settings to change.
+ * @param allow @c EINA_TRUE to allow scripts access clipboard,
+ *              @c EINA_FALSE otherwise.
+ *
+ * @return @c EINA_TRUE if the setting could be changed successfully,
+ *         @c EINA_FALSE in case an error occurred.
+ */
+EAPI Eina_Bool    ewk_view_setting_scripts_can_access_clipboard_set(Evas_Object *o, Eina_Bool allow);
+
+/**
  * Queries if HTML elements @c textarea can be resizable.
  *

trunk/Tools/ChangeLog

@@ +1 @@
+2012-05-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
+
+        [EFL] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation
+        https://bugs.webkit.org/show_bug.cgi?id=83687
+
+        Reviewed by Antonio Gomes.
+
+        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+        (LayoutTestController::setJavaScriptCanAccessClipboard):
+
 2012-05-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 

trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp

@@ -328 +328 @@
 }
 
-void LayoutTestController::setJavaScriptCanAccessClipboard(bool)
-{
-    notImplemented();
+void LayoutTestController::setJavaScriptCanAccessClipboard(bool flag)
+{
+    ewk_view_setting_scripts_can_access_clipboard_set(browser->mainView(), flag);
 }