Changeset 116293 in webkit


Ignore:
Timestamp:
May 7, 2012 3:30:14 AM (12 years ago)
Author:
apavlov@chromium.org
Message:

Web Inspector: [REGRESSION] Context menu for the left Script view gutter is broken
https://bugs.webkit.org/show_bug.cgi?id=85785

Reviewed by Pavel Feldman.

Fixed remaining usages of WebInspector.save to be WebInspector.fileManager.save.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._exportAll):
(WebInspector.NetworkLogView.prototype._exportRequest):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction.doSave):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent.doSave):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._contextMenu):

Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r116291 r116293  
     12012-05-07  Alexander Pavlov  <apavlov@chromium.org>
     2
     3        Web Inspector: [REGRESSION] Context menu for the left Script view gutter is broken
     4        https://bugs.webkit.org/show_bug.cgi?id=85785
     5
     6        Reviewed by Pavel Feldman.
     7
     8        Fixed remaining usages of WebInspector.save to be WebInspector.fileManager.save.
     9
     10        * inspector/front-end/NetworkPanel.js:
     11        (WebInspector.NetworkLogView.prototype._exportAll):
     12        (WebInspector.NetworkLogView.prototype._exportRequest):
     13        * inspector/front-end/ResourcesPanel.js:
     14        (WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction.doSave):
     15        (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent.doSave):
     16        * inspector/front-end/TextViewer.js:
     17        (WebInspector.TextViewer.prototype._contextMenu):
     18
    119
    2202012-05-07  Antti Koivisto  <antti@apple.com>
  • trunk/Source/WebCore/inspector/front-end/NetworkPanel.js

    r115194 r116293  
    10011001        };
    10021002       
    1003         WebInspector.save(WebInspector.inspectedPageDomain + ".har", JSON.stringify(harArchive, null, 2), true);
     1003        WebInspector.fileManager.save(WebInspector.inspectedPageDomain + ".har", JSON.stringify(harArchive, null, 2), true);
    10041004    },
    10051005
     
    10071007    {
    10081008        var har = (new WebInspector.HAREntry(request)).build();
    1009         WebInspector.save(request.displayName + ".har", JSON.stringify(har, null, 2), true);
     1009        WebInspector.fileManager.save(request.displayName + ".har", JSON.stringify(har, null, 2), true);
    10101010    },
    10111011
  • trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js

    r114117 r116293  
    12791279        function doSave(forceSaveAs, content)
    12801280        {
    1281             WebInspector.save(this._resource.url, content, forceSaveAs);
     1281            WebInspector.fileManager.save(this._resource.url, content, forceSaveAs);
    12821282        }
    12831283
     
    20502050            function doSave(forceSaveAs, content)
    20512051            {
    2052                 WebInspector.save(this._revision.resource.url, content, forceSaveAs);
     2052                WebInspector.fileManager.save(this._revision.resource.url, content, forceSaveAs);
    20532053            }
    20542054
  • trunk/Source/WebCore/inspector/front-end/TextViewer.js

    r116222 r116293  
    292292        }
    293293        if (this._url) {
    294             contextMenu.appendItem(WebInspector.UIString("Save"), WebInspector.save.bind(WebInspector, this._url, this._textModel.text, false));
    295             contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Save as..." : "Save As..."), WebInspector.save.bind(WebInspector, this._url, this._textModel.text, true));
     294            contextMenu.appendItem(WebInspector.UIString("Save"), WebInspector.fileManager.save.bind(WebInspector, this._url, this._textModel.text, false));
     295            contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Save as..." : "Save As..."), WebInspector.fileManager.save.bind(WebInspector, this._url, this._textModel.text, true));
    296296        }
    297297
Note: See TracChangeset for help on using the changeset viewer.