Changeset 116308 in webkit


Ignore:
Timestamp:
May 7, 2012 7:32:32 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[BlackBerry] WWW-Authenticate header on 200 response pops up authentication dialog
https://bugs.webkit.org/show_bug.cgi?id=85643

Patch by Liam Quinn <lquinn@rim.com> on 2012-05-07
Reviewed by George Staikos.

.:

RIM PR: 151992
Added manual test for WWW-Authenticate header on a 200 response.

  • ManualTests/blackberry/http-auth-on-200.php: Added.

Source/WebCore:

RIM PR: 151992
Ignore WWW-Authenticate header if the response code is not 401.
Ignore Proxy-Authenticate header if the response code is not 407.

Manual test added to observe whether the authentication dialog appears on a 200 response with WWW-Authenticate.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyHeaderReceived):

Location:
trunk
Files:
1 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/ChangeLog

    r116286 r116308  
     12012-05-07  Liam Quinn  <lquinn@rim.com>
     2
     3        [BlackBerry] WWW-Authenticate header on 200 response pops up authentication dialog
     4        https://bugs.webkit.org/show_bug.cgi?id=85643
     5
     6        Reviewed by George Staikos.
     7
     8        RIM PR: 151992
     9        Added manual test for WWW-Authenticate header on a 200 response.
     10
     11        * ManualTests/blackberry/http-auth-on-200.php: Added.
     12
    1132012-05-07  Simon Hausmann  <simon.hausmann@nokia.com>
    214
  • trunk/Source/WebCore/ChangeLog

    r116305 r116308  
     12012-05-07  Liam Quinn  <lquinn@rim.com>
     2
     3        [BlackBerry] WWW-Authenticate header on 200 response pops up authentication dialog
     4        https://bugs.webkit.org/show_bug.cgi?id=85643
     5
     6        Reviewed by George Staikos.
     7
     8        RIM PR: 151992
     9        Ignore WWW-Authenticate header if the response code is not 401.
     10        Ignore Proxy-Authenticate header if the response code is not 407.
     11
     12        Manual test added to observe whether the authentication dialog appears on a 200 response with WWW-Authenticate.
     13
     14        * platform/network/blackberry/NetworkJob.cpp:
     15        (WebCore::NetworkJob::handleNotifyHeaderReceived):
     16
    1172012-05-07  Alexander Pavlov  <apavlov@chromium.org>
    218
  • trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp

    r116265 r116308  
    315315            return;
    316316        }
    317     } else if (lowerKey == "www-authenticate")
     317    } else if (m_extendedStatusCode == 401 && lowerKey == "www-authenticate")
    318318        handleAuthHeader(ProtectionSpaceServerHTTP, value);
    319     else if (lowerKey == "proxy-authenticate" && !BlackBerry::Platform::Client::get()->getProxyAddress().empty())
     319    else if (m_extendedStatusCode == 407 && lowerKey == "proxy-authenticate" && !BlackBerry::Platform::Client::get()->getProxyAddress().empty())
    320320        handleAuthHeader(ProtectionSpaceProxyHTTP, value);
    321321    else if (equalIgnoringCase(key, BlackBerry::Platform::NetworkRequest::HEADER_BLACKBERRY_FTP))
Note: See TracChangeset for help on using the changeset viewer.