Changeset 116333 in webkit

Timestamp:

May 7, 2012 11:54:48 AM (12 years ago)

Author:

jsbell@chromium.org

Message:

IndexedDB: LevelDB coding for bools is broken
​https://bugs.webkit.org/show_bug.cgi?id=85810

Reviewed by Tony Chang.

Source/WebCore:

Code was appending to a pre-sized Vector, rather than using an
index setter. This caused uninitialized data to be written out.
Issue was detected on the Chromium side in ​http://crbug.com/126388

Tests: webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.*codeBool'

• Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeBool):

Source/WebKit/chromium:

Added tests for encodeBool/decodeBool.

• tests/IDBLevelDBCodingTest.cpp:

(IDBLevelDBCoding::TEST):
(IDBLevelDBCoding):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp (modified) (1 diff)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/tests/IDBLevelDBCodingTest.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-07  Joshua Bell  <jsbell@chromium.org>
+
+        IndexedDB: LevelDB coding for bools is broken
+        https://bugs.webkit.org/show_bug.cgi?id=85810
+
+        Reviewed by Tony Chang.
+
+        Code was appending to a pre-sized Vector, rather than using an
+        index setter. This caused uninitialized data to be written out.
+        Issue was detected on the Chromium side in http://crbug.com/126388
+
+        Tests: webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.*codeBool'
+
+        * Modules/indexeddb/IDBLevelDBCoding.cpp:
+        (WebCore::IDBLevelDBCoding::encodeBool):
+
 2012-05-07  Shawn Singh  <shawnsingh@chromium.org>
 

trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp

@@ -181 +181 @@
 {
     Vector<char> ret(1);
-    ret.append(b ? 1 : 0);
+    ret[0] = b ? 1 : 0;
     return ret;
 }

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2012-05-07  Joshua Bell  <jsbell@chromium.org>
+
+        IndexedDB: LevelDB coding for bools is broken
+        https://bugs.webkit.org/show_bug.cgi?id=85810
+
+        Reviewed by Tony Chang.
+
+        Added tests for encodeBool/decodeBool.
+
+        * tests/IDBLevelDBCodingTest.cpp:
+        (IDBLevelDBCoding::TEST):
+        (IDBLevelDBCoding):
+
 2012-05-07  Shawn Singh  <shawnsingh@chromium.org>
 

trunk/Source/WebKit/chromium/tests/IDBLevelDBCodingTest.cpp

@@ -84 +84 @@
 }
 
+TEST(IDBLevelDBCodingTest, EncodeBool)
+{
+    {
+        Vector<char> expected;
+        expected.append(1);
+        EXPECT_EQ(expected, encodeBool(true));
+    }
+    {
+        Vector<char> expected;
+        expected.append(0);
+        EXPECT_EQ(expected, encodeBool(false));
+    }
+}
+
 TEST(IDBLevelDBCodingTest, MaxIDBKey)
 {
@@ -125 +139 @@
     EXPECT_EQ(static_cast<size_t>(2), encodeInt(256).size());
     EXPECT_EQ(static_cast<size_t>(4), encodeInt(0xffffffff).size());
+}
+
+TEST(IDBLevelDBCodingTest, DecodeBool)
+{
+    {
+        Vector<char> encoded;
+        encoded.append(1);
+        EXPECT_TRUE(decodeBool(encoded.data(), encoded.data() + encoded.size()));
+    }
+    {
+        Vector<char> encoded;
+        encoded.append(0);
+        EXPECT_FALSE(decodeBool(encoded.data(), encoded.data() + encoded.size()));
+    }
 }