Changeset 116343 in webkit

Timestamp:

May 7, 2012 1:16:54 PM (12 years ago)

Author:

rwlbuis@webkit.org

Message:

Shrink SVGInlineTextBox object size
​https://bugs.webkit.org/show_bug.cgi?id=85805

Reviewed by Darin Adler.

Reduce the object size of SVGInlineTextBox by using bitfields. This
should be 4 bytes on 32-bits and 8 bytes on 64-bits systems.

• rendering/svg/RenderSVGResource.h:
• rendering/svg/SVGInlineTextBox.cpp:

(ExpectedSVGInlineTextBoxSize):
(WebCore):

• rendering/svg/SVGInlineTextBox.h:

(SVGInlineTextBox):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/svg/RenderSVGResource.h (modified) (1 diff)
• rendering/svg/SVGInlineTextBox.cpp (modified) (1 diff)
• rendering/svg/SVGInlineTextBox.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-07  Rob Buis  <rbuis@rim.com>
+
+        Shrink SVGInlineTextBox object size
+        https://bugs.webkit.org/show_bug.cgi?id=85805
+
+        Reviewed by Darin Adler.
+
+        Reduce the object size of SVGInlineTextBox by using bitfields. This
+        should be 4 bytes on 32-bits and 8 bytes on 64-bits systems.
+
+        * rendering/svg/RenderSVGResource.h:
+        * rendering/svg/SVGInlineTextBox.cpp:
+        (ExpectedSVGInlineTextBoxSize):
+        (WebCore):
+        * rendering/svg/SVGInlineTextBox.h:
+        (SVGInlineTextBox):
+
 2012-05-07  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/rendering/svg/RenderSVGResource.h

@@ -39 +39 @@
 };
 
+// If this enum changes change the unsigned bitfields using it.
 enum RenderSVGResourceMode {
     ApplyToDefaultMode = 1 << 0, // used for all resources except gradient/pattern

trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp

@@ -45 +45 @@
 namespace WebCore {
 
+class ExpectedSVGInlineTextBoxSize : public InlineTextBox {
+    float float1;
+    uint32_t bitfields : 5;
+    void* pointer;
+    Vector<SVGTextFragment> vector;
+};
+
+COMPILE_ASSERT(sizeof(SVGInlineTextBox) == sizeof(ExpectedSVGInlineTextBoxSize), SVGInlineTextBox_is_not_of_expected_size);
+
 SVGInlineTextBox::SVGInlineTextBox(RenderObject* object)
     : InlineTextBox(object)

trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.h

@@ -84 +84 @@
 private:
     float m_logicalHeight;
-    int m_paintingResourceMode;
-    bool m_startsNewTextChunk : 1;
+    unsigned m_paintingResourceMode : 4;
+    unsigned m_startsNewTextChunk : 1;
     RenderSVGResource* m_paintingResource;
     Vector<SVGTextFragment> m_textFragments;