Changeset 116394 in webkit

Timestamp:

May 7, 2012 10:14:07 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Fix signed/unsigned mismatch
​https://bugs.webkit.org/show_bug.cgi?id=85845

Make literal in assert be unsigned to match comparison on LHS. Avoids
warning on Windows.

Patch by Scott Graham <​scottmg@chromium.org> on 2012-05-07
Reviewed by Eric Seidel.

No new tests. No intended functionality change.

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::splitColumn):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderTableSection.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-07  Scott Graham  <scottmg@chromium.org>
+
+        Fix signed/unsigned mismatch
+        https://bugs.webkit.org/show_bug.cgi?id=85845
+
+        Make literal in assert be unsigned to match comparison on LHS. Avoids
+        warning on Windows.
+
+        Reviewed by Eric Seidel.
+
+        No new tests. No intended functionality change.
+
+        * rendering/RenderTableSection.cpp:
+        (WebCore::RenderTableSection::splitColumn):
+
 2012-05-07  Emil A Eklund  <eae@chromium.org>
 

trunk/Source/WebCore/rendering/RenderTableSection.cpp

@@ -1295 +1295 @@
             RenderTableCell* cell = r[pos].primaryCell();
             ASSERT(cell);
-            ASSERT(cell->colSpan() >= (r[pos].inColSpan ? 1 : 0));
+            ASSERT(cell->colSpan() >= (r[pos].inColSpan ? 1u : 0));
             unsigned colleft = cell->colSpan() - r[pos].inColSpan;
             if (first > colleft)