Changeset 116450 in webkit


Ignore:
Timestamp:
May 8, 2012 12:36:34 PM (12 years ago)
Author:
ryuan.choi@samsung.com
Message:

[EFL][DRT]Do not create ScrollbarEfl when mockScrollbar is enabled.
https://bugs.webkit.org/show_bug.cgi?id=81315

Reviewed by Chang Shu.

ScrollbarEfl creates custom scrollbars as separated layer and they are
not related to ScrollbarTheme.
So, DRT/Efl creates custom scrollbars on webview which paints mockScrollbar.

This patch prevents creating custom scrollbars when mockScrollbar is enabled.

Because DRT/Efl only renders the webview now, expected results are same
until Bug 79853 is landed.

  • platform/efl/ScrollbarEfl.cpp:

(Scrollbar::createNativeScrollbar):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r116449 r116450  
     12012-05-08  Ryuan Choi  <ryuan.choi@samsung.com>
     2
     3        [EFL][DRT]Do not create ScrollbarEfl when mockScrollbar is enabled.
     4        https://bugs.webkit.org/show_bug.cgi?id=81315
     5
     6        Reviewed by Chang Shu.
     7
     8        ScrollbarEfl creates custom scrollbars as separated layer and they are
     9        not related to ScrollbarTheme.
     10        So, DRT/Efl creates custom scrollbars on webview which paints mockScrollbar.
     11
     12        This patch prevents creating custom scrollbars when mockScrollbar is enabled.
     13
     14        Because DRT/Efl only renders the webview now, expected results are same
     15        until Bug 79853 is landed.
     16
     17        * platform/efl/ScrollbarEfl.cpp:
     18        (Scrollbar::createNativeScrollbar):
     19
    1202012-05-08  Timothy Hatcher  <timothy@apple.com>
    221
  • trunk/Source/WebCore/platform/efl/ScrollbarEfl.cpp

    r104163 r116450  
    3030#include "HostWindow.h"
    3131#include "IntRect.h"
    32 #include "NotImplemented.h"
    3332#include "Page.h"
    3433#include "ScrollbarTheme.h"
     34#include "Settings.h"
    3535
    3636#include <Ecore.h>
     
    4545PassRefPtr<Scrollbar> Scrollbar::createNativeScrollbar(ScrollableArea* scrollableArea, ScrollbarOrientation orientation, ScrollbarControlSize size)
    4646{
     47    if (Settings::mockScrollbarsEnabled())
     48        return adoptRef(new Scrollbar(scrollableArea, orientation, size));
     49
    4750    return adoptRef(new ScrollbarEfl(scrollableArea, orientation, size));
    4851}
Note: See TracChangeset for help on using the changeset viewer.