Changeset 116521 in webkit
- Timestamp:
- May 9, 2012 5:53:42 AM (12 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 8 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r116519 r116521 1 2012-05-09 Takashi Sakamoto <tasak@google.com> 2 3 ShadowRoot needs applyAuthorStyles 4 https://bugs.webkit.org/show_bug.cgi?id=78472 5 6 Reviewed by Hajime Morita. 7 8 * fast/dom/shadow/shadow-root-applyAuthorStyles.html: 9 * fast/dom/shadow/shadow-root-applyAuthorStyles-expected.html: 10 Tested four cases: 11 case 1: applyAuthorStyles is false, 12 case 2: applyAuthorStyles is true with <script>..</script>, 13 case 3: applyAuthorStyles is true with inline script declaration, and 14 case 4: applyAuthorStyles is true with important UA property. 15 The case 1, 2 and 3 specify "span { ... }" with author styles and 16 verify rendering results. 17 The case 4 specifies '<input type="file" />' with an author style, 18 text-align: end, and verify rendering result. 19 1 20 2012-05-09 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> 2 21 -
trunk/Source/WebCore/ChangeLog
r116513 r116521 1 2012-05-09 Takashi Sakamoto <tasak@google.com> 2 3 ShadowRoot needs applyAuthorStyles 4 https://bugs.webkit.org/show_bug.cgi?id=78472 5 6 Reviewed by Hajime Morita. 7 8 Implemented applyAuthorStyles attribute defined in the following spec: 9 http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#shadow-root-attributes 10 Since applyAuthorSheets attribute has been already implemented, 11 renamed all applyAuthorSheets to applyAuthorStyles and 12 added applyAuthorStyles to ShadowRoot.idl. 13 Currently, changing dynamically applyAuthorStyles doesn't work. I will fix this isse in bugs:84215: https://bugs.webkit.org/show_bug.cgi?id=84251 14 15 Test: fast/dom/shadow/shadow-root-applyAuthorStyles.html 16 fast/dom/shadow/shadow-root-applyAuthorStyles-expected.html 17 18 * css/StyleResolver.cpp: 19 (WebCore::StyleResolver::collectMatchingRulesForList): 20 * dom/ShadowRoot.cpp: 21 (WebCore::ShadowRoot::ShadowRoot): 22 (WebCore::ShadowRoot::applyAuthorStyles): 23 (WebCore::ShadowRoot::setApplyAuthorStyles): 24 * dom/ShadowRoot.h: 25 * dom/TreeScope.cpp: 26 (WebCore::TreeScope::applyAuthorStyles): 27 * dom/TreeScope.h: 28 (TreeScope): 29 Changed all applyAuthorSheets to applyAuthorSytles. 30 (ShadowRoot): 31 * dom/ShadowRoot.idl: 32 Added a new attribute, boolean applyAuthorStyles. 33 1 34 2012-05-09 Yoshifumi Inoue <yosin@chromium.org> 2 35 -
trunk/Source/WebCore/css/StyleResolver.cpp
r116471 r116521 1039 1039 TreeScope* treeScope = m_element->treeScope(); 1040 1040 if (!MatchingUARulesScope::isMatchingUARules() 1041 && !treeScope->applyAuthorS heets()1041 && !treeScope->applyAuthorStyles() 1042 1042 #if ENABLE(STYLE_SCOPED) 1043 1043 && (!options.scope || options.scope->treeScope() != treeScope) -
trunk/Source/WebCore/dom/ShadowRoot.cpp
r116277 r116521 50 50 , m_prev(0) 51 51 , m_next(0) 52 , m_applyAuthorS heets(false)52 , m_applyAuthorStyles(false) 53 53 , m_insertionPointAssignedTo(0) 54 54 { … … 189 189 } 190 190 191 bool ShadowRoot::applyAuthorS heets() const192 { 193 return m_applyAuthorS heets;194 } 195 196 void ShadowRoot::setApplyAuthorS heets(bool value)197 { 198 m_applyAuthorS heets = value;191 bool ShadowRoot::applyAuthorStyles() const 192 { 193 return m_applyAuthorStyles; 194 } 195 196 void ShadowRoot::setApplyAuthorStyles(bool value) 197 { 198 m_applyAuthorStyles = value; 199 199 } 200 200 -
trunk/Source/WebCore/dom/ShadowRoot.h
r116277 r116521 68 68 void hostChildrenChanged(); 69 69 70 virtual bool applyAuthorS heets() const;71 void setApplyAuthorS heets(bool);70 virtual bool applyAuthorStyles() const OVERRIDE; 71 void setApplyAuthorStyles(bool); 72 72 73 73 Element* host() const { return shadowHost(); } … … 105 105 ShadowRoot* m_prev; 106 106 ShadowRoot* m_next; 107 bool m_applyAuthorS heets : 1;107 bool m_applyAuthorStyles : 1; 108 108 InsertionPoint* m_insertionPointAssignedTo; 109 109 }; -
trunk/Source/WebCore/dom/ShadowRoot.idl
r113667 r116521 36 36 readonly attribute Element activeElement; 37 37 readonly attribute DOMSelection selection; 38 attribute boolean applyAuthorStyles; 38 39 39 40 attribute [TreatNullAs=NullString] DOMString innerHTML -
trunk/Source/WebCore/dom/TreeScope.cpp
r111672 r116521 140 140 } 141 141 142 bool TreeScope::applyAuthorS heets() const142 bool TreeScope::applyAuthorStyles() const 143 143 { 144 144 return true; -
trunk/Source/WebCore/dom/TreeScope.h
r112978 r116521 70 70 Element* findAnchor(const String& name); 71 71 72 virtual bool applyAuthorS heets() const;72 virtual bool applyAuthorStyles() const; 73 73 74 74 // Used by the basic DOM mutation methods (e.g., appendChild()).
Note: See TracChangeset
for help on using the changeset viewer.