Changeset 116560 in webkit

Timestamp:

May 9, 2012 3:01:09 PM (12 years ago)

Author:

enne@google.com

Message:

Update compositing/RTL tests to fail if the root layer is shifted incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=85820

Reviewed by James Robinson.

For the Chromium port, if the root layer was shifted incorrectly, the
non-composited red indicator layers would get drawn outside the root
layers bounds, making it impossible to see if the test was failing.

Also turn off overflow:hidden because compositing/ tests have mock
scrollbars. This makes it much easier to debug these tests locally.

• compositing/rtl/rtl-absolute-expected.png:
• compositing/rtl/rtl-absolute-overflow-expected.png:
• compositing/rtl/rtl-absolute-overflow-expected.txt:
• compositing/rtl/rtl-absolute-overflow-scrolled-expected.png:
• compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
• compositing/rtl/rtl-absolute-overflow-scrolled.html:
• compositing/rtl/rtl-absolute-overflow.html:
• compositing/rtl/rtl-absolute.html:
• compositing/rtl/rtl-fixed-expected.png:
• compositing/rtl/rtl-fixed-overflow-expected.png:
• compositing/rtl/rtl-fixed-overflow-expected.txt:
• compositing/rtl/rtl-fixed-overflow-scrolled-expected.png:
• compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
• compositing/rtl/rtl-fixed-overflow-scrolled.html:
• compositing/rtl/rtl-fixed-overflow.html:
• compositing/rtl/rtl-fixed.html:
• compositing/rtl/rtl-iframe-absolute-overflow-expected.png:
• compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
• compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png:
• compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
• compositing/rtl/rtl-iframe-fixed-overflow-expected.png:
• compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
• compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png:
• compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• compositing/rtl/rtl-absolute-expected.png (modified) (previous)
• compositing/rtl/rtl-absolute-overflow-expected.png (modified) (previous)
• compositing/rtl/rtl-absolute-overflow-expected.txt (modified) (1 diff)
• compositing/rtl/rtl-absolute-overflow-scrolled-expected.png (modified) (previous)
• compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt (modified) (1 diff)
• compositing/rtl/rtl-absolute-overflow-scrolled.html (modified) (2 diffs)
• compositing/rtl/rtl-absolute-overflow.html (modified) (2 diffs)
• compositing/rtl/rtl-absolute.html (modified) (3 diffs)
• compositing/rtl/rtl-fixed-expected.png (modified) (previous)
• compositing/rtl/rtl-fixed-overflow-expected.png (modified) (previous)
• compositing/rtl/rtl-fixed-overflow-expected.txt (modified) (1 diff)
• compositing/rtl/rtl-fixed-overflow-scrolled-expected.png (modified) (previous)
• compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt (modified) (1 diff)
• compositing/rtl/rtl-fixed-overflow-scrolled.html (modified) (2 diffs)
• compositing/rtl/rtl-fixed-overflow.html (modified) (2 diffs)
• compositing/rtl/rtl-fixed.html (modified) (3 diffs)
• compositing/rtl/rtl-iframe-absolute-overflow-expected.png (modified) (previous)
• compositing/rtl/rtl-iframe-absolute-overflow-expected.txt (modified) (2 diffs)
• compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png (modified) (previous)
• compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt (modified) (2 diffs)
• compositing/rtl/rtl-iframe-fixed-overflow-expected.png (modified) (previous)
• compositing/rtl/rtl-iframe-fixed-overflow-expected.txt (modified) (2 diffs)
• compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png (modified) (previous)
• compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-09  Adrienne Walker  <enne@google.com>
+
+        Update compositing/RTL tests to fail if the root layer is shifted incorrectly
+        https://bugs.webkit.org/show_bug.cgi?id=85820
+
+        Reviewed by James Robinson.
+
+        For the Chromium port, if the root layer was shifted incorrectly, the
+        non-composited red indicator layers would get drawn outside the root
+        layers bounds, making it impossible to see if the test was failing.
+
+        Also turn off overflow:hidden because compositing/ tests have mock
+        scrollbars. This makes it much easier to debug these tests locally.
+
+        * compositing/rtl/rtl-absolute-expected.png:
+        * compositing/rtl/rtl-absolute-overflow-expected.png:
+        * compositing/rtl/rtl-absolute-overflow-expected.txt:
+        * compositing/rtl/rtl-absolute-overflow-scrolled-expected.png:
+        * compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
+        * compositing/rtl/rtl-absolute-overflow-scrolled.html:
+        * compositing/rtl/rtl-absolute-overflow.html:
+        * compositing/rtl/rtl-absolute.html:
+        * compositing/rtl/rtl-fixed-expected.png:
+        * compositing/rtl/rtl-fixed-overflow-expected.png:
+        * compositing/rtl/rtl-fixed-overflow-expected.txt:
+        * compositing/rtl/rtl-fixed-overflow-scrolled-expected.png:
+        * compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
+        * compositing/rtl/rtl-fixed-overflow-scrolled.html:
+        * compositing/rtl/rtl-fixed-overflow.html:
+        * compositing/rtl/rtl-fixed.html:
+        * compositing/rtl/rtl-iframe-absolute-overflow-expected.png:
+        * compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
+        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png:
+        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
+        * compositing/rtl/rtl-iframe-fixed-overflow-expected.png:
+        * compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
+        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png:
+        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
+
 2012-05-09  Zan Dobersek  <zandobersek@gmail.com>
 

trunk/LayoutTests/compositing/rtl/rtl-absolute-overflow-expected.txt

@@ -1 +1 @@
 (GraphicsLayer
-  (position -208.00 0.00)
-  (bounds 1008.00 1016.00)
+  (position -215.00 0.00)
+  (bounds 1000.00 1000.00)
   (children 1
     (GraphicsLayer
-      (bounds 1008.00 1016.00)
+      (bounds 1000.00 1000.00)
       (children 1
         (GraphicsLayer
-          (position 258.00 50.00)
+          (position 265.00 50.00)
           (bounds 100.00 100.00)
           (drawsContent 1)

trunk/LayoutTests/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt

@@ -1 +1 @@
 (GraphicsLayer
-  (position -208.00 0.00)
-  (bounds 1008.00 1016.00)
+  (position -215.00 0.00)
+  (bounds 1000.00 1000.00)
   (children 1
     (GraphicsLayer
-      (bounds 1008.00 1016.00)
+      (bounds 1000.00 1000.00)
       (children 1
         (GraphicsLayer

trunk/LayoutTests/compositing/rtl/rtl-absolute-overflow-scrolled.html

@@ -4 +4 @@
     body {
         direction: rtl;
-        overflow: hidden;
+        margin: 0px;
+        background-color: red;
     }
 
@@ -27 +28 @@
         width: 1000px;
         height: 1000px;
+        background-color: white;
     }
 

trunk/LayoutTests/compositing/rtl/rtl-absolute-overflow.html

@@ -4 +4 @@
     body {
         direction: rtl;
-        overflow: hidden;
+        margin: 0px;
+        background-color: red;
     }
 
@@ -27 +28 @@
         width: 1000px;
         height: 1000px;
+        background-color: white;
     }
 

trunk/LayoutTests/compositing/rtl/rtl-absolute.html

@@ -4 +4 @@
     body {
         direction: rtl;
-        overflow: hidden;
+        margin: 0px;
+        background-color: red;
     }
 
@@ -24 +25 @@
     }
 
+    #root {
+        width: 100%;
+        height: 100%;
+        /* root element should exactly cover red background */
+        background-color: white;
+    }
+
     #layertree {
         position: absolute;
@@ -41 +49 @@
 </script>
 <body>
+    <div id="root"></div>
     <div class="positioned indicator"></div>
     <div class="positioned layer"></div>

trunk/LayoutTests/compositing/rtl/rtl-fixed-overflow-expected.txt

@@ -1 +1 @@
 (GraphicsLayer
-  (position -208.00 0.00)
-  (bounds 1008.00 1016.00)
+  (position -215.00 0.00)
+  (bounds 1000.00 1000.00)
   (children 1
     (GraphicsLayer
-      (bounds 1008.00 1016.00)
+      (bounds 1000.00 1000.00)
       (children 1
         (GraphicsLayer
-          (position 258.00 50.00)
+          (position 265.00 50.00)
           (bounds 100.00 100.00)
           (drawsContent 1)

trunk/LayoutTests/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt

@@ -1 +1 @@
 (GraphicsLayer
-  (position -208.00 0.00)
-  (bounds 1008.00 1016.00)
+  (position -215.00 0.00)
+  (bounds 1000.00 1000.00)
   (children 1
     (GraphicsLayer
-      (bounds 1008.00 1016.00)
+      (bounds 1000.00 1000.00)
       (children 1
         (GraphicsLayer

trunk/LayoutTests/compositing/rtl/rtl-fixed-overflow-scrolled.html

@@ -4 +4 @@
     body {
         direction: rtl;
-        overflow: hidden;
+        margin: 0px;
+        background-color: red;
     }
 
@@ -27 +28 @@
         width: 1000px;
         height: 1000px;
+        background-color: white;
     }
 

trunk/LayoutTests/compositing/rtl/rtl-fixed-overflow.html

@@ -4 +4 @@
     body {
         direction: rtl;
-        overflow: hidden;
+        margin: 0px;
+        background-color: red;
     }
 
@@ -27 +28 @@
         width: 1000px;
         height: 1000px;
+        background-color: white;
     }
 

trunk/LayoutTests/compositing/rtl/rtl-fixed.html

@@ -4 +4 @@
     body {
         direction: rtl;
-        overflow: hidden;
+        margin: 0px;
+        background-color: red;
     }
 
@@ -24 +25 @@
     }
 
+    #root {
+        width: 100%;
+        height: 100%;
+        background-color: white;
+    }
+
     #layertree {
         position: absolute;
@@ -41 +48 @@
 </script>
 <body>
+    <div id="root"></div>
     <div class="positioned indicator"></div>
     <div class="positioned layer"></div>

trunk/LayoutTests/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt

@@ -10 +10 @@
           (children 1
             (GraphicsLayer
-              (children 1
+              (children 4
                 (GraphicsLayer
-                  (bounds 400.00 400.00)
+                  (bounds 385.00 385.00)
                   (children 1
                     (GraphicsLayer
                       (children 1
                         (GraphicsLayer
-                          (position -608.00 0.00)
-                          (bounds 1008.00 1016.00)
+                          (position -615.00 0.00)
+                          (bounds 1000.00 1000.00)
                           (children 1
                             (GraphicsLayer
-                              (bounds 1008.00 1016.00)
+                              (bounds 1000.00 1000.00)
                               (drawsContent 1)
                               (children 1
                                 (GraphicsLayer
-                                  (position 658.00 50.00)
+                                  (position 665.00 50.00)
                                   (bounds 100.00 100.00)
                                   (drawsContent 1)
@@ -37 +37 @@
                   )
                 )
+                (GraphicsLayer
+                  (position 385.00 0.00)
+                  (bounds 15.00 385.00)
+                  (drawsContent 1)
+                )
+                (GraphicsLayer
+                  (position 0.00 385.00)
+                  (bounds 385.00 15.00)
+                  (drawsContent 1)
+                )
+                (GraphicsLayer
+                  (position 385.00 385.00)
+                  (bounds 15.00 15.00)
+                  (drawsContent 1)
+                )
               )
             )

trunk/LayoutTests/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt

@@ -10 +10 @@
           (children 1
             (GraphicsLayer
-              (children 1
+              (children 4
                 (GraphicsLayer
-                  (bounds 400.00 400.00)
+                  (bounds 385.00 385.00)
                   (children 1
                     (GraphicsLayer
                       (children 1
                         (GraphicsLayer
-                          (position -608.00 0.00)
-                          (bounds 1008.00 1016.00)
+                          (position -615.00 0.00)
+                          (bounds 1000.00 1000.00)
                           (children 1
                             (GraphicsLayer
-                              (bounds 1008.00 1016.00)
+                              (bounds 1000.00 1000.00)
                               (drawsContent 1)
                               (children 1
@@ -37 +37 @@
                   )
                 )
+                (GraphicsLayer
+                  (position 385.00 0.00)
+                  (bounds 15.00 385.00)
+                  (drawsContent 1)
+                )
+                (GraphicsLayer
+                  (position 0.00 385.00)
+                  (bounds 385.00 15.00)
+                  (drawsContent 1)
+                )
+                (GraphicsLayer
+                  (position 385.00 385.00)
+                  (bounds 15.00 15.00)
+                  (drawsContent 1)
+                )
               )
             )

trunk/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt

@@ -10 +10 @@
           (children 1
             (GraphicsLayer
-              (children 1
+              (children 4
                 (GraphicsLayer
-                  (bounds 400.00 400.00)
+                  (bounds 385.00 385.00)
                   (children 1
                     (GraphicsLayer
                       (children 1
                         (GraphicsLayer
-                          (position -608.00 0.00)
-                          (bounds 1008.00 1016.00)
+                          (position -615.00 0.00)
+                          (bounds 1000.00 1000.00)
                           (children 1
                             (GraphicsLayer
-                              (bounds 1008.00 1016.00)
+                              (bounds 1000.00 1000.00)
                               (drawsContent 1)
                               (children 1
                                 (GraphicsLayer
-                                  (position 658.00 50.00)
+                                  (position 665.00 50.00)
                                   (bounds 100.00 100.00)
                                   (drawsContent 1)
@@ -37 +37 @@
                   )
                 )
+                (GraphicsLayer
+                  (position 385.00 0.00)
+                  (bounds 15.00 385.00)
+                  (drawsContent 1)
+                )
+                (GraphicsLayer
+                  (position 0.00 385.00)
+                  (bounds 385.00 15.00)
+                  (drawsContent 1)
+                )
+                (GraphicsLayer
+                  (position 385.00 385.00)
+                  (bounds 15.00 15.00)
+                  (drawsContent 1)
+                )
               )
             )

trunk/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt

@@ -10 +10 @@
           (children 1
             (GraphicsLayer
-              (children 1
+              (children 4
                 (GraphicsLayer
-                  (bounds 400.00 400.00)
+                  (bounds 385.00 385.00)
                   (children 1
                     (GraphicsLayer
                       (children 1
                         (GraphicsLayer
-                          (position -608.00 0.00)
-                          (bounds 1008.00 1016.00)
+                          (position -615.00 0.00)
+                          (bounds 1000.00 1000.00)
                           (children 1
                             (GraphicsLayer
-                              (bounds 1008.00 1016.00)
+                              (bounds 1000.00 1000.00)
                               (drawsContent 1)
                               (children 1
                                 (GraphicsLayer
-                                  (position 658.00 50.00)
+                                  (position 665.00 50.00)
                                   (bounds 100.00 100.00)
                                   (drawsContent 1)
@@ -37 +37 @@
                   )
                 )
+                (GraphicsLayer
+                  (position 385.00 0.00)
+                  (bounds 15.00 385.00)
+                  (drawsContent 1)
+                )
+                (GraphicsLayer
+                  (position 0.00 385.00)
+                  (bounds 385.00 15.00)
+                  (drawsContent 1)
+                )
+                (GraphicsLayer
+                  (position 385.00 385.00)
+                  (bounds 15.00 15.00)
+                  (drawsContent 1)
+                )
               )
             )