Changeset 116619 in webkit

Timestamp:

May 10, 2012 12:48:10 AM (12 years ago)

Author:

apavlov@chromium.org

Message:

Web Inspector: Autocomplete for CSS property values in the Styles pane behaving incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=85784

Reviewed by Vsevolod Vlasov.

Before executing the number increment/decrement within CSS property value, the current word is checked
for being a valid suggestion for the current property, and if it is, the numeric change is skipped
in favor of the suggested property value switch by a suggest box.

• inspector/front-end/StylesSidebarPane.js:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/StylesSidebarPane.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-10  Alexander Pavlov  <apavlov@chromium.org>
+
+        Web Inspector: Autocomplete for CSS property values in the Styles pane behaving incorrectly
+        https://bugs.webkit.org/show_bug.cgi?id=85784
+
+        Reviewed by Vsevolod Vlasov.
+
+        Before executing the number increment/decrement within CSS property value, the current word is checked
+        for being a valid suggestion for the current property, and if it is, the numeric change is skipped
+        in favor of the suggested property value switch by a suggest box.
+
+        * inspector/front-end/StylesSidebarPane.js:
+
 2012-05-10  Abhishek Arya  <inferno@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js

@@ -2562 +2562 @@
         var wordRange = selectionRange.startContainer.rangeOfWord(selectionRange.startOffset, WebInspector.StylesSidebarPane.StyleValueDelimiters, this._sidebarPane.valueElement);
         var wordString = wordRange.toString();
+        if (this._isValueSuggestion(wordString))
+            return false;
+
         var replacementString;
         var prefix, suffix, number;
@@ -2612 +2615 @@
     },
 
+    _isValueSuggestion: function(word)
+    {
+        if (!word)
+            return false;
+        word = word.toLowerCase();
+        return this._cssCompletions.keySet().hasOwnProperty(word);
+    },
+
     _buildPropertyCompletions: function(textPrompt, wordRange, force, completionsReadyCallback)
     {