Changeset 116633 in webkit


Ignore:
Timestamp:
May 10, 2012 5:28:18 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[EFL] LayoutTestController needs implementation of setTabKeyCyclesThroughElements
​https://bugs.webkit.org/show_bug.cgi?id=82864

Patch by Alexander Shalamov <​alexander.shalamov@intel.com> on 2012-05-10
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

Add missing implementation for setTabKeyCyclesThroughElements to EFL's
DumpRenderTreeSupport.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setTabKeyCyclesThroughElements):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Add missing implementation for setTabKeyCyclesThroughElements to EFL's LayoutTestController
in order to unskip fast/events/keypress-insert-tab.html

  • DumpRenderTree/efl/EventSender.cpp:

(keyDownCallback):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setTabKeyCyclesThroughElements):

LayoutTests:

Unskip fast/events/keypress-insert-tab.html

  • platform/efl/Skipped:
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r116630 r116633  
     12012-05-10  Alexander Shalamov  <alexander.shalamov@intel.com>
     2
     3        [EFL] LayoutTestController needs implementation of setTabKeyCyclesThroughElements
     4        https://bugs.webkit.org/show_bug.cgi?id=82864
     5
     6        Reviewed by Gustavo Noronha Silva.
     7
     8        Unskip fast/events/keypress-insert-tab.html
     9
     10        * platform/efl/Skipped:
     11
    1122012-05-10  Alexander Shalamov  <alexander.shalamov@intel.com>
    213

  • trunk/LayoutTests/platform/efl/Skipped

    r116630 r116633  
    249249editing/selection/selection-background.html
    250250fast/dom/Window/window-onFocus.html
    251 
    252 # EFL's LayoutTestController does not implement setTabKeyCyclesThroughElements
    253 fast/events/keypress-insert-tab.html
    254251
    255252# EFL's LayoutTestController does not implement setUseDashboardCompatibilityMode

  • trunk/Source/WebKit/efl/ChangeLog

    r116625 r116633  
     12012-05-10  Alexander Shalamov  <alexander.shalamov@intel.com>
     2
     3        [EFL] LayoutTestController needs implementation of setTabKeyCyclesThroughElements
     4        https://bugs.webkit.org/show_bug.cgi?id=82864
     5
     6        Reviewed by Gustavo Noronha Silva.
     7
     8        Add missing implementation for setTabKeyCyclesThroughElements to EFL's
     9        DumpRenderTreeSupport.
     10
     11        * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
     12        (DumpRenderTreeSupportEfl::setTabKeyCyclesThroughElements):
     13        * WebCoreSupport/DumpRenderTreeSupportEfl.h:
     14
    1152012-05-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
    216

  • trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp

    r116625 r116633  
    479479}
    480480
     481void DumpRenderTreeSupportEfl::setTabKeyCyclesThroughElements(const Evas_Object* ewkView, bool cycles)
     482{
     483    WebCore::Page* page = EWKPrivate::corePage(ewkView);
     484    if (!page)
     485        return;
     486
     487    page->setTabKeyCyclesThroughElements(cycles);
     488}
     489
    481490void DumpRenderTreeSupportEfl::garbageCollectorCollect()
    482491{

  • trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h

    r116625 r116633  
    8181    static void setSmartInsertDeleteEnabled(Evas_Object* ewkView, bool enabled);
    8282    static void setSelectTrailingWhitespaceEnabled(Evas_Object* ewkView, bool enabled);
     83    static void setTabKeyCyclesThroughElements(const Evas_Object* ewkView, bool cycles);
    8384
    8485    static void garbageCollectorCollect();

  • trunk/Tools/ChangeLog

    r116630 r116633  
     12012-05-10  Alexander Shalamov  <alexander.shalamov@intel.com>
     2
     3        [EFL] LayoutTestController needs implementation of setTabKeyCyclesThroughElements
     4        https://bugs.webkit.org/show_bug.cgi?id=82864
     5
     6        Reviewed by Gustavo Noronha Silva.
     7
     8        Add missing implementation for setTabKeyCyclesThroughElements to EFL's LayoutTestController
     9        in order to unskip fast/events/keypress-insert-tab.html
     10
     11        * DumpRenderTree/efl/EventSender.cpp:
     12        (keyDownCallback):
     13        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
     14        (LayoutTestController::setTabKeyCyclesThroughElements):
     15
    1162012-05-10  Alexander Shalamov  <alexander.shalamov@intel.com>
    217

  • trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp

    r116625 r116633  
    265265    DumpRenderTreeSupportEfl::setJavaScriptProfilingEnabled(mainView(), false);
    266266    DumpRenderTreeSupportEfl::setLoadsSiteIconsIgnoringImageLoadingSetting(mainView(), false);
     267    DumpRenderTreeSupportEfl::setTabKeyCyclesThroughElements(mainView(), true);
    267268}
    268269

  • trunk/Tools/DumpRenderTree/efl/EventSender.cpp

    r116630 r116633  
    497497{
    498498    OwnPtr<KeyEventInfo> keyEventInfo = adoptPtr(createKeyEventInfo(context, argumentCount, arguments, exception));
    499     sendKeyDown(evas_object_evas_get(browser->mainFrame()), keyEventInfo.get());
     499    Evas_Object* mainFrame = browser->mainFrame();
     500
     501    // Focus of the main frame could be lost during the test
     502    // Therefore, setting focus to the main frame
     503    evas_object_focus_set(mainFrame, true);
     504    sendKeyDown(evas_object_evas_get(mainFrame), keyEventInfo.get());
    500505
    501506    return JSValueMakeUndefined(context);

  • trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp

    r116610 r116633  
    242242}
    243243
    244 void LayoutTestController::setTabKeyCyclesThroughElements(bool)
    245 {
    246     notImplemented();
     244void LayoutTestController::setTabKeyCyclesThroughElements(bool cycles)
     245{
     246    DumpRenderTreeSupportEfl::setTabKeyCyclesThroughElements(browser->mainView(), cycles);
    247247}
    248248
Note: See TracChangeset for help on using the changeset viewer.